fix: minor lint fixes

Author: aallam

voice/src/main/kotlin/com/algolia/instantsearch/voice/ui/RippleView.kt

@@ -4,7 +4,6 @@ import android.animation.AnimatorSet
 import android.annotation.SuppressLint
 import android.content.Context
 import android.graphics.Canvas
-import android.os.Build
 import android.util.AttributeSet
 import android.view.View
 import com.algolia.instantsearch.voice.R
@@ -24,17 +23,22 @@ class RippleView : View {
         init(attrs)
     }
 
-    constructor(context: Context, attrs: AttributeSet, defStyleAttr: Int) : super(context, attrs, defStyleAttr) {
+    constructor(context: Context, attrs: AttributeSet, defStyleAttr: Int) : super(
+        context,
+        attrs,
+        defStyleAttr
+    ) {
         init(attrs)
     }
 
     /** All circles used in this RippleView, generated during [init]. */
     private var circles = listOf<DrawableSprite>()
-    /** Current animations, filled when [State.Playing] triggers [animation] and emptied when [State.Stopped]. */
+
+    /** Current animations, filled when [State.Playing] triggers animation and emptied when [State.Stopped]. */
     private val animations = mutableMapOf<Int, AnimatorSet>()
 
     /** This runnable invalidate the view at 60 fps. */
-    private val runnableFps = object : java.lang.Runnable {
+    private val runnableFps = object : Runnable {
 
         override fun run() {
             invalidate()
@@ -118,8 +122,8 @@ class RippleView : View {
 
     override fun onSizeChanged(w: Int, h: Int, oldw: Int, oldh: Int) {
         super.onSizeChanged(w, h, oldw, oldh)
-        circles.forEach {
-            it.position.let {
+        circles.forEach { drawableSprite ->
+            drawableSprite.position.let {
                 it.x = w / 2
                 it.y = h / 2
             }

voice/src/main/kotlin/com/algolia/instantsearch/voice/ui/Voice.kt

@@ -1,20 +1,19 @@
 package com.algolia.instantsearch.voice.ui
 
-import android.Manifest
 import android.Manifest.permission.RECORD_AUDIO
 import android.app.Activity
 import android.content.Context
 import android.content.Intent
 import android.content.pm.PackageManager
 import android.net.Uri
 import android.provider.Settings
-import com.google.android.material.snackbar.BaseTransientBottomBar
-import com.google.android.material.snackbar.Snackbar
-import androidx.core.app.ActivityCompat
-import androidx.core.content.ContextCompat
 import android.view.View
 import android.widget.TextView
+import androidx.core.app.ActivityCompat
+import androidx.core.content.ContextCompat
 import com.algolia.instantsearch.voice.R
+import com.google.android.material.snackbar.BaseTransientBottomBar
+import com.google.android.material.snackbar.Snackbar
 
 /** Helper functions for voice permission handling. */
 object Voice {
@@ -48,7 +47,7 @@ object Voice {
      */
     @JvmStatic
     fun Activity.shouldExplainPermission() =
-        ActivityCompat.shouldShowRequestPermissionRationale(this, Manifest.permission.RECORD_AUDIO)
+        ActivityCompat.shouldShowRequestPermissionRationale(this, RECORD_AUDIO)
 
     /**
      * Requests the [recording permission][RECORD_AUDIO] from your activity.*/
@@ -60,8 +59,10 @@ object Voice {
     /** Opens the application's settings from a given context, so the user can enable the recording permission.*/
     @JvmStatic
     fun Context.openAppSettings() {
-        startActivity(Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS)
-            .setData(Uri.fromParts("package", packageName, null)))
+        startActivity(
+            Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS)
+                .setData(Uri.fromParts("package", packageName, null))
+        )
     }
 
     /** Displays the rationale behind requesting the recording permission via a Snackbar.
@@ -78,7 +79,8 @@ object Voice {
     ) {
         val whyText = whyAllow ?: getString(R.string.permission_rationale)
         val buttonText = (buttonAllow ?: getString(R.string.permission_button_again))
-        Snackbar.make(anchor, whyText, Snackbar.LENGTH_LONG).setAction(buttonText) { requestRecordingPermission() }.show()
+        Snackbar.make(anchor, whyText, Snackbar.LENGTH_LONG)
+            .setAction(buttonText) { requestRecordingPermission() }.show()
     }
 
     /** Guides the user to manually enable recording permission in the app's settings.
@@ -103,7 +105,8 @@ object Voice {
         val snackbar = Snackbar.make(anchor, whyText, Snackbar.LENGTH_LONG).setAction(buttonText) {
             Snackbar.make(anchor, howText, Snackbar.LENGTH_SHORT)
                 .addCallback(object : BaseTransientBottomBar.BaseCallback<Snackbar>() {
-                    override fun onDismissed(transientBottomBar: Snackbar?, event: Int) = context.openAppSettings()
+                    override fun onDismissed(transientBottomBar: Snackbar?, event: Int) =
+                        context.openAppSettings()
                 }).show()
         }
         snackbar.view.findViewById<TextView>(R.id.snackbar_text).maxLines = 2

voice/src/main/kotlin/com/algolia/instantsearch/voice/ui/VoiceInputDialogFragment.kt

@@ -49,7 +49,7 @@ class VoiceInputDialogFragment : DialogFragment() {
     // region Lifecycle
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        setStyle(DialogFragment.STYLE_NORMAL, R.style.VoiceDialogTheme)
+        setStyle(STYLE_NORMAL, R.style.VoiceDialogTheme)
         speechRecognizer = VoiceSpeechRecognizer(requireContext())
         suggestions = arguments?.getStringArray(Field.Suggestions.name)
     }
@@ -70,13 +70,13 @@ class VoiceInputDialogFragment : DialogFragment() {
             dismiss()
         }
 
-        androidView.setOnClickListenerClose(View.OnClickListener { dismiss() })
-        androidView.setOnClickMicrophoneListener(View.OnClickListener {
+        androidView.setOnClickListenerClose { dismiss() }
+        androidView.setOnClickMicrophoneListener {
             when (androidView.getMicrophoneState()) {
                 VoiceMicrophone.State.Activated -> speechRecognizer.stop()
                 VoiceMicrophone.State.Deactivated -> speechRecognizer.start()
             }
-        })
+        }
         suggestions?.let {
             androidView.setSuggestions(it)
             androidView.setSubtitle(resources.getString(R.string.input_subtitle_listening))

voice/src/main/kotlin/com/algolia/instantsearch/voice/ui/VoicePermissionDialogFragment.kt

@@ -16,7 +16,7 @@ class VoicePermissionDialogFragment : DialogFragment() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        setStyle(DialogFragment.STYLE_NORMAL, R.style.VoiceDialogTheme)
+        setStyle(STYLE_NORMAL, R.style.VoiceDialogTheme)
     }
 
     override fun onCreateView(

voice/src/main/kotlin/com/algolia/instantsearch/voice/ui/VoicePresenter.kt

@@ -4,7 +4,7 @@ import android.os.Bundle
 import android.speech.RecognitionListener
 import com.algolia.instantsearch.voice.VoiceSpeechRecognizer
 import com.algolia.instantsearch.voice.resultsRecognition
-
+import java.util.Locale
 
 class VoicePresenter(
     private val ui: VoiceUI,
@@ -23,7 +23,7 @@ class VoicePresenter(
 
         ui.setSuggestionVisibility(false)
         ui.setTitle(VoiceUI.Title.Listen)
-        matches.firstOrNull()?.capitalize()?.let(ui::setSubtitle)
+        matches.firstOrNull()?.capitalize(Locale.ROOT)?.let(ui::setSubtitle)
         hasPartialResults = true
     }