feat(Voice): showPermissionRationale helper

Author: PLNech

app/src/main/kotlin/com/algolia/instantsearch/voice/demo/MainActivity.kt

@@ -1,7 +1,6 @@
 package com.algolia.instantsearch.voice.demo
 
 import android.os.Bundle
-import android.support.design.widget.Snackbar
 import android.support.v7.app.AppCompatActivity
 import android.view.View
 import com.algolia.instantsearch.voice.VoiceSpeechRecognizer
@@ -45,7 +44,7 @@ class MainActivity : AppCompatActivity(), VoiceSpeechRecognizer.ResultsListener
         if (Voice.isRecordPermissionWithResults(requestCode, grantResults)) {
             when {
                 Voice.isPermissionGranted(grantResults) -> showVoiceDialog()
-                Voice.shouldExplainPermission(this) -> showPermissionRationale()
+                Voice.shouldExplainPermission(this) -> Voice.showPermissionRationale(getPermissionView(), this)
                 else -> Voice.showPermissionManualInstructions(getPermissionView())
             }
         }
@@ -64,11 +63,6 @@ class MainActivity : AppCompatActivity(), VoiceSpeechRecognizer.ResultsListener
         }
     }
 
-    private fun showPermissionRationale() {
-        Snackbar.make(getPermissionView(), R.string.permission_rationale, Snackbar.LENGTH_LONG)
-            .setAction(R.string.permission_button_again) { Voice.requestPermission(this) }.show()
-    }
-
     private fun getVoiceDialog() = (supportFragmentManager.findFragmentByTag(Tag.Voice.name) as? VoiceInputDialogFragment)
 
     private fun getPermissionDialog() = (supportFragmentManager.findFragmentByTag(Tag.Permission.name) as? VoicePermissionDialogFragment)

ui/src/main/kotlin/com/algolia/instantsearch/voice/ui/Voice.kt

@@ -77,32 +77,56 @@ object Voice {
                                          @StringRes buttonEnable: Int? = null,
                                          @StringRes howEnable: Int? = null) {
         return showPermissionManualInstructions(anchor,
-            whyEnable?.let { anchor.context.getString(whyEnable) },
-            buttonEnable?.let { anchor.context.getString(buttonEnable) },
-            howEnable?.let { anchor.context.getString(howEnable) })
+            whyEnable?.let { anchor.context.getText(whyEnable) },
+            buttonEnable?.let { anchor.context.getText(buttonEnable) },
+            howEnable?.let { anchor.context.getText(howEnable) })
     }
 
     /** Guides the user to manually enable recording permission in the app's settings.*/
     @JvmStatic
     fun showPermissionManualInstructions(anchor: View,
-                                         whyEnable: String? = null,
-                                         buttonEnable: String? = null,
-                                         howEnable: String? = null) {
-        val snackbar = Snackbar.make(anchor, whyEnable
-            ?: anchor.context.getString(R.string.permission_enable_rationale), Snackbar.LENGTH_LONG)
-            .setAction(buttonEnable
-                ?: anchor.context.getString(R.string.permission_button_enable)) {
-                Snackbar.make(anchor, howEnable
-                    ?: anchor.context.getString(R.string.permission_enable_instructions), Snackbar.LENGTH_SHORT)
-                    .addCallback(object : BaseTransientBottomBar.BaseCallback<Snackbar>() {
-                        override fun onDismissed(transientBottomBar: Snackbar?, event: Int) {
-                            openAppSettings(anchor.context)
-                        }
-                    }).show()
-            }
+                                         whyEnable: CharSequence? = null,
+                                         buttonEnable: CharSequence? = null,
+                                         howEnable: CharSequence? = null) {
+        val c = anchor.context
+        val whyText = (whyEnable ?: c.getText(R.string.permission_enable_rationale))
+        val buttonText = (buttonEnable ?: c.getText(R.string.permission_button_enable))
+        val howText = (howEnable ?: c.getText(R.string.permission_enable_instructions))
+
+        val snackbar = Snackbar.make(anchor, whyText, Snackbar.LENGTH_LONG).setAction(buttonText) {
+            Snackbar.make(anchor, howText, Snackbar.LENGTH_SHORT)
+                .addCallback(object : BaseTransientBottomBar.BaseCallback<Snackbar>() {
+                    override fun onDismissed(transientBottomBar: Snackbar?, event: Int) = openAppSettings(c)
+                }).show()
+        }
         (snackbar.view.findViewById(android.support.design.R.id.snackbar_text) as TextView).maxLines = 2
         snackbar.show()
     }
+
+    @JvmStatic
+    fun showPermissionRationale(anchor: View,
+                                activity: Activity) {
+        showPermissionRationale(anchor, activity, null as String?)
+    }
+
+    @Suppress("unused") // For library users
+    @JvmStatic
+    fun showPermissionRationale(anchor: View, activity: Activity,
+                                @StringRes whyAllow: Int? = null, @StringRes buttonAllow: Int? = null) {
+        @StringRes val whyRes = whyAllow ?: R.string.permission_rationale
+        @StringRes val buttonRes = (buttonAllow ?: R.string.permission_button_again)
+        Snackbar.make(anchor, whyRes, Snackbar.LENGTH_LONG).setAction(buttonRes) { requestPermission(activity) }.show()
+    }
+
+    @JvmStatic
+    fun showPermissionRationale(anchor: View,
+                                activity: Activity,
+                                whyAllow: CharSequence? = null,
+                                buttonAllow: CharSequence? = null) {
+        val whyText = whyAllow ?: activity.getString(R.string.permission_rationale)
+        val buttonText = (buttonAllow ?: activity.getString(R.string.permission_button_again))
+        Snackbar.make(anchor, whyText, Snackbar.LENGTH_LONG).setAction(buttonText) { requestPermission(activity) }.show()
+    }
 }
 
 //TODO: Expose Activity extension methods instead?