Skip to content
This repository was archived by the owner on Dec 30, 2022. It is now read-only.

Commit 1dbe2b6

Browse files
authored
chore(ci): fix e2e tests (#856)
* chore(ci): install example * add mkdir & copy * ah yes, this needs to be commited too * oops! * chore(example): fix slider * remove debug things * better condition
1 parent 80ff944 commit 1dbe2b6

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

.circleci/config.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ jobs:
6565
- run:
6666
name: End-2-End tests
6767
command: |
68-
yarn run build
69-
(
70-
cd examples/e-commerce
71-
yarn build
72-
)
68+
yarn examples:build e-commerce
7369
yarn run test:e2e:saucelabs
7470
7571
shipjs_trigger:

examples/build.sh

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ set -e
77
# go into directory of script
88
cd $(dirname `which $0`)
99

10-
for dir in ./* ; do
10+
11+
function build_example {
12+
dir=$1
1113
if [ -d "$dir" ]; then
1214
name=$(basename "$dir")
1315
echo "building example: $name"
@@ -22,6 +24,14 @@ for dir in ./* ; do
2224
fi
2325
cd ..
2426
fi
25-
done
27+
}
28+
29+
if [ $# -eq 0 ];then
30+
for dir in ./* ; do
31+
build_example $dir
32+
done
33+
else
34+
build_example $1
35+
fi
2636

2737
echo "done building examples 🙌"

examples/e-commerce/src/App.vue

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,6 @@
302302
<div
303303
slot-scope="{
304304
currentRefinement,
305-
nbPages,
306305
pages,
307306
isFirstPage,
308307
isLastPage,
@@ -515,8 +514,8 @@ export default {
515514
formatNumber,
516515
toValue(value, range) {
517516
return [
518-
value.min !== null ? value.min : range.min,
519-
value.max !== null ? value.max : range.max,
517+
typeof value.min === 'number' ? value.min : range.min,
518+
typeof value.max === 'number' ? value.max : range.max,
520519
];
521520
},
522521
getSelectedHitsPerPageValue() {

0 commit comments

Comments
 (0)