in midst of setting up transfer notifs

Author: zcesur

lib/algora/payments/payments.ex

@@ -253,17 +253,23 @@ defmodule Algora.Payments do
     end
   end
 
+  @spec execute_pending_transfers(user_id :: String.t()) :: {:ok, Stripe.Transfer.t()} | {:error, :not_found}
   def execute_pending_transfers(user_id) do
     pending_amount = get_pending_amount(user_id)
 
-    with {:ok, account} <- Repo.fetch_by(Account, user_id: user_id, provider: "stripe", payouts_enabled: true),
+    with {:ok, account} <- fetch_active_account(user_id),
          true <- Money.positive?(pending_amount) do
       initialize_and_execute_transfer(user_id, pending_amount, account)
     else
       _ -> {:ok, nil}
     end
   end
 
+  @spec fetch_active_account(user_id :: String.t()) :: {:ok, Account.t()} | {:error, :not_found}
+  def fetch_active_account(user_id) do
+    Repo.fetch_by(Account, user_id: user_id, provider: "stripe", payouts_enabled: true)
+  end
+
   defp get_pending_amount(user_id) do
     total_credits =
       Repo.one(

lib/algora_web/controllers/webhooks/stripe_controller.ex

@@ -26,9 +26,6 @@ defmodule AlgoraWeb.Webhooks.StripeController do
           set: [status: :succeeded, succeeded_at: DateTime.utc_now()]
         )
 
-      # TODO: split into two groups:
-      #     - has active payout account -> execute pending transfers
-      #     - has no active payout account -> notify user to connect payout account
       jobs_result =
         from(t in Transaction,
           where: t.group_id == ^group_id,
@@ -39,11 +36,18 @@ defmodule AlgoraWeb.Webhooks.StripeController do
         |> Enum.map(fn %{user_id: user_id} -> user_id end)
         |> Enum.uniq()
         |> Enum.reduce_while(:ok, fn user_id, :ok ->
-          case %{user_id: user_id}
-               |> ExecutePendingTransfers.new()
-               |> Oban.insert() do
-            {:ok, _job} -> {:cont, :ok}
-            error -> {:halt, error}
+          case Payments.fetch_active_account(user_id) do
+            {:ok, _account} ->
+              case %{user_id: user_id}
+                   |> ExecutePendingTransfers.new()
+                   |> Oban.insert() do
+                {:ok, _job} -> {:cont, :ok}
+                error -> {:halt, error}
+              end
+
+            {:error, :not_found} ->
+              # TODO: notify user to connect payout account
+              {:cont, :ok}
           end
         end)