refactor: replace admin_emails config with is_admin user field

Author: zcesur

config/config.exs

@@ -11,7 +11,6 @@ config :algora,
   title: "Algora",
   description:
     "Algora is a developer tool & community simplifying bounties, hiring & open source sustainability.",
-  admin_emails: ["[email protected]", "[email protected]"],
   ecto_repos: [Algora.Repo],
   generators: [timestamp_type: :utc_datetime_usec]
 

lib/algora/accounts/accounts.ex

@@ -194,10 +194,6 @@ defmodule Algora.Accounts do
     Repo.all(from u in User, where: u.id in ^user_ids, select: {u.id, u})
   end
 
-  def admin?(%User{} = user) do
-    user.email in Algora.config([:admin_emails])
-  end
-
   def update_settings(%User{} = user, attrs) do
     user |> User.settings_changeset(attrs) |> Repo.update()
   end

lib/algora/accounts/schemas/user.ex

@@ -39,6 +39,7 @@ defmodule Algora.Accounts.User do
     field :activated, :boolean, default: false
     field :max_open_attempts, :integer, default: 3
     field :manual_assignment, :boolean, default: false
+    field :is_admin, :boolean, default: false
 
     field :hourly_rate_min, Money
     field :hourly_rate_max, Money

lib/algora_web/controllers/user_auth.ex

@@ -31,7 +31,7 @@ defmodule AlgoraWeb.UserAuth do
   def on_mount(:ensure_admin, _params, session, socket) do
     case get_authenticated_user(session, socket) do
       {:ok, user} ->
-        if not Accounts.admin?(user) do
+        if not user.is_admin do
           raise(AlgoraWeb.NotFoundError)
         end
 
@@ -166,7 +166,7 @@ defmodule AlgoraWeb.UserAuth do
   def require_authenticated_admin(conn, _opts) do
     user = conn.assigns[:current_user]
 
-    if user && Algora.Accounts.admin?(user) do
+    if user && user.is_admin do
       assign(conn, :current_admin, user)
     else
       conn

priv/repo/migrations/20250111134936_add_is_admin_to_users.exs

@@ -0,0 +1,9 @@
+defmodule Algora.Repo.Migrations.AddIsAdminToUsers do
+  use Ecto.Migration
+
+  def change do
+    alter table(:users) do
+      add :is_admin, :boolean, default: false, null: false
+    end
+  end
+end

priv/repo/seeds.exs

@@ -53,7 +53,7 @@ erich =
   upsert!(
     :user,
     [:provider, :provider_id],
-    %{provider_id: github_id, last_context: pied_piper.handle}
+    %{provider_id: github_id, last_context: pied_piper.handle, is_admin: true}
   )
 
 upsert!(