in midst of implementing edits

Author: zcesur

lib/algora/bounties/jobs/notify_bounty.ex

@@ -42,17 +42,8 @@ defmodule Algora.Bounties.Jobs.NotifyBounty do
              ),
            {:ok, ticket} <-
              Workspace.ensure_ticket(Github.pat(), ticket_ref["owner"], ticket_ref["repo"], ticket_ref["number"]) do
-        %CommandResponse{}
-        |> CommandResponse.changeset(%{
-          provider: "github",
-          provider_meta: Util.normalize_struct(response),
-          provider_command_id: to_string(command_id),
-          provider_response_id: to_string(response["id"]),
-          command_source: command_source,
-          command_type: :bounty,
-          ticket_id: ticket.id
-        })
-        |> Repo.insert()
+        # TODO: update existing command response if it exists
+        create_command_response(response, command_source, command_id, ticket.id)
       end
     else
       Logger.info("""
@@ -91,26 +82,69 @@ defmodule Algora.Bounties.Jobs.NotifyBounty do
       Thank you for contributing to #{ticket_ref["owner"]}/#{ticket_ref["repo"]}!
       """
 
-      with {:ok, response} <-
-             Github.create_issue_comment(
+      ensure_command_response(token, ticket_ref, command_id, command_source, ticket, body)
+    end
+  end
+
+  defp ensure_command_response(token, ticket_ref, command_id, command_source, ticket, body) do
+    case Workspace.fetch_command_response("github", command_id, command_source) do
+      {:ok, response} ->
+        case Github.update_issue_comment(
                token,
                ticket_ref["owner"],
                ticket_ref["repo"],
-               ticket_ref["number"],
+               response.provider_response_id,
                body
              ) do
-        %CommandResponse{}
-        |> CommandResponse.changeset(%{
-          provider: "github",
-          provider_meta: Util.normalize_struct(response),
-          provider_command_id: to_string(command_id),
-          provider_response_id: to_string(response["id"]),
-          command_source: command_source,
-          command_type: :bounty,
-          ticket_id: ticket.id
-        })
-        |> Repo.insert()
-      end
+          {:ok, _comment} ->
+            try_update_command_response(response, body)
+
+          {:error, "404 Not Found"} ->
+            with {:ok, _} <- Workspace.delete_command_response(response.id) do
+              post_response(token, ticket_ref, command_id, command_source, ticket, body)
+            end
+
+          {:error, reason} ->
+            Logger.error("Failed to update command response #{response.id} with body #{body}")
+            {:error, reason}
+        end
+
+      {:error, _reason} ->
+        post_response(token, ticket_ref, command_id, command_source, ticket, body)
+    end
+  end
+
+  defp post_response(token, ticket_ref, command_id, command_source, ticket, body) do
+    with {:ok, comment} <-
+           Github.create_issue_comment(token, ticket_ref["owner"], ticket_ref["repo"], ticket_ref["number"], body) do
+      create_command_response(comment, command_source, command_id, ticket.id)
+    end
+  end
+
+  defp create_command_response(comment, command_source, command_id, ticket_id) do
+    %CommandResponse{}
+    |> CommandResponse.changeset(%{
+      provider: "github",
+      provider_meta: Util.normalize_struct(comment),
+      provider_command_id: to_string(command_id),
+      provider_response_id: to_string(comment["id"]),
+      command_source: command_source,
+      command_type: :bounty,
+      ticket_id: ticket_id
+    })
+    |> Repo.insert()
+  end
+
+  defp try_update_command_response(command_response, body) do
+    case command_response
+         |> CommandResponse.changeset(%{provider_meta: Util.normalize_struct(body)})
+         |> Repo.update() do
+      {:ok, command_response} ->
+        {:ok, command_response}
+
+      {:error, _reason} ->
+        Logger.error("Failed to update command response #{command_response.id}")
+        {:ok, command_response}
     end
   end
 end

lib/algora/integrations/github/behaviour.ex

@@ -17,6 +17,7 @@ defmodule Algora.Github.Behaviour do
   @callback find_installation(token(), integer(), integer()) :: response
   @callback get_installation_token(integer()) :: response
   @callback create_issue_comment(token(), String.t(), String.t(), integer(), String.t()) :: response
+  @callback update_issue_comment(token(), String.t(), String.t(), integer(), String.t()) :: response
   @callback list_repository_events(token(), String.t(), String.t(), keyword()) :: response
   @callback list_repository_comments(token(), String.t(), String.t(), keyword()) :: response
   @callback add_labels(token(), String.t(), String.t(), integer(), [String.t()]) :: response

lib/algora/integrations/github/client.ex

@@ -176,6 +176,16 @@ defmodule Algora.Github.Client do
     )
   end
 
+  @impl true
+  def update_issue_comment(access_token, owner, repo, comment_id, body) do
+    fetch(
+      access_token,
+      "/repos/#{owner}/#{repo}/issues/comments/#{comment_id}",
+      "PATCH",
+      %{body: body}
+    )
+  end
+
   @impl true
   def list_repository_events(access_token, owner, repo, opts \\ []) do
     fetch(access_token, "/repos/#{owner}/#{repo}/events#{build_query(opts)}")

lib/algora/integrations/github/github.ex

@@ -84,6 +84,10 @@ defmodule Algora.Github do
   def create_issue_comment(token, owner, repo, number, body),
     do: client().create_issue_comment(token, owner, repo, number, body)
 
+  @impl true
+  def update_issue_comment(token, owner, repo, comment_id, body),
+    do: client().update_issue_comment(token, owner, repo, comment_id, body)
+
   @impl true
   def list_repository_events(token, owner, repo, opts \\ []),
     do: client().list_repository_events(token, owner, repo, opts)

lib/algora/workspace/workspace.ex

@@ -5,6 +5,7 @@ defmodule Algora.Workspace do
   alias Algora.Accounts.User
   alias Algora.Github
   alias Algora.Repo
+  alias Algora.Workspace.CommandResponse
   alias Algora.Workspace.Installation
   alias Algora.Workspace.Jobs
   alias Algora.Workspace.Repository
@@ -153,4 +154,15 @@ defmodule Algora.Workspace do
   def list_user_installations(user_id) do
     Repo.all(from(i in Installation, where: i.owner_id == ^user_id, preload: [:connected_user]))
   end
+
+  def fetch_command_response(provider, command_id, command_source) do
+    Repo.fetch_one(
+      from cr in CommandResponse,
+        where: cr.provider == ^provider,
+        where: cr.provider_command_id == ^to_string(command_id),
+        where: cr.command_source == ^command_source
+    )
+  end
+
+  def delete_command_response(id), do: Repo.delete(Repo.get(CommandResponse, id))
 end

lib/algora_web/controllers/webhooks/github_controller.ex

@@ -67,8 +67,6 @@ defmodule AlgoraWeb.Webhooks.GithubController do
           {:ticket, issue["id"]}
       end
 
-    dbg({command_source, command_id})
-
     # TODO: community bounties?
     with {:ok, "admin"} <- get_permissions(author, params),
          {:ok, token} <- Github.get_installation_token(installation_id),