refactor: rename parsed field

Author: zcesur

lib/algora/integrations/github/command.ex

@@ -49,10 +49,10 @@ defmodule Algora.Github.Command do
       |> ignore()
       |> concat(ignore(whitespace()))
       |> choice([
-        amount() |> concat(ignore(whitespace())) |> concat(username()),
-        username() |> concat(ignore(whitespace())) |> concat(amount()),
+        amount() |> concat(ignore(whitespace())) |> concat(recipient()),
+        recipient() |> concat(ignore(whitespace())) |> concat(amount()),
         amount(),
-        username()
+        recipient()
       ])
       |> tag(:tip)
       |> label(@usage.tip)

lib/algora/integrations/github/poller/comment_consumer.ex

@@ -26,7 +26,7 @@ defmodule Algora.Github.Poller.CommentConsumer do
 
   defp run_command({:tip, args}, ticket_ref, _comment) do
     amount = Keyword.get(args, :amount)
-    recipient = Keyword.get(args, :username)
+    recipient = Keyword.get(args, :recipient)
     owner = Keyword.get(ticket_ref, :owner)
     repo = Keyword.get(ticket_ref, :repo)
     number = Keyword.get(ticket_ref, :number)

lib/algora/shared/parser.ex

@@ -21,12 +21,12 @@ defmodule Algora.Parser do
       |> label("amount (e.g. 1000 or 1,000.00)")
     end
 
-    def username do
+    def recipient do
       "@"
       |> string()
       |> ignore()
       |> concat(word_chars())
-      |> unwrap_and_tag(:username)
+      |> unwrap_and_tag(:recipient)
       |> label("username starting with @")
     end
 

test/algora/github/command_test.exs

@@ -49,12 +49,12 @@ defmodule Algora.Github.CommandTest do
 
   describe "parse/1 with tip command" do
     test "parses tip with amount first" do
-      assert {:ok, %{tip: [{:amount, ~M[100]usd}, {:username, "user"}]}} ==
+      assert {:ok, %{tip: [{:amount, ~M[100]usd}, {:recipient, "user"}]}} ==
                Command.parse("/tip 100 @user")
     end
 
-    test "parses tip with username first" do
-      assert {:ok, %{tip: [{:username, "user"}, {:amount, ~M[100]usd}]}} ==
+    test "parses tip with recipient first" do
+      assert {:ok, %{tip: [{:recipient, "user"}, {:amount, ~M[100]usd}]}} ==
                Command.parse("/tip @user 100")
     end
 
@@ -63,8 +63,8 @@ defmodule Algora.Github.CommandTest do
                Command.parse("/tip 100")
     end
 
-    test "parses tip with only username" do
-      assert {:ok, %{tip: [{:username, "user"}]}} ==
+    test "parses tip with only recipient" do
+      assert {:ok, %{tip: [{:recipient, "user"}]}} ==
                Command.parse("/tip @user")
     end
   end
@@ -126,15 +126,15 @@ defmodule Algora.Github.CommandTest do
       assert {:ok,
               %{
                 bounty: [{:amount, Money.new!(100, :USD)}],
-                tip: [{:amount, Money.new!(50, :USD)}, {:username, "user"}]
+                tip: [{:amount, Money.new!(50, :USD)}, {:recipient, "user"}]
               }} == Command.parse("/bounty 100 /tip 50 @user")
     end
 
     test "handles text between commands" do
       assert {:ok,
               %{
                 bounty: [{:amount, Money.new!(100, :USD)}],
-                tip: [{:username, "user"}, {:amount, Money.new!(50, :USD)}]
+                tip: [{:recipient, "user"}, {:amount, Money.new!(50, :USD)}]
               }} == Command.parse("Hello /bounty 100 world /tip @user 50")
     end
   end