feat: update phx-hide-modal to utilize on_cancel for improved modal behavior

zcesur · zcesur · commit 25e27ed846b5 · 2025-03-24T14:30:55.000+02:00
diff --git a/lib/algora_web/components/ui/dialog.ex b/lib/algora_web/components/ui/dialog.ex
@@ -50,7 +50,7 @@ defmodule AlgoraWeb.Components.UI.Dialog do
       phx-mounted={@show && JS.exec("phx-show-modal", to: "##{@id}")}
       phx-remove={JS.exec("phx-hide-modal", to: "##{@id}")}
       phx-show-modal={show_modal(@id)}
-      phx-hide-modal={hide_modal(@id)}
+      phx-hide-modal={@on_cancel |> hide_modal(@id)}
       class="group/dialog relative z-50 hidden"
     >
       <div

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ defmodule AlgoraWeb.Components.UI.Dialog do`
`50`	`50`	`phx-mounted={@show && JS.exec("phx-show-modal", to: "##{@id}")}`
`51`	`51`	`phx-remove={JS.exec("phx-hide-modal", to: "##{@id}")}`
`52`	`52`	`phx-show-modal={show_modal(@id)}`
`53`		`- phx-hide-modal={hide_modal(@id)}`
	`53`	`+ phx-hide-modal={@on_cancel \|> hide_modal(@id)}`
`54`	`54`	`class="group/dialog relative z-50 hidden"`
`55`	`55`	`>`
`56`	`56`	`<div`