fix miscellanea

Author: zcesur

lib/algora/bounties/jobs/notify_transfer.ex

@@ -8,6 +8,7 @@ defmodule Algora.Bounties.Jobs.NotifyTransfer do
   alias Algora.Github
   alias Algora.Payments.Transaction
   alias Algora.Repo
+  alias Algora.Workspace.Installation
   alias Algora.Workspace.Ticket
 
   require Logger
@@ -41,7 +42,7 @@ defmodule Algora.Bounties.Jobs.NotifyTransfer do
                where: tx.type == :transfer,
                select_merge: %{user: user}
            ) do
-      installation = Repo.get(Installation, connected_user_id: ticket.repository.user.id)
+      installation = Repo.get_by(Installation, provider_user_id: ticket.repository.user.id)
       body = "🎉🎈 @#{transaction.user.provider_login} has been awarded **#{transaction.net_amount}**! 🎈🎊"
 
       do_perform(ticket_ref, body, installation)
@@ -50,15 +51,16 @@ defmodule Algora.Bounties.Jobs.NotifyTransfer do
 
   defp do_perform(ticket_ref, body, nil) do
     Github.try_without_installation(&Github.create_issue_comment/5, [
-      ticket_ref["owner"],
-      ticket_ref["repo"],
-      ticket_ref["number"],
+      ticket_ref.owner,
+      ticket_ref.repo,
+      ticket_ref.number,
       body
     ])
   end
 
   defp do_perform(ticket_ref, body, installation) do
-    {:ok, token} = Github.get_installation_token(installation.id)
-    Github.create_issue_comment(token, ticket_ref["owner"], ticket_ref["repo"], ticket_ref["number"], body)
+    with {:ok, token} <- Github.get_installation_token(installation.provider_id) do
+      Github.create_issue_comment(token, ticket_ref.owner, ticket_ref.repo, ticket_ref.number, body)
+    end
   end
 end

lib/algora/integrations/github/github.ex

@@ -49,8 +49,9 @@ defmodule Algora.Github do
     if pat_enabled() do
       apply(function, [pat() | args])
     else
-      {module, name} = Function.info(function, :name)
-      function_name = "#{module}.#{name}"
+      {_, module} = Function.info(function, :module)
+      {_, name} = Function.info(function, :name)
+      function_name = String.trim_leading("#{module}.#{name}", "Elixir.")
 
       formatted_args =
         Enum.map_join(args, ", ", fn

lib/algora/payments/payments.ex

@@ -418,6 +418,10 @@ defmodule Algora.Payments do
       provider: "stripe",
       type: :transfer,
       status: :initialized,
+      tip_id: credit.tip_id,
+      bounty_id: credit.bounty_id,
+      contract_id: credit.contract_id,
+      claim_id: credit.claim_id,
       user_id: credit.user_id,
       gross_amount: credit.net_amount,
       net_amount: credit.net_amount,
@@ -427,6 +431,10 @@ defmodule Algora.Payments do
     |> Algora.Validations.validate_positive(:gross_amount)
     |> Algora.Validations.validate_positive(:net_amount)
     |> foreign_key_constraint(:user_id)
+    |> foreign_key_constraint(:tip_id)
+    |> foreign_key_constraint(:bounty_id)
+    |> foreign_key_constraint(:contract_id)
+    |> foreign_key_constraint(:claim_id)
     |> Repo.insert()
   end