fix: skip redundant auth step in installation flow

Author: zcesur

lib/algora/integrations/github/github.ex

@@ -13,9 +13,9 @@ defmodule Algora.Github do
   def pat, do: Algora.config([:github, :pat])
   def pat_enabled, do: Algora.config([:github, :pat_enabled])
 
-  def install_url do
-    "https://github.com/apps/#{app_handle()}/installations/new"
-  end
+  def install_url_base, do: "https://github.com/apps/#{app_handle()}/installations"
+  def install_url_new, do: "#{install_url_base()}/new"
+  def install_url_select_target, do: "#{install_url_base()}/select_target"
 
   defp oauth_state_ttl, do: 600
   defp oauth_state_salt, do: "github-oauth-state"

lib/algora_web/live/org/settings_live.ex

@@ -116,8 +116,7 @@ defmodule AlgoraWeb.Org.SettingsLive do
   end
 
   def handle_info({:authenticated, user}, socket) do
-    # TODO: skip auth step in installation flow
-    {:noreply, socket |> assign(:current_user, user) |> redirect(external: Github.install_url())}
+    {:noreply, socket |> assign(:current_user, user) |> redirect(external: Github.install_url_select_target())}
   end
 
   def handle_event("install_app", _params, socket) do

lib/algora_web/live/user/installations_live.ex

@@ -99,7 +99,7 @@ defmodule AlgoraWeb.User.InstallationsLive do
       <.link
         class="relative block w-full rounded-lg border-2 border-dashed border-gray-600 p-8 text-center hover:border-gray-500 focus:outline-none focus:ring-2 focus:ring-indigo-500 focus:ring-offset-2"
         rel="noopener"
-        href={Github.install_url()}
+        href={Github.install_url_new()}
       >
         <svg
           xmlns="http://www.w3.org/2000/svg"