Merge branch 'main' of github.com:algora-io/console into vibe/code

zcesur · zcesur · commit 45ebec09e6f7 · 2025-03-17T20:02:45.000+02:00
diff --git a/lib/algora/activities/discord_views.ex b/lib/algora/activities/discord_views.ex
@@ -21,7 +21,7 @@ defmodule Algora.Activities.DiscordViews do
               "https://github.com/#{bounty.ticket.repository.user.provider_login}/#{bounty.ticket.repository.name}/issues/#{bounty.ticket.number}"
           },
           footer: %{
-            text: "Created by #{bounty.creator.name}",
+            text: bounty.creator.name,
             icon_url: bounty.creator.avatar_url
           },
           thumbnail: %{url: bounty.owner.avatar_url},
diff --git a/lib/algora_web/controllers/webhooks/github_controller.ex b/lib/algora_web/controllers/webhooks/github_controller.ex
@@ -5,6 +5,7 @@ defmodule AlgoraWeb.Webhooks.GithubController do
   import Ecto.Query
 
   alias Algora.Accounts
+  alias Algora.Activities.SendDiscord
   alias Algora.Bounties
   alias Algora.Bounties.Bounty
   alias Algora.Bounties.Claim
@@ -22,16 +23,26 @@ defmodule AlgoraWeb.Webhooks.GithubController do
 
   require Logger
 
-  # TODO: persist & alert about failed deliveries
-  # TODO: auto-retry failed deliveries with exponential backoff
+  # TODO: auto-retry failed deliveries with backoff
 
   def process_delivery(webhook) do
     with :ok <- ensure_human_author(webhook),
          {:ok, commands} <- process_commands(webhook),
          :ok <- process_event(webhook, commands) do
       Logger.debug("✅ #{inspect(webhook.event_action)}")
+      notify_event(webhook, :ok)
       :ok
+    else
+      {:error, reason} ->
+        Logger.error("❌ #{inspect(webhook.event_action)}: #{inspect(reason)}")
+        notify_event(webhook, {:error, reason})
+        {:error, reason}
     end
+  rescue
+    error ->
+      Logger.error("❌ #{inspect(webhook.event_action)}: #{inspect(error)}")
+      notify_event(webhook, {:error, error})
+      {:error, error}
   end
 
   defp ensure_human_author(%Webhook{author: author}) do
@@ -301,12 +312,7 @@ defmodule AlgoraWeb.Webhooks.GithubController do
         "pull_request" -> {:ticket, payload["pull_request"]["id"]}
       end
 
-    ticket_number =
-      case webhook.event do
-        "issue_comment" -> payload["issue"]["number"]
-        "issues" -> payload["issue"]["number"]
-        "pull_request" -> payload["pull_request"]["number"]
-      end
+    ticket_number = get_github_ticket(webhook)["number"]
 
     # TODO: perform compensating action if needed
     # ❌ comment1.created (:set) -> comment2.created (:increase) -> comment2.edited (:increase)
@@ -624,12 +630,8 @@ defmodule AlgoraWeb.Webhooks.GithubController do
     if recipient == author["login"], do: nil, else: recipient
   end
 
-  defp handle_ticket_state_change(%Webhook{event: event, payload: payload, event_action: event_action}) do
-    github_ticket =
-      case event do
-        "issues" -> payload["issue"]
-        "pull_request" -> payload["pull_request"]
-      end
+  defp handle_ticket_state_change(%Webhook{payload: payload, event_action: event_action} = webhook) do
+    github_ticket = get_github_ticket(webhook)
 
     state =
       if event_action == "issues.deleted" do
@@ -659,4 +661,110 @@ defmodule AlgoraWeb.Webhooks.GithubController do
         end
     end
   end
+
+  defp notify_event(%Webhook{event_action: event_action, author: author, payload: payload} = webhook, :ok) do
+    with github_ticket when not is_nil(github_ticket) <- get_github_ticket(webhook),
+         ticket when not is_nil(ticket) <-
+           Workspace.get_ticket(
+             payload["repository"]["owner"]["login"],
+             payload["repository"]["name"],
+             github_ticket["number"]
+           ) do
+      discord_payload = %{
+        payload: %{
+          embeds: [
+            %{
+              color: 0x64748B,
+              title: event_action,
+              author: %{
+                name: payload["repository"]["owner"]["login"],
+                icon_url: payload["repository"]["owner"]["avatar_url"],
+                url: github_ticket["html_url"]
+              },
+              footer: %{
+                text: author["login"],
+                icon_url: author["avatar_url"]
+              },
+              fields: [
+                %{
+                  name: "Ticket",
+                  value: "#{payload["repository"]["name"]}##{github_ticket["number"]}: #{github_ticket["title"]}",
+                  inline: false
+                }
+              ],
+              url: github_ticket["html_url"],
+              timestamp: DateTime.utc_now()
+            }
+          ]
+        }
+      }
+
+      case discord_payload |> SendDiscord.changeset() |> Repo.insert() do
+        {:ok, _} ->
+          :ok
+
+        {:error, reason} ->
+          Logger.error("Error sending discord notification: #{inspect(reason)}")
+          {:error, reason}
+      end
+    else
+      _ -> :ok
+    end
+  end
+
+  defp notify_event(%Webhook{event_action: event_action, author: author, payload: payload} = webhook, {:error, error}) do
+    case get_github_ticket(webhook) do
+      github_ticket when not is_nil(github_ticket) ->
+        discord_payload = %{
+          payload: %{
+            embeds: [
+              %{
+                color: 0xEF4444,
+                title: event_action,
+                description: inspect(error),
+                author: %{
+                  name: payload["repository"]["owner"]["login"],
+                  icon_url: payload["repository"]["owner"]["avatar_url"],
+                  url: github_ticket["html_url"]
+                },
+                footer: %{
+                  text: author["login"],
+                  icon_url: author["avatar_url"]
+                },
+                fields: [
+                  %{
+                    name: "Ticket",
+                    value: "#{payload["repository"]["name"]}##{github_ticket["number"]}: #{github_ticket["title"]}",
+                    inline: false
+                  }
+                ],
+                url: github_ticket["html_url"],
+                timestamp: DateTime.utc_now()
+              }
+            ]
+          }
+        }
+
+        case discord_payload |> SendDiscord.changeset() |> Repo.insert() do
+          {:ok, _} ->
+            :ok
+
+          {:error, reason} ->
+            Logger.error("Error sending discord notification: #{inspect(reason)}")
+            {:error, reason}
+        end
+
+      _ ->
+        :ok
+    end
+  end
+
+  defp get_github_ticket(%Webhook{event: event, payload: payload}) do
+    case event do
+      "issues" -> payload["issue"]
+      "issue_comment" -> payload["issue"]
+      "pull_request" -> payload["pull_request"]
+      _ -> nil
+    end
+  end
 end
diff --git a/lib/algora_web/controllers/webhooks/stripe_controller.ex b/lib/algora_web/controllers/webhooks/stripe_controller.ex
@@ -4,6 +4,7 @@ defmodule AlgoraWeb.Webhooks.StripeController do
   import Ecto.Changeset
   import Ecto.Query
 
+  alias Algora.Activities.SendDiscord
   alias Algora.Bounties
   alias Algora.Bounties.Bounty
   alias Algora.Bounties.Tip
@@ -19,11 +20,38 @@ defmodule AlgoraWeb.Webhooks.StripeController do
   @metadata_version Payments.metadata_version()
 
   @impl true
-  def handle_event(%Stripe.Event{
-        type: "charge.succeeded",
-        data: %{object: %Stripe.Charge{metadata: %{"version" => @metadata_version, "group_id" => group_id}}}
-      })
-      when is_binary(group_id) do
+  def handle_event(%Stripe.Event{} = event) do
+    result =
+      case process_event(event) do
+        :ok -> :ok
+        {:ok, _} -> :ok
+        {:error, reason} -> {:error, reason}
+        :error -> {:error, :unknown_error}
+      end
+
+    case result do
+      :ok ->
+        Logger.debug("✅ #{inspect(event.type)}")
+        notify_event(event, :ok)
+        :ok
+
+      {:error, reason} ->
+        Logger.error("❌ #{inspect(event.type)}: #{inspect(reason)}")
+        notify_event(event, {:error, reason})
+        {:error, reason}
+    end
+  rescue
+    error ->
+      Logger.error("❌ #{inspect(event.type)}: #{inspect(error)}")
+      notify_event(event, {:error, error})
+      {:error, error}
+  end
+
+  defp process_event(%Stripe.Event{
+         type: "charge.succeeded",
+         data: %{object: %Stripe.Charge{metadata: %{"version" => @metadata_version, "group_id" => group_id}}}
+       })
+       when is_binary(group_id) do
     Repo.transact(fn ->
       {_, txs} =
         Repo.update_all(from(t in Transaction, where: t.group_id == ^group_id, select: t),
@@ -77,11 +105,10 @@ defmodule AlgoraWeb.Webhooks.StripeController do
     end)
   end
 
-  @impl true
-  def handle_event(%Stripe.Event{
-        type: "transfer.created",
-        data: %{object: %Stripe.Transfer{metadata: %{"version" => @metadata_version}} = transfer}
-      }) do
+  defp process_event(%Stripe.Event{
+         type: "transfer.created",
+         data: %{object: %Stripe.Transfer{metadata: %{"version" => @metadata_version}} = transfer}
+       }) do
     with {:ok, transaction} <- Repo.fetch_by(Transaction, provider: "stripe", provider_id: transfer.id),
          {:ok, _transaction} <- maybe_update_transaction(transaction, transfer),
          {:ok, _job} <- Oban.insert(Bounties.Jobs.NotifyTransfer.new(%{transfer_id: transaction.id})) do
@@ -94,11 +121,10 @@ defmodule AlgoraWeb.Webhooks.StripeController do
     end
   end
 
-  @impl true
-  def handle_event(%Stripe.Event{
-        type: "checkout.session.completed",
-        data: %{object: %Stripe.Session{customer: customer_id, mode: "setup", setup_intent: setup_intent_id}}
-      }) do
+  defp process_event(%Stripe.Event{
+         type: "checkout.session.completed",
+         data: %{object: %Stripe.Session{customer: customer_id, mode: "setup", setup_intent: setup_intent_id}}
+       }) do
     with {:ok, setup_intent} <- Algora.PSP.SetupIntent.retrieve(setup_intent_id, %{}),
          pm_id = setup_intent.payment_method,
          {:ok, payment_method} <- Algora.PSP.PaymentMethod.attach(%{payment_method: pm_id, customer: customer_id}),
@@ -109,13 +135,11 @@ defmodule AlgoraWeb.Webhooks.StripeController do
     end
   end
 
-  @impl true
-  def handle_event(%Stripe.Event{type: "checkout.session.completed"} = event) do
+  defp process_event(%Stripe.Event{type: "checkout.session.completed"} = event) do
     Logger.info("Stripe #{event.type} event: #{event.id}")
   end
 
-  @impl true
-  def handle_event(_event), do: :ok
+  defp process_event(_event), do: :ok
 
   defp maybe_update_transaction(transaction, transfer) do
     if transaction.status == :succeeded do
@@ -130,4 +154,85 @@ defmodule AlgoraWeb.Webhooks.StripeController do
       |> Repo.update()
     end
   end
+
+  defp notify_event(%Stripe.Event{} = event, :ok) do
+    discord_payload = %{
+      payload: %{
+        embeds: [
+          %{
+            color: 0x64748B,
+            title: event.type,
+            footer: %{
+              text: "Stripe",
+              icon_url: "https://github.com/stripe.png"
+            },
+            fields: [
+              %{
+                name: "Event",
+                value: event.id,
+                inline: true
+              },
+              %{
+                name: event.data.object.object,
+                value: event.data.object.id,
+                inline: true
+              }
+            ],
+            url: "https://dashboard.stripe.com/payments?status[0]=successful",
+            timestamp: DateTime.utc_now()
+          }
+        ]
+      }
+    }
+
+    case discord_payload |> SendDiscord.changeset() |> Repo.insert() do
+      {:ok, _} ->
+        :ok
+
+      {:error, reason} ->
+        Logger.error("Error sending discord notification: #{inspect(reason)}")
+        {:error, reason}
+    end
+  end
+
+  defp notify_event(%Stripe.Event{} = event, {:error, error}) do
+    discord_payload = %{
+      payload: %{
+        embeds: [
+          %{
+            color: 0xEF4444,
+            title: event.type,
+            # description: inspect(error),
+            footer: %{
+              text: "Stripe",
+              icon_url: "https://github.com/stripe.png"
+            },
+            fields: [
+              %{
+                name: "Event",
+                value: event.id,
+                inline: true
+              },
+              %{
+                name: event.data.object.object,
+                value: event.data.object.id,
+                inline: true
+              }
+            ],
+            url: "https://dashboard.stripe.com/payments?status[0]=failed",
+            timestamp: DateTime.utc_now()
+          }
+        ]
+      }
+    }
+
+    case discord_payload |> SendDiscord.changeset() |> Repo.insert() do
+      {:ok, _} ->
+        :ok
+
+      {:error, reason} ->
+        Logger.error("Error sending discord notification: #{inspect(reason)}")
+        {:error, reason}
+    end
+  end
 end
diff --git a/lib/algora_web/live/home_live.ex b/lib/algora_web/live/home_live.ex
@@ -13,13 +13,16 @@ defmodule AlgoraWeb.HomeLive do
   alias Algora.Payments.Transaction
   alias Algora.PSP.ConnectCountries
   alias Algora.Repo
+  alias Algora.Workspace
   alias AlgoraWeb.Components.Footer
   alias AlgoraWeb.Components.Header
   alias AlgoraWeb.Components.Wordmarks
   alias AlgoraWeb.Data.PlatformStats
   alias AlgoraWeb.Forms.BountyForm
   alias AlgoraWeb.Forms.TipForm
 
+  require Logger
+
   @impl true
   def mount(%{"country_code" => country_code}, _session, socket) do
     Gettext.put_locale(AlgoraWeb.Gettext, Algora.Util.locale_from_country_code(country_code))
diff --git a/test/algora_web/controllers/webhooks/stripe_controller_test.exs b/test/algora_web/controllers/webhooks/stripe_controller_test.exs
