fix: preserve bounty visibility when editing GitHub comments

- Fix bug where editing GitHub comments with /bounty commands set visibility to null
- Update bounty update strategies (:set and :increase) to preserve existing visibility when no new visibility provided
- Add comprehensive test suite covering all visibility types (public, community, exclusive)
- Ensure bounties remain discoverable after comment edits
- Maintain backward compatibility for explicit visibility overrides

Fixes issue where bounties would disappear from app discovery after GitHub comment edits.

Author: zcesur

lib/algora/bounties/bounties.ex

@@ -160,7 +160,7 @@ defmodule Algora.Bounties do
                   existing
                   |> Bounty.changeset(%{
                     amount: amount,
-                    visibility: opts[:visibility],
+                    visibility: opts[:visibility] || existing.visibility,
                     shared_with: shared_with
                   })
                   # |> Activity.put_activity(%Bounty{}, %{type: :bounty_updated, notify_users: []})
@@ -170,7 +170,7 @@ defmodule Algora.Bounties do
                   existing
                   |> Bounty.changeset(%{
                     amount: Money.add!(existing.amount, amount),
-                    visibility: opts[:visibility],
+                    visibility: opts[:visibility] || existing.visibility,
                     shared_with: shared_with
                   })
                   # |> Activity.put_activity(%Bounty{}, %{type: :bounty_updated, notify_users: []})

test/algora/bounties_test.exs

@@ -221,6 +221,152 @@ defmodule Algora.BountiesTest do
       transfer = Repo.one(from t in Transaction, where: t.type == :transfer)
       assert is_nil(transfer)
     end
+
+    test "preserves visibility when editing bounty comment", %{owner: owner, creator: creator, ticket_ref: ticket_ref} do
+      # Create initial bounty with explicit visibility
+      {:ok, bounty} =
+        Bounties.create_bounty(%{
+          ticket_ref: ticket_ref,
+          owner: owner |> change(%{bounty_mode: :public}) |> Repo.update!(),
+          creator: creator,
+          amount: ~M[100]usd,
+          visibility: :public
+        })
+
+      assert bounty.visibility == :public
+
+      # Simulate editing the bounty comment (like GitHub webhook would do)
+      # This should preserve the existing visibility, not set it to nil
+      {:ok, updated_bounty} =
+        Bounties.create_bounty(
+          %{
+            ticket_ref: ticket_ref,
+            owner: owner,
+            creator: creator,
+            amount: ~M[200]usd
+          },
+          strategy: :set
+        )
+
+      assert updated_bounty.visibility == :public
+    end
+
+    test "preserves visibility when increasing bounty amount", %{owner: owner, creator: creator, ticket_ref: ticket_ref} do
+      # Create initial bounty with community visibility
+      {:ok, bounty} =
+        Bounties.create_bounty(%{
+          ticket_ref: ticket_ref,
+          owner: owner |> change(%{bounty_mode: :community}) |> Repo.update!(),
+          creator: creator,
+          amount: ~M[100]usd,
+          visibility: :community
+        })
+
+      assert bounty.visibility == :community
+
+      # Simulate adding to bounty amount (like GitHub webhook would do)
+      {:ok, updated_bounty} =
+        Bounties.create_bounty(
+          %{
+            ticket_ref: ticket_ref,
+            owner: owner,
+            creator: creator,
+            amount: ~M[50]usd
+          },
+          strategy: :increase
+        )
+
+      assert updated_bounty.visibility == :community
+    end
+
+    test "preserves exclusive visibility when updating bounty", %{owner: owner, creator: creator, ticket_ref: ticket_ref} do
+      # Create initial bounty with exclusive visibility
+      {:ok, bounty} =
+        Bounties.create_bounty(%{
+          ticket_ref: ticket_ref,
+          owner: owner |> change(%{bounty_mode: :exclusive}) |> Repo.update!(),
+          creator: creator,
+          amount: ~M[500]usd,
+          visibility: :exclusive
+        })
+
+      assert bounty.visibility == :exclusive
+
+      # Simulate webhook edit without visibility parameter
+      {:ok, updated_bounty} =
+        Bounties.create_bounty(
+          %{
+            ticket_ref: ticket_ref,
+            owner: owner,
+            creator: creator,
+            amount: ~M[750]usd
+          },
+          strategy: :set
+        )
+
+      assert updated_bounty.visibility == :exclusive
+    end
+
+    test "handles nil visibility options without overriding existing value", %{
+      owner: owner,
+      creator: creator,
+      ticket_ref: ticket_ref
+    } do
+      # Create initial bounty
+      {:ok, bounty} =
+        Bounties.create_bounty(%{
+          ticket_ref: ticket_ref,
+          owner: owner |> change(%{bounty_mode: :public}) |> Repo.update!(),
+          creator: creator,
+          amount: ~M[100]usd
+        })
+
+      original_visibility = bounty.visibility
+
+      # Simulate what happens when GitHub webhook doesn't pass visibility option
+      {:ok, updated_bounty} =
+        Bounties.create_bounty(
+          %{
+            ticket_ref: ticket_ref,
+            owner: owner,
+            creator: creator,
+            amount: ~M[200]usd
+          },
+          # Empty options - no visibility passed
+          []
+        )
+
+      assert updated_bounty.visibility == original_visibility
+    end
+
+    test "allows explicit visibility override when provided", %{owner: owner, creator: creator, ticket_ref: ticket_ref} do
+      # Create initial bounty with public visibility
+      {:ok, bounty} =
+        Bounties.create_bounty(%{
+          ticket_ref: ticket_ref,
+          owner: owner |> change(%{bounty_mode: :public}) |> Repo.update!(),
+          creator: creator,
+          amount: ~M[100]usd,
+          visibility: :public
+        })
+
+      assert bounty.visibility == :public
+
+      # Explicitly change visibility to community
+      {:ok, updated_bounty} =
+        Bounties.create_bounty(
+          %{
+            ticket_ref: ticket_ref,
+            owner: owner,
+            creator: creator,
+            amount: ~M[200]usd
+          },
+          strategy: :set,
+          visibility: :community
+        )
+
+      assert updated_bounty.visibility == :community
+    end
   end
 
   describe "tips" do

test/algora_web/controllers/webhooks/github_controller_test.exs

@@ -191,6 +191,71 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
 
       assert Money.equal?(Repo.one(Bounty).amount, ~M[300]usd)
     end
+
+    test "editing GitHub comment with /bounty command preserves bounty visibility", ctx do
+      comment_id = :rand.uniform(1000)
+
+      process_scenario!(ctx, [
+        %{
+          event_action: "issue_comment.created",
+          user_type: :repo_admin,
+          body: "/bounty $100",
+          params: %{"comment" => %{"id" => comment_id}}
+        }
+      ])
+
+      bounty = Repo.one(Bounty)
+      original_visibility = bounty.visibility
+      assert original_visibility != nil
+
+      process_scenario!(ctx, [
+        %{
+          event_action: "issue_comment.edited",
+          user_type: :repo_admin,
+          body: "/bounty $200",
+          params: %{"comment" => %{"id" => comment_id}}
+        }
+      ])
+
+      updated_bounty = Repo.one(Bounty)
+      assert updated_bounty.visibility == original_visibility
+    end
+
+    test "visibility preserved when adding to existing bounty via new comment", ctx do
+      # Create initial bounty with exclusive visibility
+      process_scenario!(ctx, [
+        %{
+          event_action: "issue_comment.created",
+          user_type: :repo_admin,
+          body: "/bounty $500",
+          params: %{"comment" => %{"id" => 1}}
+        }
+      ])
+
+      original_bounty = Repo.one(Bounty)
+      # Set to exclusive mode for this test
+      _updated_owner = ctx[:org] |> change(%{bounty_mode: :exclusive}) |> Repo.update!()
+      updated_bounty = original_bounty |> change(%{visibility: :exclusive}) |> Repo.update!()
+
+      original_visibility = updated_bounty.visibility
+      assert original_visibility == :exclusive
+
+      # Add to bounty with new comment (this increases the amount)
+      process_scenario!(ctx, [
+        %{
+          event_action: "issue_comment.created",
+          user_type: :repo_admin,
+          body: "/bounty $100",
+          params: %{"comment" => %{"id" => 2}}
+        }
+      ])
+
+      final_bounty = Repo.one(Bounty)
+      assert final_bounty.amount.amount >= 600
+
+      # This test should now PASS with the fix - visibility is preserved
+      assert final_bounty.visibility == original_visibility
+    end
   end
 
   describe "create tips" do