capture expected error logs in tests

Author: zcesur

test/algora/payments_test.exs

@@ -1,6 +1,8 @@
 defmodule Algora.PaymentsTest do
   use Algora.DataCase
 
+  import ExUnit.CaptureLog
+
   alias Algora.Payments
   alias Algora.Payments.Account
   alias Algora.Payments.Transaction
@@ -99,7 +101,8 @@ defmodule Algora.PaymentsTest do
 
       Account |> Repo.one!() |> change(%{provider_id: "acct_invalid"}) |> Repo.update!()
 
-      assert {:error, _} = Payments.execute_pending_transfers(user.id)
+      {result, _log} = with_log(fn -> Payments.execute_pending_transfers(user.id) end)
+      assert {:error, %Stripe.Error{code: :invalid_request_error}} = result
 
       transfer_tx = Repo.one(from t in Transaction, where: t.type == :transfer)
       assert transfer_tx.status == :failed

test/algora_web/controllers/webhooks/github_controller_test.exs

@@ -5,6 +5,7 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
 
   import Algora.Factory
   import Ecto.Query
+  import ExUnit.CaptureLog
   import Money.Sigil
 
   alias Algora.Bounties.Bounty
@@ -33,7 +34,8 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
   describe "create bounties" do
     test "handles bounty command with unauthorized user", ctx do
       scenario = [%{event_action: "issue_comment.created", user_type: :unauthorized, body: "/bounty $100"}]
-      assert {:error, :unauthorized} = process_scenario(ctx, scenario)
+      {result, _log} = with_log(fn -> process_scenario(ctx, scenario) end)
+      assert {:error, :unauthorized} = result
       assert Repo.aggregate(Bounty, :count) == 0
     end