customize webhook url per alert severity

Author: zcesur

lib/algora/activities/activities.ex

@@ -300,7 +300,12 @@ defmodule Algora.Activities do
 
     discord_job =
       if discord_payload = DiscordViews.render(activity) do
-        [Algora.Activities.SendDiscord.changeset(%{payload: discord_payload})]
+        [
+          Algora.Activities.SendDiscord.changeset(%{
+            url: Algora.config([:discord, :webhook_url]),
+            payload: discord_payload
+          })
+        ]
       else
         []
       end

lib/algora/activities/jobs/send_discord.ex

@@ -11,7 +11,7 @@ defmodule Algora.Activities.SendDiscord do
   end
 
   @impl Oban.Worker
-  def perform(%Oban.Job{args: %{"payload" => payload}}) do
-    Algora.Discord.send_message(payload)
+  def perform(%Oban.Job{args: %{"url" => url, "payload" => payload}}) do
+    Algora.Discord.send_message(url, payload)
   end
 end

lib/algora/admin/admin.ex

@@ -469,6 +469,7 @@ defmodule Algora.Admin do
     Logger.error(message)
 
     %{
+      url: Algora.config([:discord, :webhook_url]),
       payload: %{
         embeds: [
           %{
@@ -489,16 +490,19 @@ defmodule Algora.Admin do
 
     email_job =
       Algora.Activities.SendEmail.changeset(%{
-        title: "Error: #{message}",
+        title: "#{message}",
         body: message,
-        name: "Algora Alert",
+        name: "Action required",
         email: "[email protected]"
       })
 
     discord_job =
       SendDiscord.changeset(%{
+        url: Algora.Settings.get("discord_webhook_url")["critical"] || Algora.config([:discord, :webhook_url]),
         payload: %{
-          embeds: [%{color: color(severity), title: "Error", description: message, timestamp: DateTime.utc_now()}]
+          embeds: [
+            %{color: color(severity), title: "Action required", description: message, timestamp: DateTime.utc_now()}
+          ]
         }
       })
 
@@ -509,6 +513,7 @@ defmodule Algora.Admin do
     Logger.info(message)
 
     %{
+      url: Algora.config([:discord, :webhook_url]),
       payload: %{
         embeds: [
           %{

lib/algora/integrations/discord/client.ex

@@ -3,15 +3,8 @@ defmodule Algora.Discord.Client do
 
   require Logger
 
-  def webhook_url, do: Algora.config([:discord, :webhook_url])
-
-  def post(data) do
-    if url = webhook_url() do
-      do_post(url, data)
-    else
-      {:ok, nil}
-    end
-  end
+  def post(nil, _data), do: {:ok, nil}
+  def post(url, data), do: do_post(url, data)
 
   defp do_post(url, data) do
     headers = [{"Content-Type", "application/json"}]

lib/algora/integrations/discord/discord.ex

@@ -21,10 +21,10 @@ defmodule Algora.Discord do
 
   ## Examples
 
-      iex> Discord.send_message(%{content: "Hello, world!"})
+      iex> Discord.send_message("https://discord.com/api/webhooks/1234567890/abcdefg", %{content: "Hello, world!"})
       {:ok, response}
 
-      iex> Discord.send_message(%{
+      iex> Discord.send_message("https://discord.com/api/webhooks/1234567890/abcdefg", %{
       ...>   embeds: [
       ...>     %{
       ...>       color: 0x6366f1,
@@ -41,15 +41,15 @@ defmodule Algora.Discord do
       ...> })
       {:ok, response}
   """
-  @spec send_message(map()) :: {:ok, map() | nil} | {:error, any()}
-  def send_message(input) do
+  @spec send_message(String.t(), map()) :: {:ok, map() | nil} | {:error, any()}
+  def send_message(url, input) do
     input =
       Map.merge(
         %{username: "Algora.io", avatar_url: "https://algora.io/asset/storage/v1/object/public/images/logo-256px.png"},
         input
       )
 
-    case Client.post(input) do
+    case Client.post(url, input) do
       {:ok, response} ->
         {:ok, response}
 

lib/algora_web/live/org/job_live.ex

@@ -704,7 +704,7 @@ defmodule AlgoraWeb.Org.JobLive do
           })
           |> Repo.update()
 
-        Algora.Admin.alert("Wire intent: #{inspect(changeset.changes)}", :info)
+        Algora.Admin.alert("Wire intent: #{inspect(changeset.changes)}", :critical)
 
         {:noreply,
          socket