Skip to content

Commit a893510

Browse files
committed
use sequence for mock IDs in github controller tests
1 parent 805df2e commit a893510

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/algora_web/controllers/webhooks/github_controller_test.exs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
503503
stub(
504504
Algora.GithubMock,
505505
:create_issue_comment,
506-
fn _token, _owner, _repo, _issue_number, _body -> {:ok, %{"id" => 1}} end
506+
fn _token, _owner, _repo, _number, _body -> {:ok, %{"id" => sequence(:github_comment_id, & &1)}} end
507507
)
508508
end
509509

@@ -519,14 +519,14 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
519519
stub(
520520
Algora.GithubMock,
521521
:get_issue,
522-
fn _token, owner, repo, issue_number ->
522+
fn _token, owner, repo, number ->
523523
{:ok,
524524
%{
525-
"id" => 123,
526-
"number" => issue_number,
525+
"id" => sequence(:github_issue_id, & &1),
526+
"number" => number,
527527
"title" => "Test Issue",
528528
"body" => "Test body",
529-
"html_url" => "https://github.com/#{owner}/#{repo}/issues/#{issue_number}"
529+
"html_url" => "https://github.com/#{owner}/#{repo}/issues/#{number}"
530530
}}
531531
end
532532
)
@@ -539,7 +539,7 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
539539
fn _token, owner, repo ->
540540
{:ok,
541541
%{
542-
"id" => 123,
542+
"id" => sequence(:github_repository_id, & &1),
543543
"name" => repo,
544544
"html_url" => "https://github.com/#{owner}/#{repo}"
545545
}}

0 commit comments

Comments
 (0)