improve notif handling

Author: zcesur

lib/algora/bounties/jobs/notify_claim.ex

@@ -16,19 +16,33 @@ defmodule Algora.Bounties.Jobs.NotifyClaim do
   @impl Oban.Worker
   def perform(%Oban.Job{args: %{"claim_id" => claim_id, "installation_id" => installation_id}}) do
     with {:ok, token} <- Github.get_installation_token(installation_id),
-         {:ok, claim} <- Repo.fetch(Claim, claim_id) do
-      claim = Repo.preload(claim, ticket: [repository: [:user]], user: [])
+         {:ok, claim} <- Repo.fetch(Claim, claim_id),
+         claim = Repo.preload(claim, ticket: [repository: [:user]], user: []),
+         {:ok, _} <- maybe_add_labels(token, claim),
+         {:ok, _} <- add_comment(token, claim) do
+      :ok
+    end
+  end
 
-      # TODO: implement
-      claim_reward_url = "#{AlgoraWeb.Endpoint.url()}/claims/#{claim.id}"
+  defp add_comment(token, claim) do
+    Github.create_issue_comment(
+      token,
+      claim.ticket.repository.user.provider_login,
+      claim.ticket.repository.name,
+      claim.ticket.number,
+      "💡 @#{claim.user.provider_login} submitted [#{Claim.type_label(claim.type)}](#{claim.url}) that claims the bounty. You can visit [Algora](#{Claim.reward_url(claim)}) to reward."
+    )
+  end
 
-      Github.create_issue_comment(
-        token,
-        claim.ticket.repository.user.provider_login,
-        claim.ticket.repository.name,
-        claim.ticket.number,
-        "💡 @#{claim.user.provider_login} submitted [#{Claim.type_label(claim.type)}](#{claim.url}) that claims the bounty. You can visit [Algora](#{claim_reward_url}) to reward."
-      )
-    end
+  defp maybe_add_labels(token, %Claim{type: :pull_request} = claim) do
+    Github.add_labels(
+      token,
+      claim.provider_meta["base"]["repo"]["owner"]["login"],
+      claim.provider_meta["base"]["repo"]["name"],
+      claim.provider_meta["number"],
+      ["🙋 Bounty claim"])
+    
   end
+
+  defp maybe_add_labels(_token, _claim), do: {:ok, nil}
 end

lib/algora/bounties/schemas/claim.ex

@@ -79,6 +79,8 @@ defmodule Algora.Bounties.Claim do
   def type_label(:article), do: "an article"
   def type_label(nil), do: "a URL"
 
+  def reward_url(claim), do: "#{AlgoraWeb.Endpoint.url()}/claims/#{claim.id}"
+
   def rewarded(query \\ Claim) do
     from c in query,
       where: c.state == :approved and not is_nil(c.charged_at)

lib/algora/integrations/github/behaviour.ex

@@ -1,5 +1,6 @@
 defmodule Algora.Github.Behaviour do
   @moduledoc false
+
   @type token :: String.t()
   @type response :: {:ok, map()} | {:error, any()}
 
@@ -15,9 +16,8 @@ defmodule Algora.Github.Behaviour do
   @callback list_installations(token(), integer()) :: response
   @callback find_installation(token(), integer(), integer()) :: response
   @callback get_installation_token(integer()) :: response
-  @callback create_issue_comment(token(), String.t(), String.t(), integer(), String.t()) ::
-              response
-
+  @callback create_issue_comment(token(), String.t(), String.t(), integer(), String.t()) :: response
   @callback list_repository_events(token(), String.t(), String.t(), keyword()) :: response
   @callback list_repository_comments(token(), String.t(), String.t(), keyword()) :: response
+  @callback add_labels(token(), String.t(), String.t(), integer(), [String.t()]) :: response
 end

lib/algora/integrations/github/client.ex

@@ -180,4 +180,9 @@ defmodule Algora.Github.Client do
   def list_repository_comments(access_token, owner, repo, opts \\ []) do
     fetch(access_token, "/repos/#{owner}/#{repo}/issues/comments#{build_query(opts)}")
   end
+
+  @impl true
+  def add_labels(access_token, owner, repo, number, labels) do
+    fetch(access_token, "/repos/#{owner}/#{repo}/issues/#{number}/labels", "POST", %{labels: labels})
+  end
 end

lib/algora/integrations/github/github.ex

@@ -91,4 +91,7 @@ defmodule Algora.Github do
   @impl true
   def list_repository_comments(token, owner, repo, opts \\ []),
     do: client().list_repository_comments(token, owner, repo, opts)
+
+  @impl true
+  def add_labels(token, owner, repo, number, labels), do: client().add_labels(token, owner, repo, number, labels)
 end