require amount in slash bounty command

Author: zcesur

lib/algora/integrations/github/command.ex

@@ -38,7 +38,7 @@ defmodule Algora.Github.Command do
       "/bounty"
       |> string()
       |> ignore()
-      |> concat(whitespace() |> ignore() |> concat(amount()) |> optional())
+      |> concat(whitespace() |> ignore() |> concat(amount()))
       |> tag(:bounty)
       |> label(@usage.bounty)
     end

lib/algora_web/controllers/webhooks/github_controller.ex

@@ -48,50 +48,44 @@ defmodule AlgoraWeb.Webhooks.GithubController do
   defp get_permissions(_author, _params), do: {:error, :invalid_params}
 
   defp execute_command({:bounty, args}, author, params) do
-    amount = Keyword.get(args, :amount)
+    amount = Keyword.fetch!(args, :amount)
 
     case get_permissions(author, params) do
       {:ok, "admin"} ->
-        case amount do
-          nil ->
-            {:ok, :open_to_bids}
-
-          amount ->
-            # Get repository and issue details from params
-            repo = params["repository"]
-            issue = params["issue"]
-
-            # Construct the bounty message
-            message = """
-            ## 💎 $#{amount} bounty [• #{repo["owner"]["login"]}](https://console.algora.io/org/#{repo["owner"]["login"]})
-            ### Steps to solve:
-            1. **Start working**: Comment `/attempt ##{issue["number"]}` with your implementation plan
-            2. **Submit work**: Create a pull request including `/claim ##{issue["number"]}` in the PR body to claim the bounty
-            3. **Receive payment**: 100% of the bounty is received 2-5 days post-reward. [Make sure you are eligible for payouts](https://docs.algora.io/bounties/payments#supported-countries-regions)
-
-            Thank you for contributing to #{repo["full_name"]}!
-
-            **[Add a bounty](https://console.algora.io/org/#{repo["owner"]["login"]}/bounties/community?fund=#{repo["full_name"]}%23#{issue["number"]})** • **[Share on socials](https://twitter.com/intent/tweet?text=%24#{amount}+bounty%21+%F0%9F%92%8E+#{issue["html_url"]}&related=algoraio)**
-
-            Attempt | Started (GMT+0) | Solution
-            --------|----------------|----------
-            """
-
-            # Post comment to the issue
-            with {:ok, %{"token" => token}} <-
-                   Github.get_installation_token(params["installation"]["id"]) do
-              Github.create_issue_comment(
-                token,
-                repo["owner"]["login"],
-                repo["name"],
-                issue["number"],
-                message
-              )
-            end
-
-            {:ok, amount}
+        # Get repository and issue details from params
+        repo = params["repository"]
+        issue = params["issue"]
+
+        # Construct the bounty message
+        message = """
+        ## 💎 $#{amount} bounty [• #{repo["owner"]["login"]}](https://console.algora.io/org/#{repo["owner"]["login"]})
+        ### Steps to solve:
+        1. **Start working**: Comment `/attempt ##{issue["number"]}` with your implementation plan
+        2. **Submit work**: Create a pull request including `/claim ##{issue["number"]}` in the PR body to claim the bounty
+        3. **Receive payment**: 100% of the bounty is received 2-5 days post-reward. [Make sure you are eligible for payouts](https://docs.algora.io/bounties/payments#supported-countries-regions)
+
+        Thank you for contributing to #{repo["full_name"]}!
+
+        **[Add a bounty](https://console.algora.io/org/#{repo["owner"]["login"]}/bounties/community?fund=#{repo["full_name"]}%23#{issue["number"]})** • **[Share on socials](https://twitter.com/intent/tweet?text=%24#{amount}+bounty%21+%F0%9F%92%8E+#{issue["html_url"]}&related=algoraio)**
+
+        Attempt | Started (GMT+0) | Solution
+        --------|----------------|----------
+        """
+
+        # Post comment to the issue
+        with {:ok, %{"token" => token}} <-
+               Github.get_installation_token(params["installation"]["id"]) do
+          Github.create_issue_comment(
+            token,
+            repo["owner"]["login"],
+            repo["name"],
+            issue["number"],
+            message
+          )
         end
 
+        {:ok, amount}
+
       {:ok, _permission} ->
         {:error, :unauthorized}
 

test/algora_web/controllers/webhooks/github_controller_test.exs

@@ -29,11 +29,11 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
 
     @tag user: @unauthorized_user
     test "handles bounty command with unauthorized user", %{user: user} do
-      assert [error: :unauthorized] == process_bounty_command("/bounty", user)
+      assert [error: :unauthorized] == process_bounty_command("/bounty $100", user)
     end
 
     test "handles bounty command without amount" do
-      assert [ok: :open_to_bids] == process_bounty_command("/bounty")
+      assert [] == process_bounty_command("/bounty")
     end
 
     test "handles valid bounty command with $ prefix" do