add basic coverage for bounties, chat and reviews and coveralls.json

lastcanal · lastcanal · commit c1a902aa4041 · 2025-01-12T21:19:38.000-05:00
diff --git a/config/test.exs b/config/test.exs
@@ -47,3 +47,7 @@ config :algora,
   cloudflare_tunnel: System.get_env("CLOUDFLARE_TUNNEL"),
   swift_mode: false,
   auto_start_pollers: System.get_env("AUTO_START_POLLERS") == "true"
+
+config :algora, :stripe,
+  test_customer_id: System.get_env("STRIPE_TEST_CUSTOMER_ID"),
+  test_account_id: System.get_env("STRIPE_TEST_ACCOUNT_ID")
diff --git a/coveralls.json b/coveralls.json
@@ -0,0 +1,30 @@
+{
+  "skip_files": [
+    "lib/algora/repo.ex",
+    "lib/algora/s3.ex",
+    "lib/algora/integrations",
+    "lib/algora/\\w+/schemas/\\w+.ex",
+    "lib/algora/shared/*",
+    "lib/algora_web/components",
+    "lib/algora_web/live",
+    "lib/algora_web/\\w+.ex",
+    "lib/mix/tasks",
+    "priv/",
+    "test/support"
+  ],
+  "default_stop_words": [
+    "defmodule",
+    "defrecord",
+    "defimpl",
+    "def.+(.+\/\/.+).+do"
+  ],
+
+  "custom_stop_words": [
+  ],
+
+  "coverage_options": {
+    "treat_no_relevant_lines_as_covered": true,
+    "output_dir": "cover/",
+    "html_filter_full_covered": true
+  }
+}
diff --git a/lib/algora/activities/activities.ex b/lib/algora/activities/activities.ex
@@ -1,6 +1,5 @@
 defmodule Algora.Activities do
   @moduledoc false
-  import Ecto.Changeset
   import Ecto.Query
 
   alias Algora.Activities.Activity
diff --git a/lib/algora/activities/schemas/activity.ex b/lib/algora/activities/schemas/activity.ex
@@ -45,7 +45,7 @@ defmodule Algora.Activities.Activity do
   end
 
   def build_activity(target, %{meta: %struct{}} = activity) when struct in [Stripe.Error] do
-    build_activity(target, %{activity | meta: Algora.Utils.normalize_struct(struct)})
+    build_activity(target, %{activity | meta: Algora.Util.normalize_struct(struct)})
   end
 
   def build_activity(target, activity) do
diff --git a/lib/algora/bounties/schemas/bonus.ex b/lib/algora/bounties/schemas/bonus.ex
@@ -8,7 +8,7 @@ defmodule Algora.Bounties.Bonus do
     belongs_to :bounty, Algora.Bounties.Bounty
     belongs_to :user, Algora.Accounts.User
 
-    has_many :activities, {"bonus_activities", Algora.Activities.Activity}, foreign_key: :assoc_id
+    has_many :activities, {"bonus_activities", Activity}, foreign_key: :assoc_id
 
     timestamps()
   end
diff --git a/lib/algora/bounties/schemas/bounty.ex b/lib/algora/bounties/schemas/bounty.ex
@@ -3,7 +3,6 @@ defmodule Algora.Bounties.Bounty do
   use Algora.Schema
 
   alias Algora.Accounts.User
-  alias Algora.Activities.Activity
   alias Algora.Bounties.Bounty
   alias Algora.Payments.Transaction
 
diff --git a/lib/algora/contracts/contracts.ex b/lib/algora/contracts/contracts.ex
@@ -1,6 +1,6 @@
 defmodule Algora.Contracts do
   @moduledoc false
-  import Algora.Activities.Activity, only: [put_activity: 2, put_activity: 3]
+  import Algora.Activities.Activity, only: [put_activity: 2]
   import Ecto.Changeset
   import Ecto.Query
 
diff --git a/lib/algora/integrations/stripe/behaviour.ex b/lib/algora/integrations/stripe/behaviour.ex
@@ -4,4 +4,5 @@ defmodule Algora.Stripe.Behaviour do
   @callback create_invoice_item(map()) :: {:ok, map()} | {:error, any()}
   @callback pay_invoice(String.t(), map()) :: {:ok, map()} | {:error, any()}
   @callback create_transfer(map()) :: {:ok, map()} | {:error, any()}
+  @callback create_session(map()) :: {:ok, map()} | {:error, any()}
 end
diff --git a/lib/algora/integrations/stripe/impl.ex b/lib/algora/integrations/stripe/impl.ex
@@ -22,4 +22,9 @@ defmodule Algora.Stripe.Impl do
   def create_transfer(params) do
     Stripe.Transfer.create(params)
   end
+
+  @impl true
+  def create_session(params) do
+    Stripe.Session.create(params)
+  end
 end
diff --git a/lib/algora/integrations/stripe/stripe.ex b/lib/algora/integrations/stripe/stripe.ex
@@ -23,6 +23,11 @@ defmodule Algora.Stripe do
     impl().create_transfer(params)
   end
 
+  @impl true
+  def create_session(params) do
+    impl().create_session(params)
+  end
+
   def field_to_id(nil), do: nil
   def field_to_id(field) when is_binary(field), do: field
   def field_to_id(field), do: field.id
diff --git a/lib/algora/payments/payments.ex b/lib/algora/payments/payments.ex
@@ -28,7 +28,7 @@ defmodule Algora.Payments do
         ) ::
           {:ok, Stripe.Session.t()} | {:error, Stripe.Error.t()}
   def create_stripe_session(line_items, payment_intent_data) do
-    Stripe.Session.create(%{
+    Algora.Stripe.create_session(%{
       mode: "payment",
       billing_address_collection: "required",
       line_items: line_items,
diff --git a/lib/algora/payments/schemas/transaction.ex b/lib/algora/payments/schemas/transaction.ex
@@ -2,7 +2,6 @@ defmodule Algora.Payments.Transaction do
   @moduledoc false
   use Algora.Schema
 
-  alias Algora.Activities.Activity
   alias Algora.Contracts.Contract
   alias Algora.Types.Money
 
diff --git a/lib/algora/reviews/schemas/review.ex b/lib/algora/reviews/schemas/review.ex
@@ -23,12 +23,13 @@ defmodule Algora.Reviews.Review do
 
   def changeset(review, attrs) do
     review
-    |> cast(attrs, [:rating, :content, :visibility, :contract_id, :reviewer_id, :reviewee_id])
-    |> validate_required([:rating, :content, :contract_id, :reviewer_id, :reviewee_id])
+    |> cast(attrs, [:rating, :content, :visibility, :contract_id, :reviewer_id, :reviewee_id, :organization_id])
+    |> validate_required([:rating, :content, :contract_id, :reviewer_id, :reviewee_id, :organization_id])
     |> validate_number(:rating,
       greater_than_or_equal_to: min_rating(),
       less_than_or_equal_to: max_rating()
     )
+    |> generate_id()
   end
 
   def min_rating, do: 1
diff --git a/test/algora/bounties_test.exs b/test/algora/bounties_test.exs
@@ -0,0 +1,92 @@
+defmodule Algora.BountiesTest do
+  use Algora.DataCase
+  use Oban.Testing, repo: Algora.Repo
+
+  import Algora.Factory
+  import Money.Sigil
+
+  def setup_github_mocks(_context) do
+    import Algora.Mocks.GithubMock
+
+    setup_installation_token()
+    setup_repository_permissions()
+    setup_create_issue_comment()
+    setup_get_user_by_username()
+    setup_get_issue()
+    setup_get_repository()
+    :ok
+  end
+
+  def setup_stripe_mocks(_context) do
+    import Algora.Mocks.StripeMock
+
+    setup_create_session()
+    :ok
+  end
+
+  describe "bounties" do
+    setup [:setup_github_mocks, :setup_stripe_mocks]
+
+    test "create" do
+      creator = insert!(:user)
+      owner = insert!(:user)
+      _installation = insert!(:installation, owner: creator)
+      _identity = insert!(:identity, user: creator, provider_email: creator.email)
+      repo = insert!(:repository, %{user: owner})
+      ticket = insert!(:ticket, %{repository: repo})
+      amount = ~M[4000]usd
+
+      bounty_params =
+        %{
+          ticket_ref: %{owner: owner.handle, repo: repo.name, number: ticket.number},
+          owner: owner,
+          creator: creator,
+          amount: amount
+        }
+
+      {:ok, bounty} = Algora.Bounties.create_bounty(bounty_params, [])
+      {:ok, tip} = Algora.Bounties.create_tip(%{amount: amount, owner: owner, creator: creator, recipient: creator})
+
+      assert bounty
+      assert tip
+
+      assert_activity_names([])
+      assert_activity_names_for_user(creator.id, [])
+      assert_activity_names_for_user(owner.id, [])
+    end
+
+    test "query" do
+      [bounty | _] =
+        Enum.map(1..10, fn _n ->
+          creator = insert!(:user)
+          owner = insert!(:user)
+          _installation = insert!(:installation, owner: creator)
+          _identity = insert!(:identity, user: creator, provider_email: creator.email)
+          repo = insert!(:repository, %{user: owner})
+          ticket = insert!(:ticket, %{repository: repo})
+          amount = ~M[100]usd
+
+          bounty_params =
+            %{
+              ticket_ref: %{owner: owner.handle, repo: repo.name, number: ticket.number},
+              owner: owner,
+              creator: creator,
+              amount: amount
+            }
+
+          {:ok, bounty} = Algora.Bounties.create_bounty(bounty_params, [])
+          bounty
+        end)
+
+      assert Algora.Bounties.list_bounties(
+               owner_id: bounty.owner_id,
+               tech_stack: ["elixir"],
+               status: :open
+             )
+
+      assert Algora.Bounties.fetch_stats(bounty.owner_id)
+      assert Algora.Bounties.fetch_stats()
+      assert Algora.Bounties.PrizePool.list()
+    end
+  end
+end
diff --git a/test/algora/chat_test.exs b/test/algora/chat_test.exs
@@ -0,0 +1,31 @@
+defmodule Algora.ChatTest do
+  use Algora.DataCase
+  use Oban.Testing, repo: Algora.Repo
+
+  alias Algora.Chat
+
+  describe "chat" do
+    test "direct" do
+      user_1 = insert(:user)
+      user_2 = insert(:user)
+      {:ok, thread} = Chat.create_direct_thread(user_1, user_2)
+      {:ok, message_1} = Chat.send_message(thread.id, user_1.id, "hello")
+      {:ok, message_2} = Chat.send_message(thread.id, user_2.id, "there")
+      assert thread.id |> Chat.list_messages() |> Enum.map(& &1.id) == [message_1.id, message_2.id]
+      assert Chat.mark_as_read(thread.id, user_1.id) == {1, nil}
+      assert Chat.get_thread_for_users(user_1.id, user_2.id).id == thread.id
+      assert user_1.id |> Chat.list_threads() |> Enum.map(& &1.id) == [thread.id]
+      assert user_2.id |> Chat.list_threads() |> Enum.map(& &1.id) == [thread.id]
+    end
+
+    test "contract" do
+      client = insert(:user)
+      contractor = insert(:user)
+      contract = insert(:contract, client: client, contractor: contractor)
+      thread = Chat.get_or_create_thread!(contract)
+      assert Chat.get_or_create_thread!(contract).id == thread.id
+      assert client.id |> Chat.list_threads() |> Enum.map(& &1.id) == [thread.id]
+      assert contractor.id |> Chat.list_threads() |> Enum.map(& &1.id) == [thread.id]
+    end
+  end
+end
diff --git a/test/algora/reviews_test.exs b/test/algora/reviews_test.exs
@@ -0,0 +1,30 @@
+defmodule Algora.ReviewsTest do
+  use Algora.DataCase
+  use Oban.Testing, repo: Algora.Repo
+
+  alias Algora.Reviews
+
+  describe "reviews" do
+    test "create" do
+      reviewer = insert(:user)
+      reviewee = insert(:user)
+      org = insert(:organization)
+      contract = insert(:contract, client: reviewer, contractor: reviewee)
+
+      {:ok, review} =
+        Reviews.create_review(%{
+          rating: 5,
+          content: "NICE!",
+          visibility: :public,
+          contract_id: contract.id,
+          organization_id: org.id,
+          reviewee_id: reviewee.id,
+          reviewer_id: reviewer.id
+        })
+
+      assert [reviewee_id: reviewee.id]
+             |> Reviews.list_reviews()
+             |> Enum.map(& &1.id) == [review.id]
+    end
+  end
+end
diff --git a/test/support/data_case.ex b/test/support/data_case.ex
@@ -13,17 +13,18 @@ defmodule Algora.DataCase do
   by setting `use Algora.DataCase, async: true`, although
   this option is not recommended for other databases.
   """
-
   use ExUnit.CaseTemplate
 
   alias Ecto.Adapters.SQL.Sandbox
 
   using do
     quote do
       import Algora.DataCase
+      import Algora.Factory
       import Ecto
       import Ecto.Changeset
       import Ecto.Query
+      import Money.Sigil
 
       alias Algora.Repo
     end
diff --git a/test/support/factory.ex b/test/support/factory.ex
@@ -10,7 +10,10 @@ defmodule Algora.Factory do
     %Algora.Accounts.Identity{
       id: Nanoid.generate(),
       provider: "github",
-      provider_token: ""
+      provider_id: sequence(:provider_id, &"identity#{&1}"),
+      provider_token: sequence(:provider_token, &"token#{&1}"),
+      provider_email: sequence(:provider_email, &"identity#{&1}@example.com"),
+      provider_login: sequence(:provider_login, &"identity#{&1}")
     }
   end
 
@@ -167,7 +170,7 @@ defmodule Algora.Factory do
     %Algora.Workspace.Repository{
       id: Nanoid.generate(),
       provider: "github",
-      provider_id: sequence(:provider_id, &"#{&1}"),
+      provider_id: sequence(:provider_id, &"repository#{&1}"),
       name: "middle-out",
       url: "https://github.com/piedpiper/middle-out",
       og_image_url: "https://algora.io/asset/storage/v1/object/public/mock/piedpiper-banner.jpg",
@@ -179,7 +182,7 @@ defmodule Algora.Factory do
     %Algora.Workspace.Ticket{
       id: Nanoid.generate(),
       provider: "github",
-      provider_id: sequence(:provider_id, &"#{&1}"),
+      provider_id: sequence(:provider_id, &"ticket#{&1}"),
       type: :issue,
       title: "Optimize compression algorithm for large files",
       description: "We need to improve performance when handling files over 1GB",
@@ -199,7 +202,7 @@ defmodule Algora.Factory do
     %Algora.Bounties.Claim{
       id: Nanoid.generate(),
       provider: "github",
-      provider_id: sequence(:provider_id, &"#{&1}"),
+      provider_id: sequence(:provider_id, &"claim#{&1}"),
       type: :code,
       status: :pending,
       title: "Implemented compression optimization",
@@ -221,8 +224,8 @@ defmodule Algora.Factory do
     %Installation{
       id: Nanoid.generate(),
       provider: "github",
-      provider_id: sequence(:provider_id, &"#{&1}"),
-      provider_user_id: sequence(:provider_user_id, &"#{&1}"),
+      provider_id: sequence(:provider_id, &"installation#{&1}"),
+      provider_user_id: sequence(:provider_user_id, &"installation#{&1}"),
       provider_meta: %{
         "account" => %{"avatar_url" => "https://algora.io/asset/storage/v1/object/public/mock/piedpiper-logo.png"},
         "repository_selection" => "selected"
diff --git a/test/support/mocks/github_mock.ex b/test/support/mocks/github_mock.ex
diff --git a/test/support/mocks/stripe_mock.ex b/test/support/mocks/stripe_mock.ex
