remove vars from email subjects

Author: lastcanal

lib/algora/activities/activities.ex

@@ -306,7 +306,7 @@ defmodule Algora.Activities do
   end
 
   def activity_email_title(activity) do
-    apply(Views, :"#{activity.type}_title", [activity, activity.assoc])
+    apply(Views, :"#{activity.type}_title", [])
   end
 
   def activity_email_body(activity) do

lib/algora/activities/views.ex

@@ -9,7 +9,7 @@ defmodule Algora.Activities.Views do
 
   Enum.each(Activity.types(), fn type ->
     base_type = type |> to_string() |> String.split("_") |> List.first() |> String.to_atom()
+    EEx.function_from_file(:def, :"#{type}_title", Path.join(@base_path, "#{type}.title.eex"), [])
     EEx.function_from_file(:def, :"#{type}_txt", Path.join(@base_path, "#{type}.txt.eex"), [:activity, base_type])
-    EEx.function_from_file(:def, :"#{type}_title", Path.join(@base_path, "#{type}.title.eex"), [:activity, base_type])
   end)
 end

lib/algora/activities/views/contract_paid.title.eex

@@ -1 +1 @@
-A contract between <%= contract.client.display_name %> and <%= contract.contractor.display_name %> has been paid.
+A contract between has been paid on Algora

lib/algora/activities/views/contract_paid.txt.eex

@@ -1,2 +1,3 @@
+A contract between "<%= contract.client.display_name %>" and "<%= contract.contractor.display_name %>" has been paid.
 
 <%= Algora.Activities.external_url(activity) %>

lib/algora/activities/views/contract_prepaid.title.eex

@@ -1 +1 @@
-A contract between <%= contract.client.display_name %> and <%= contract.contractor.display_name %> has been prepaid.
+A contract between has been prepaid on Algora

lib/algora/activities/views/contract_prepaid.txt.eex

@@ -1,2 +1,3 @@
+A contract for "<%= contract.client.display_name %>" has been prepaid.
 
 <%= Algora.Activities.external_url(activity) %>

lib/algora/activities/views/contract_renewed.title.eex

@@ -1 +1 @@
-A contract between <%= contract.client.display_name %> and <%= contract.contractor.display_name %> has been renewed.
+A contract between has been renewed on Algora

lib/algora/activities/views/contract_renewed.txt.eex

@@ -1,2 +1,3 @@
+A contract between "<%= contract.client.display_name %>" and "<%= contract.contractor.display_name %>" has been renewed.
 
 <%= Algora.Activities.external_url(activity) %>