update tests

Author: zcesur

lib/algora_web/controllers/webhooks/github_controller.ex

@@ -13,8 +13,8 @@ defmodule AlgoraWeb.Webhooks.GithubController do
   # TODO: auto-retry failed deliveries with exponential backoff
 
   def new(conn, params) do
-    with {:ok, %Webhook{event: event}} <- Webhook.new(conn),
-         {:ok, _} <- process_commands(event, params) do
+    with {:ok, webhook} <- Webhook.new(conn),
+         {:ok, _} <- process_commands(webhook, params) do
       conn |> put_status(:accepted) |> json(%{status: "ok"})
     else
       {:error, :missing_header} ->
@@ -149,10 +149,10 @@ defmodule AlgoraWeb.Webhooks.GithubController do
   end
 
   defp execute_command(_event_action, _command, _author, _params) do
-    {:error, :unhandled_command}
+    {:ok, nil}
   end
 
-  def process_commands(event, params) do
+  def process_commands(%Webhook{event: event, hook_id: hook_id}, params) do
     author = get_author(event, params)
     body = get_body(event, params)
 
@@ -167,7 +167,7 @@ defmodule AlgoraWeb.Webhooks.GithubController do
 
             error ->
               Logger.error(
-                "Command execution failed for #{event_action}(#{event["id"]}): #{inspect(command)}: #{inspect(error)}"
+                "Command execution failed for #{event_action}(#{hook_id}): #{inspect(command)}: #{inspect(error)}"
               )
 
               {:halt, error}

test/algora_web/controllers/webhooks/github_controller_test.exs

@@ -5,6 +5,7 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
   import Money.Sigil
   import Mox
 
+  alias Algora.Github.Webhook
   alias AlgoraWeb.Webhooks.GithubController
 
   setup :verify_on_exit!
@@ -15,7 +16,20 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
   @repo_name "repo"
   @installation_id 123
 
+  @webhook %Webhook{
+    event: "issue_comment",
+    hook_id: "123456789",
+    delivery: "00000000-0000-0000-0000-000000000000",
+    signature: "sha1=0000000000000000000000000000000000000000",
+    signature_256: "sha256=0000000000000000000000000000000000000000000000000000000000000000",
+    user_agent: "GitHub-Hookshot/0000000",
+    installation_type: "integration",
+    installation_id: "123456"
+  }
+
   @params %{
+    "id" => 123,
+    "action" => "created",
     "repository" => %{
       "owner" => %{"login" => @repo_owner},
       "name" => @repo_name
@@ -202,7 +216,7 @@ defmodule AlgoraWeb.Webhooks.GithubControllerTest do
     """
 
     GithubController.process_commands(
-      "issue_comment",
+      @webhook,
       Map.put(@params, "comment", %{"user" => %{"login" => author}, "body" => body})
     )
   end