improve observability for webhook events

Author: zcesur

lib/algora_web/controllers/webhooks/github_controller.ex

@@ -573,20 +573,19 @@ defmodule AlgoraWeb.Webhooks.GithubController do
     end
   end
 
+  defp execute_command(_webhook, {cmd, _args}) when cmd in [:bounty, :tip, :claim, :attempt] do
+    {:ok, nil}
+  end
+
   defp execute_command(webhook, command) do
     github_ticket = get_github_ticket(webhook)
 
-    message =
-      "Received unknown command: #{inspect(command)}. Ticket: #{github_ticket["html_url"]}. Hook ID: #{webhook.hook_id}"
-
-    case Algora.Admin.alert(message) do
-      [] ->
-        Logger.error(message)
-        {:error, :unknown_command}
+    Algora.Admin.alert(
+      "Received unknown command: #{inspect(command)}. Ticket: #{github_ticket["html_url"]}. Hook ID: #{webhook.hook_id}",
+      :error
+    )
 
-      _jobs ->
-        :ok
-    end
+    {:error, :unknown_command}
   end
 
   def build_command({:claim, args}, commands) do

lib/algora_web/controllers/webhooks/stripe_controller.ex

@@ -47,8 +47,6 @@ defmodule AlgoraWeb.Webhooks.StripeController do
       {:error, error}
   end
 
-  @tracked_events ["charge.succeeded", "transfer.created", "checkout.session.completed"]
-
   defp process_event(
          %Stripe.Event{
            type: "charge.succeeded",
@@ -98,7 +96,13 @@ defmodule AlgoraWeb.Webhooks.StripeController do
     end
   end
 
-  defp process_event(%Stripe.Event{type: type} = event) when type in @tracked_events do
+  defp process_event(%Stripe.Event{type: type} = event) when type in ["checkout.session.completed"] do
+    Algora.Admin.alert("Unhandled Stripe event: #{event.type} #{event.id}", :info)
+    :ok
+  end
+
+  defp process_event(%Stripe.Event{type: type} = event)
+       when type in ["charge.succeeded", "transfer.created", "checkout.session.completed"] do
     Algora.Admin.alert("Unhandled Stripe event: #{event.type} #{event.id}", :error)
     :ok
   end
@@ -199,12 +203,12 @@ defmodule AlgoraWeb.Webhooks.StripeController do
               %{
                 name: "Event",
                 value: event.id,
-                inline: true
+                inline: false
               },
               %{
                 name: event.data.object.object,
                 value: event.data.object.id,
-                inline: true
+                inline: false
               }
             ],
             url: "https://dashboard.stripe.com/payments?status[0]=successful",
@@ -240,12 +244,12 @@ defmodule AlgoraWeb.Webhooks.StripeController do
               %{
                 name: "Event",
                 value: event.id,
-                inline: true
+                inline: false
               },
               %{
                 name: event.data.object.object,
                 value: event.data.object.id,
-                inline: true
+                inline: false
               }
             ],
             url: "https://dashboard.stripe.com/payments?status[0]=failed",