properly set ids

Author: zcesur

lib/algora/bounties/bounties.ex

@@ -125,18 +125,15 @@ defmodule Algora.Bounties do
           {:ok, Claim.t()} | {:error, atom()}
   defp do_claim_bounty(%{user: user, ticket: ticket, pull_request: pull_request}) do
     # TODO: ensure user is pull request author
-    id = Nanoid.generate()
-
     changeset =
       Claim.changeset(%Claim{}, %{
         ticket_id: ticket.id,
         user_id: user.id,
         provider: "github",
-        provider_id: pull_request["id"],
-        provider_meta: pull_request,
+        provider_id: to_string(pull_request["id"]),
+        provider_meta: Util.normalize_struct(pull_request),
         title: pull_request["title"],
         url: pull_request["html_url"],
-        group_id: id,
         merged_at: Util.to_date(pull_request["merged_at"])
       })
 

lib/algora/bounties/jobs/notify_claim.ex

@@ -14,6 +14,7 @@ defmodule Algora.Bounties.Jobs.NotifyClaim do
   @impl Oban.Worker
   def perform(%Oban.Job{args: %{"ticket_ref" => ticket_ref, "installation_id" => installation_id}}) do
     with {:ok, token} <- Github.get_installation_token(installation_id) do
+      # TODO: update message
       body = "Claimed!"
 
       Github.create_issue_comment(

lib/algora/bounties/schemas/claim.ex

@@ -53,14 +53,22 @@ defmodule Algora.Bounties.Claim do
       :provider_id,
       :provider_meta,
       :title,
-      :url,
-      :group_id
+      :url
     ])
+    |> generate_id()
+    |> put_group_id()
     |> foreign_key_constraint(:ticket_id)
     |> foreign_key_constraint(:user_id)
     |> unique_constraint([:ticket_id, :user_id])
   end
 
+  def put_group_id(changeset) do
+    case get_field(changeset, :group_id) do
+      nil -> put_change(changeset, :group_id, get_field(changeset, :id))
+      _existing -> changeset
+    end
+  end
+
   def rewarded(query \\ Claim) do
     from c in query,
       where: c.state == :approved and not is_nil(c.charged_at)