refactor: update generate_line_items function to include owner parameter

- Modified the generate_line_items function to accept an owner parameter, allowing for dynamic fee percentage calculation based on the owner's fee_pct.
- Updated all calls to generate_line_items to pass the owner along with the amount, ensuring consistency across the module.

Author: zcesur

lib/algora/bounties/bounties.ex

@@ -707,22 +707,22 @@ defmodule Algora.Bounties do
   end
 
   @spec generate_line_items(
-          %{amount: Money.t()},
+          %{owner: User.t(), amount: Money.t()},
           opts :: [
             ticket_ref: %{owner: String.t(), repo: String.t(), number: integer()},
             claims: [Claim.t()],
             recipient: User.t()
           ]
         ) ::
           [LineItem.t()]
-  def generate_line_items(%{amount: amount}, opts \\ []) do
+  def generate_line_items(%{owner: owner, amount: amount}, opts \\ []) do
     ticket_ref = opts[:ticket_ref]
     recipient = opts[:recipient]
     claims = opts[:claims] || []
 
     description = if(ticket_ref, do: "#{ticket_ref[:repo]}##{ticket_ref[:number]}")
 
-    platform_fee_pct = FeeTier.calculate_fee_percentage(Money.zero(:USD))
+    platform_fee_pct = Decimal.div(owner.fee_pct, 100)
     transaction_fee_pct = Payments.get_transaction_fee_pct()
 
     payouts =
@@ -779,7 +779,7 @@ defmodule Algora.Bounties do
     tx_group_id = Nanoid.generate()
 
     line_items =
-      generate_line_items(%{amount: amount},
+      generate_line_items(%{owner: owner, amount: amount},
         ticket_ref: opts[:ticket_ref],
         recipient: opts[:recipient],
         claims: opts[:claims]
@@ -835,7 +835,7 @@ defmodule Algora.Bounties do
     tx_group_id = Nanoid.generate()
 
     line_items =
-      generate_line_items(%{amount: amount},
+      generate_line_items(%{owner: owner, amount: amount},
         ticket_ref: opts[:ticket_ref],
         recipient: opts[:recipient],
         claims: opts[:claims]

lib/algora_web/live/claim_live.ex

@@ -255,7 +255,11 @@ defmodule AlgoraWeb.ClaimLive do
 
   defp assign_line_items(socket) do
     line_items =
-      Bounties.generate_line_items(%{amount: calculate_final_amount(socket.assigns.reward_bounty_form.source)},
+      Bounties.generate_line_items(
+        %{
+          owner: socket.assigns.selected_context,
+          amount: calculate_final_amount(socket.assigns.reward_bounty_form.source)
+        },
         ticket_ref: ticket_ref(socket),
         claims: socket.assigns.claims
       )

test/algora/bounties_test.exs

@@ -53,7 +53,7 @@ defmodule Algora.BountiesTest do
 
       assert {:ok, bounty} = Bounties.create_bounty(bounty_params, [])
 
-      assert bounty.visibility == :public
+      assert bounty.visibility == :community
 
       assert {:ok, claims} =
                Bounties.claim_bounty(
@@ -517,4 +517,70 @@ defmodule Algora.BountiesTest do
       refute Enum.any?(claims, &(&1.status == :cancelled))
     end
   end
+
+  describe "generate_line_items/2" do
+    test "uses owner's fee percentage for platform fee" do
+      owner = insert!(:user, fee_pct: 5)
+      recipient = insert!(:user, provider_login: "recipient")
+      amount = Money.new(10_000, :USD)
+
+      line_items =
+        Bounties.generate_line_items(
+          %{owner: owner, amount: amount},
+          recipient: recipient
+        )
+
+      platform_fee = Enum.find(line_items, &(&1.type == :fee and String.contains?(&1.title, "platform fee")))
+      assert Money.equal?(platform_fee.amount, Money.new(500, :USD))
+      assert platform_fee.title == "Algora platform fee (5%)"
+
+      payout = Enum.find(line_items, &(&1.type == :payout))
+      assert Money.equal?(payout.amount, amount)
+      assert payout.title == "Payment to @recipient"
+    end
+
+    test "calculates line items correctly with claims" do
+      owner = insert!(:user, fee_pct: 5)
+      solver1 = insert!(:user, provider_login: "solver1")
+      solver2 = insert!(:user, provider_login: "solver2")
+      amount = Money.new(10_000, :USD)
+
+      claims = [
+        build(:claim, user: solver1, group_share: Decimal.new("0.60")),
+        build(:claim, user: solver2, group_share: Decimal.new("0.40"))
+      ]
+
+      line_items =
+        Bounties.generate_line_items(
+          %{owner: owner, amount: amount},
+          claims: claims
+        )
+
+      platform_fee = Enum.find(line_items, &(&1.type == :fee and String.contains?(&1.title, "platform fee")))
+      assert Money.equal?(platform_fee.amount, Money.new(500, :USD))
+
+      [payout1, payout2] = Enum.filter(line_items, &(&1.type == :payout))
+      assert Money.equal?(payout1.amount, Money.new(6000, :USD))
+      assert payout1.title == "Payment to @solver1"
+      assert Money.equal?(payout2.amount, Money.new(4000, :USD))
+      assert payout2.title == "Payment to @solver2"
+    end
+
+    test "includes ticket reference in description when provided" do
+      owner = insert!(:user, fee_pct: 5)
+      recipient = insert!(:user, provider_login: "recipient")
+      amount = Money.new(10_000, :USD)
+      ticket_ref = %{owner: "owner", repo: "repo", number: 123}
+
+      line_items =
+        Bounties.generate_line_items(
+          %{owner: owner, amount: amount},
+          recipient: recipient,
+          ticket_ref: ticket_ref
+        )
+
+      payout = Enum.find(line_items, &(&1.type == :payout))
+      assert payout.description == "repo#123"
+    end
+  end
 end