feat: add Github.remove_label/4

Author: zcesur

lib/algora/admin/admin.ex

@@ -41,6 +41,15 @@ defmodule Algora.Admin do
     end
   end
 
+  def remove_label(url, amount) do
+    %{owner: owner, repo: repo, number: number} = parse_ticket_url(url)
+
+    with installation_id when not is_nil(installation_id) <- Workspace.get_installation_id_by_owner(owner),
+         {:ok, token} <- Github.get_installation_token(installation_id) do
+      Workspace.remove_amount_label(token, owner, repo, number, Money.parse(amount))
+    end
+  end
+
   def add_label(url, amount) do
     %{owner: owner, repo: repo, number: number} = parse_ticket_url(url)
 
@@ -55,6 +64,7 @@ defmodule Algora.Admin do
 
     with installation_id when not is_nil(installation_id) <- Workspace.get_installation_id_by_owner(owner),
          {:ok, token} <- Github.get_installation_token(installation_id),
+         # TODO: properly parse DELETE responses in Github.Client
          {:error, %Jason.DecodeError{data: ""}} <-
            Github.Client.fetch(token, "/repos/#{owner}/#{repo}/issues/comments/#{id}", "DELETE") do
       :ok

lib/algora/integrations/github/behaviour.ex

@@ -32,4 +32,5 @@ defmodule Algora.Github.Behaviour do
   @callback add_labels(token(), String.t(), String.t(), integer(), [String.t()]) :: {:ok, [map()]} | {:error, String.t()}
   @callback create_label(token(), String.t(), String.t(), map()) :: {:ok, map()} | {:error, String.t()}
   @callback get_label(token(), String.t(), String.t(), String.t()) :: {:ok, map()} | {:error, String.t()}
+  @callback remove_label(token(), String.t(), String.t(), String.t()) :: {:ok, map()} | {:error, String.t()}
 end

lib/algora/integrations/github/client.ex

@@ -282,4 +282,9 @@ defmodule Algora.Github.Client do
   def get_label(access_token, owner, repo, label) do
     fetch(access_token, "/repos/#{owner}/#{repo}/labels/#{label}")
   end
+
+  @impl true
+  def remove_label(access_token, owner, repo, label) do
+    fetch(access_token, "/repos/#{owner}/#{repo}/labels/#{label}", "DELETE")
+  end
 end

lib/algora/integrations/github/github.ex

@@ -150,4 +150,7 @@ defmodule Algora.Github do
 
   @impl true
   def get_label(token, owner, repo, label), do: client().get_label(token, owner, repo, label)
+
+  @impl true
+  def remove_label(token, owner, repo, label), do: client().remove_label(token, owner, repo, label)
 end

lib/algora/workspace/workspace.ex

@@ -579,4 +579,19 @@ defmodule Algora.Workspace do
         :error
     end
   end
+
+  def remove_amount_label(token, owner, repo, number, amount) do
+    label = "$#{amount |> Money.to_decimal() |> Util.format_number_compact()}"
+
+    case Github.remove_label(token, owner, repo, label) do
+      # TODO: properly parse DELETE responses in Github.Client
+      {:error, %Jason.DecodeError{data: ""}} ->
+        :ok
+
+      {:error, reason} ->
+        Logger.error("Failed to remove label #{label} from #{owner}/#{repo}##{number}: #{inspect(reason)}")
+
+        :error
+    end
+  end
 end

test/support/github_mock.ex

@@ -180,4 +180,9 @@ defmodule Algora.Support.GithubMock do
   def get_label(_access_token, _owner, _repo, _label) do
     {:ok, %{"id" => random_id()}}
   end
+
+  @impl true
+  def remove_label(_access_token, _owner, _repo, _label) do
+    {:ok, %{"id" => random_id()}}
+  end
 end