Skip to content

Commit dfde57a

Browse files
committed
chore: fix audit issue
1 parent 87f9a5e commit dfde57a

File tree

4 files changed

+57
-54
lines changed

4 files changed

+57
-54
lines changed

.github/workflows/check-python.yaml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,10 @@ jobs:
2525
run: |
2626
# audit non dev dependencies, no exclusions
2727
poetry export --without=dev > requirements.txt
28-
poetry run pip-audit -r requirements.txt --ignore-vuln 'GHSA-79v4-65xg-pq4g'
28+
poetry run pip-audit -r requirements.txt
2929
# audit all dependencies, with exclusions.
3030
# If a vulnerability is found in a dev dependency without an available fix,
31-
# it can be temporarily ignored by adding --ignore-vuln e.g.
32-
# TODO: decide on `GHSA-79v4-65xg-pq4g`, see https://osv.dev/vulnerability/GHSA-79v4-65xg-pq4g
33-
# The vulnerability is not applicable to the cli case, the only abstraciton leveraged is `RSAPublicKey` in
34-
# vendored src/algokit/core/_vendor/auth0/authentication/token_verifier.py that was added to remove dependency
35-
# on auth0 package that caused many adhoc transitive dependency errors in cli. As a result, consequent cryptography
36-
# vulnerabilities need to be a) verified for applicability to cli case and ignored if not applicable or b) fixed by
37-
# updating the vendored file to use the latest version of `cryptography` that has the fix.
31+
# it can be temporarily ignored by adding --ignore-vuln e.g. poetry run pip-audit -r requirements.txt --ignore-vuln 'GHSA-79v4-65xg-pq4g'
3832
3933
- name: Check formatting with Ruff
4034
run: |

poetry.lock

Lines changed: 50 additions & 42 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ tomli = { version = "^2.0.1", python = "<3.11" }
1818
python-dotenv = "^1.0.0"
1919
mslex = "^1.1.0"
2020
keyring = "25.2.1"
21-
# pyjwt is locked to version ^2.8.0 because its explicitly
21+
# pyjwt is locked to version ^2.10.1 because its explicitly
2222
# vendored from auth0 repo, to reduce depedency on auth0 package that caused many adhoc transitive dependency errors in cli
2323
# see header in src/algokit/core/_vendor/auth0/authentication/token_verifier.py
24-
pyjwt = "^2.8.0"
25-
cryptography = "^43.0.1" # pyjwt has a weak dependency on cryptography and explicitly requires it in the vendored file, hence the lock
24+
# this version has been tested to work with the vendored file
25+
pyjwt = "^2.10.1"
26+
cryptography = "^44.0.2" # pyjwt has a weak dependency on cryptography and explicitly requires it in the vendored file, hence the lock
2627
algokit-utils = "^3.0.0"
2728
multiformats = "0.3.1"
2829
multiformats_config = "0.3.1" # pinned this to be in lockstep with multiformats

src/algokit/core/_vendor/auth0/authentication/token_verifier.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ def verify(
299299
token (str): The JWT to verify.
300300
nonce (str, optional): The nonce value sent during authentication.
301301
max_age (int, optional): The max_age value sent during authentication.
302-
organization (str, optional): The expected organization ID (org_id) or orgnization name (org_name) claim value. This should be specified
302+
organization (str, optional): The expected organization ID (org_id) or organization name (org_name) claim value. This should be specified
303303
when logging in to an organization.
304304
305305
Returns:

0 commit comments

Comments
 (0)