chore: fix more type and linting warnings

Author: daniel-makerx

.pre-commit-config.yaml

@@ -19,7 +19,6 @@ repos:
         require_serial: false
         additional_dependencies: []
         minimum_pre_commit_version: '0'
-        files: '^(src|tests)/'
       - id: mypy
         name: mypy
         description: '`mypy` will check Python types for correctness'
@@ -29,4 +28,3 @@ repos:
         require_serial: true
         additional_dependencies: [ ]
         minimum_pre_commit_version: '2.9.2'
-        files: '^(src|tests)/'

examples/helloworld/client.py

@@ -1,5 +1,6 @@
 # flake8: noqa
 # fmt: off
+# mypy: disable-error-code="no-any-return, no-untyped-call"
 # This file was automatically generated by algokit-client-generator.
 # DO NOT MODIFY IT BY HAND.
 import base64

examples/lifecycle/client.py

@@ -1,5 +1,6 @@
 # flake8: noqa
 # fmt: off
+# mypy: disable-error-code="no-any-return, no-untyped-call"
 # This file was automatically generated by algokit-client-generator.
 # DO NOT MODIFY IT BY HAND.
 import base64

examples/lifecycle/test_client.py

@@ -17,7 +17,7 @@
 
 
 @pytest.fixture(scope="session")
-def lifecycle_client(algod_client: AlgodClient, indexer_client: IndexerClient) -> LifeCycleAppClient:
+def lifecycle_client(algod_client: AlgodClient) -> LifeCycleAppClient:
     account = get_localnet_default_account(algod_client)
     signer = AccountTransactionSigner(account.private_key)
 

examples/state/client.py

@@ -1,5 +1,6 @@
 # flake8: noqa
 # fmt: off
+# mypy: disable-error-code="no-any-return, no-untyped-call"
 # This file was automatically generated by algokit-client-generator.
 # DO NOT MODIFY IT BY HAND.
 import base64

examples/state/test_client.py

@@ -1,3 +1,4 @@
+# mypy: disable-error-code="no-untyped-call"
 import algokit_utils
 import algosdk
 import pytest
@@ -146,28 +147,32 @@ def test_get_global_state(state_app_client: StateAppClient) -> None:
     state_app_client.deploy(
         template_values={"VALUE": 1}, allow_delete=True, allow_update=True, on_update=OnUpdate.UpdateApp
     )
-    state_app_client.set_global(int1=1, int2=2, bytes1="test", bytes2=b"test")
+    int1_expected = 1
+    int2_expected = 2
+    state_app_client.set_global(int1=int1_expected, int2=int2_expected, bytes1="test", bytes2=b"test")
     response = state_app_client.get_global_state()
 
     assert response.bytes1.as_bytes == b"test"
     assert response.bytes2.as_str == "test"
-    assert response.int1 == 1
-    assert response.int2 == 2
+    assert response.int1 == int1_expected
+    assert response.int2 == int2_expected
     assert response.value == 1
 
 
 def test_get_local_state(state_app_client: StateAppClient) -> None:
     state_app_client.deploy(
         template_values={"VALUE": 1}, allow_delete=True, allow_update=True, on_update=OnUpdate.UpdateApp
     )
+    int1_expected = 1
+    int2_expected = 2
     state_app_client.opt_in(args=OptInArgs())
-    state_app_client.set_local(int1=1, int2=2, bytes1="test", bytes2=b"test")
+    state_app_client.set_local(int1=int1_expected, int2=int2_expected, bytes1="test", bytes2=b"test")
     response = state_app_client.get_local_state(account=None)
 
     assert response.local_bytes1.as_str == "test"
     assert response.local_bytes2.as_str == "test"
-    assert response.local_int1 == 1
-    assert response.local_int2 == 2
+    assert response.local_int1 == int1_expected
+    assert response.local_int2 == int2_expected
 
 
 def test_deploy_create_1arg(state_app_client: StateAppClient) -> None:

examples/voting/client.py

@@ -1,5 +1,6 @@
 # flake8: noqa
 # fmt: off
+# mypy: disable-error-code="no-any-return, no-untyped-call"
 # This file was automatically generated by algokit-client-generator.
 # DO NOT MODIFY IT BY HAND.
 import base64

examples/voting/test_client.py

@@ -1,3 +1,4 @@
+# mypy: disable-error-code="no-untyped-call"
 import base64
 import math
 import random
@@ -106,7 +107,8 @@ def test_get_preconditions(
             signer=AccountTransactionSigner(voter[0].private_key),
         ),
     )
-    assert len(response.return_value) == 4
+    expected_length = 4
+    assert len(response.return_value) == expected_length
 
 
 @pytest.fixture()

examples/voting/voting.py

@@ -210,7 +210,7 @@ def calculate_total_options_count(self) -> pt.Expr:
 
 
 @app.create()
-def create(
+def create(  # noqa: PLR0913
     vote_id: pt.abi.String,
     snapshot_public_key: pt.abi.DynamicBytes,
     metadata_ipfs_cid: pt.abi.String,
@@ -297,7 +297,7 @@ def close() -> pt.Expr:
         app.state.close_time.set(pt.Global.latest_timestamp()),
         (note := StringScratchVar()).store(
             pt.Concat(
-                pt.Bytes('{"standard":"arc69","description":"This is a voting result NFT' " for voting round with ID "),
+                pt.Bytes('{"standard":"arc69","description":"This is a voting result NFT for voting round with ID '),
                 app.state.vote_id.get(),
                 pt.Bytes('.","properties":{"metadata":"ipfs://'),
                 app.state.metadata_ipfs_cid.get(),

src/algokit_client_generator/generator.py

@@ -71,6 +71,7 @@ def generated_comment(context: GenerateContext) -> DocumentParts:
 def disable_linting(context: GenerateContext) -> DocumentParts:
     yield "# flake8: noqa"  # this works for flake8 and ruff
     yield "# fmt: off"  # disable formatting
+    yield '# mypy: disable-error-code="no-any-return, no-untyped-call"'  # disable common type warnings
 
 
 def imports(context: GenerateContext) -> DocumentParts: