chore: pr feedback

- throw error when can't resolve sender
- clean up the tests

Author: PatrickDinh

src/features/transaction-wizard/utils/resolve-sender-address.ts

@@ -11,10 +11,11 @@ import { betanetId, mainnetId, testnetId, fnetId, localnetId } from '@/features/
 import { algorandClient } from '@/features/common/data/algo-client'
 
 export async function resolveTransactionSender(data: { value?: string; resolvedAddress?: string }): Promise<TransactionSender> {
-  const val = data.value ?? ''
-
-  if (val) {
-    return data as TransactionSender
+  if (data.value && data.resolvedAddress) {
+    return {
+      value: data.value,
+      resolvedAddress: data.resolvedAddress,
+    }
   }
 
   const { id: networkId } = settingsStore.get(networkConfigAtom)
@@ -36,5 +37,5 @@ export async function resolveTransactionSender(data: { value?: string; resolvedA
     return { value: TESTNET_FEE_SINK_ADDRESS, resolvedAddress: TESTNET_FEE_SINK_ADDRESS, autoPopulated: true }
   }
 
-  return data as TransactionSender
+  throw new Error(`Cannot resolve a default sender address for network "${networkId}"`)
 }

src/features/transaction-wizard/utils/transactions-url-search-params.test.tsx

@@ -1,7 +1,7 @@
 import { createMemoryRouter, RouterProvider } from 'react-router-dom'
 import { afterEach, beforeEach, describe, expect, it, vitest } from 'vitest'
 import { TransactionWizardPage } from '../transaction-wizard-page'
-import { render, screen, cleanup, waitFor } from '@testing-library/react'
+import { render, screen, cleanup } from '@testing-library/react'
 import { algorandFixture } from '@algorandfoundation/algokit-utils/testing'
 import { TooltipProvider } from '@/features/common/components/tooltip'
 import { ToastContainer } from 'react-toastify'
@@ -133,9 +133,7 @@ describe('Render transactions page with search params', () => {
         }),
       })
 
-      const senderElements = await screen.findAllByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })
-
-      expect(senderElements.length).toBeGreaterThanOrEqual(1)
+      expect(await screen.findByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })).toBeInTheDocument()
     })
   })
 
@@ -224,9 +222,7 @@ describe('Render transactions page with search params', () => {
         }),
       })
 
-      const senderElements = await screen.findAllByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })
-
-      expect(senderElements.length).toBeGreaterThanOrEqual(1)
+      expect(await screen.findByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })).toBeInTheDocument()
     })
 
     it.each([
@@ -402,9 +398,7 @@ describe('Render transactions page with search params', () => {
         }),
       })
 
-      const senderElements = await screen.findAllByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })
-
-      expect(senderElements.length).toBeGreaterThanOrEqual(1)
+      expect(await screen.findByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })).toBeInTheDocument()
     })
 
     it.each([
@@ -1026,9 +1020,7 @@ describe('Render transactions page with search params', () => {
         }),
       })
 
-      const senderElements = await screen.findAllByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })
-
-      expect(senderElements.length).toBeGreaterThanOrEqual(1)
+      expect(await screen.findByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })).toBeInTheDocument()
     })
 
     it.each([
@@ -1467,13 +1459,8 @@ describe('Render transactions page with search params', () => {
         }),
       })
 
-      await waitFor(
-        () => {
-          expect(screen.getByText(assetId)).toBeInTheDocument()
-          expect(screen.getByText(localnetDispenserAccount.addr.toString())).toBeInTheDocument()
-        },
-        { timeout: 10_000 }
-      )
+      expect(await screen.findByText(assetId)).toBeInTheDocument()
+      expect(await screen.findByText(localnetDispenserAccount.addr.toString(), {}, { timeout: 10_000 })).toBeInTheDocument()
     })
 
     it.each([