test(optional_sender): updated tests to use kmd instead of assuming testWallet + address PR comments

Author: p2arthur

package-lock.json

@@ -1,19 +1,9 @@
-import { Nfd } from '@/features/nfd/data/types'
-
-import { PropsWithChildren } from 'react'
-import { AddressOrNfdLink } from './address-or-nfd-link'
-import { Address } from 'algosdk'
+import { AddressOrNfdLink, AddressOrNfdLinkProps } from './address-or-nfd-link'
 import { cn } from '@/features/common/utils'
 
-export type Props = PropsWithChildren<{
-  address: string | Address
-  short?: boolean
-  className?: string
-  showCopyButton?: boolean
-  showQRButton?: boolean
-  nfd?: Nfd
+export type Props = AddressOrNfdLinkProps & {
   autoPopulated?: boolean
-}>
+}
 
 export default function TransactionSenderLink(props: Props) {
   const { autoPopulated, className, ...rest } = props

src/features/accounts/components/transaction-sender-link.tsx

@@ -15,7 +15,7 @@ import { FormFieldHelper } from '@/features/forms/components/form-field-helper'
 import { ZERO_ADDRESS } from '@/features/common/constants'
 import { TransactionBuilderMode } from '../data'
 import { TransactionBuilderNoteField } from './transaction-builder-note-field'
-import { asAddressOrNfd } from '../mappers/as-address-or-nfd'
+import { asAddressOrNfd, asOptionalAddressOrNfd } from '../mappers/as-address-or-nfd'
 import { ActiveWalletAccount } from '@/features/wallet/types/active-wallet'
 import resolveSenderAddress from '../utils/resolve-sender-address'
 
@@ -135,10 +135,10 @@ export function AssetCreateTransactionBuilder({ mode, transaction, activeAccount
         total: data.total,
         decimals: data.decimals,
         sender: await resolveSenderAddress(data.sender),
-        manager: asAddressOrNfd(data.manager.value!),
-        reserve: asAddressOrNfd(data.reserve.value!),
-        freeze: asAddressOrNfd(data.freeze.value!),
-        clawback: asAddressOrNfd(data.clawback.value!),
+        manager: asOptionalAddressOrNfd(data.manager),
+        reserve: asOptionalAddressOrNfd(data.reserve),
+        freeze: asOptionalAddressOrNfd(data.freeze),
+        clawback: asOptionalAddressOrNfd(data.clawback),
         defaultFrozen: data.defaultFrozen ?? false,
         url: data.url,
         metadataHash: data.metadataHash,

src/features/transaction-wizard/components/asset-create-transaction-builder.tsx

@@ -21,7 +21,7 @@ import { ZERO_ADDRESS } from '@/features/common/constants'
 import { useDebounce } from 'use-debounce'
 import { TransactionBuilderMode } from '../data'
 import { TransactionBuilderNoteField } from './transaction-builder-note-field'
-import { asAddressOrNfd, asOptionalAddressOrNfdSchema } from '../mappers/as-address-or-nfd'
+import { asAddressOrNfd, asOptionalAddressOrNfd, asOptionalAddressOrNfdSchema } from '../mappers/as-address-or-nfd'
 import resolveSenderAddress from '../utils/resolve-sender-address'
 
 export const assetReconfigureFormSchema = z
@@ -218,10 +218,10 @@ export function AssetReconfigureTransactionBuilder({ mode, transaction, onSubmit
         asset: data.asset,
 
         sender: await resolveSenderAddress(data.sender),
-        manager: asAddressOrNfd(data.manager.value!),
-        reserve: asAddressOrNfd(data.reserve.value!),
-        freeze: asAddressOrNfd(data.freeze.value!),
-        clawback: asAddressOrNfd(data.clawback.value!),
+        manager: asOptionalAddressOrNfd(data.manager),
+        reserve: asOptionalAddressOrNfd(data.reserve),
+        freeze: asOptionalAddressOrNfd(data.freeze),
+        clawback: asOptionalAddressOrNfd(data.clawback),
         fee: data.fee,
         validRounds: data.validRounds,
         note: data.note,

src/features/transaction-wizard/components/asset-reconfigure-transaction-builder.tsx

@@ -1,5 +1,5 @@
 import algosdk from 'algosdk'
-import { useCallback, useMemo, useState } from 'react'
+import { useCallback, useEffect, useMemo, useState } from 'react'
 import { DialogBodyProps, useDialogForm } from '@/features/common/hooks/use-dialog-form'
 import { AsyncActionButton, Button } from '@/features/common/components/button'
 import { TransactionBuilder } from './transaction-builder'
@@ -348,6 +348,10 @@ export function TransactionsBuilder({
     return commonButtonDisableProps
   }, [transactions, activeAddress, commonButtonDisableProps])
 
+  useEffect(() => {
+    setTransactions(defaultTransactions ?? [])
+  }, [defaultTransactions])
+
   return (
     <div>
       <div className="space-y-4">