refactor: change arc56 method to abi method

Renames `get_arc56_method` to `get_abi_method` for clarity and consistency across the codebase, reflecting the shift towards using ABI method specifications.

Also, replace calls to transaction.tx_id with transaction.tx_id() to align with ts

Author: aorumbayev

src/algokit_abi/arc56.py

@@ -737,7 +737,7 @@ def to_json(self, indent: int | None = None) -> str:
     def dictify(self) -> dict:
         return to_wire(self)
 
-    def get_arc56_method(self, method_name_or_signature: str) -> Method:
+    def get_abi_method(self, method_name_or_signature: str) -> Method:
         if "(" in method_name_or_signature:
             methods = [m for m in self.methods if m.signature == method_name_or_signature]
         else:

src/algokit_transact/models/transaction.py

@@ -81,7 +81,6 @@ class Transaction:
         default=None, metadata=flatten(StateProofTransactionFields, present_if=lambda p: _get_tx_type(p) == "stpf")
     )
 
-    @property
     def tx_id(self) -> str:
         """Return the transaction ID."""
         from algokit_transact.ops.ids import get_transaction_id

src/algokit_utils/applications/app_client.py

@@ -753,7 +753,7 @@ def _get_abi_params(self, params: dict[str, Any], on_complete: OnApplicationComp
         input_params["signer"] = self._client._get_signer(params["sender"], params["signer"])
 
         if params.get("method"):
-            input_params["method"] = self._app_spec.get_arc56_method(params["method"])
+            input_params["method"] = self._app_spec.get_abi_method(params["method"])
             input_params["args"] = self._client._get_abi_args_with_default_values(
                 method_name_or_signature=params["method"],
                 args=params.get("args"),
@@ -1098,7 +1098,7 @@ def opt_in(
         return self._client._handle_call_errors(
             lambda: self._client._process_method_call_return(
                 lambda: self._algorand.send.app_call_method_call(self._client.params.opt_in(params), send_params),
-                self._app_spec.get_arc56_method(params.method),
+                self._app_spec.get_abi_method(params.method),
             )
         )
 
@@ -1116,7 +1116,7 @@ def delete(
         return self._client._handle_call_errors(
             lambda: self._client._process_method_call_return(
                 lambda: self._algorand.send.app_delete_method_call(self._client.params.delete(params), send_params),
-                self._app_spec.get_arc56_method(params.method),
+                self._app_spec.get_abi_method(params.method),
             )
         )
 
@@ -1140,7 +1140,7 @@ def update(
                 lambda: self._algorand.send.app_update_method_call(
                     self._client.params.update(params, compilation_params), send_params
                 ),
-                self._app_spec.get_arc56_method(params.method),
+                self._app_spec.get_abi_method(params.method),
             )
         )
         assert isinstance(result, SendAppUpdateTransactionResult)
@@ -1160,7 +1160,7 @@ def close_out(
         return self._client._handle_call_errors(
             lambda: self._client._process_method_call_return(
                 lambda: self._algorand.send.app_call_method_call(self._client.params.close_out(params), send_params),
-                self._app_spec.get_arc56_method(params.method),
+                self._app_spec.get_abi_method(params.method),
             )
         )
 
@@ -1178,7 +1178,7 @@ def call(
         """
         is_read_only_call = (
             params.on_complete == OnApplicationComplete.NoOp or params.on_complete is None
-        ) and self._app_spec.get_arc56_method(params.method).readonly
+        ) and self._app_spec.get_abi_method(params.method).readonly
 
         if is_read_only_call:
             readonly_params = params
@@ -1242,7 +1242,7 @@ def run_simulate() -> SendTransactionComposerResults:
         return self._client._handle_call_errors(
             lambda: self._client._process_method_call_return(
                 lambda: self._algorand.send.app_call_method_call(self._client.params.call(params), send_params),
-                self._app_spec.get_arc56_method(params.method),
+                self._app_spec.get_abi_method(params.method),
             )
         )
 
@@ -2053,7 +2053,7 @@ def _get_abi_args_with_default_values(
         args: Sequence[ABIValue | ABIStruct | AppMethodCallTransactionArgument | None] | None,
         sender: str,
     ) -> list[Any]:
-        method = self._app_spec.get_arc56_method(method_name_or_signature)
+        method = self._app_spec.get_abi_method(method_name_or_signature)
         result = list[ABIValue | ABIStruct | AppMethodCallTransactionArgument | None]()
 
         if args and len(method.args) < len(args):
@@ -2095,7 +2095,7 @@ def _get_abi_arg_default_value(
                 return get_abi_decoded_value(value_raw, value_type)
 
             case "method":
-                default_method = self._app_spec.get_arc56_method(default_value.data)
+                default_method = self._app_spec.get_abi_method(default_value.data)
                 empty_args = [None] * len(default_method.args)
                 call_result = self.send.call(
                     AppClientMethodCallParams(
@@ -2157,7 +2157,7 @@ def _get_storage_value(
 
     def _get_abi_params(self, params: dict[str, Any], on_complete: OnApplicationComplete) -> dict[str, Any]:
         sender = self._get_sender(params.get("sender"))
-        method = self._app_spec.get_arc56_method(params["method"])
+        method = self._app_spec.get_abi_method(params["method"])
         args = self._get_abi_args_with_default_values(
             method_name_or_signature=params["method"], args=params.get("args"), sender=sender
         )

src/algokit_utils/applications/app_factory.py

@@ -354,7 +354,7 @@ def create(
                 "signer": self._factory._get_signer(
                     params.sender if params else None, params.signer if params else None
                 ),
-                "method": self._factory._app_spec.get_arc56_method(params.method),
+                "method": self._factory._app_spec.get_abi_method(params.method),
                 "args": self._factory._get_create_abi_args_with_default_values(params.method, params.args),
                 "on_complete": params.on_complete or OnApplicationComplete.NoOp,
             }
@@ -381,7 +381,7 @@ def deploy_update(self, params: AppClientMethodCallParams) -> AppUpdateMethodCal
                 "signer": self._factory._get_signer(
                     params.sender if params else None, params.signer if params else None
                 ),
-                "method": self._factory._app_spec.get_arc56_method(params.method),
+                "method": self._factory._app_spec.get_abi_method(params.method),
                 "args": self._factory._get_create_abi_args_with_default_values(params.method, params.args),
                 "on_complete": OnApplicationComplete.UpdateApplication,
             }
@@ -406,7 +406,7 @@ def deploy_delete(self, params: AppClientMethodCallParams) -> AppDeleteMethodCal
                 "signer": self._factory._get_signer(
                     params.sender if params else None, params.signer if params else None
                 ),
-                "method": self._factory.app_spec.get_arc56_method(params.method),
+                "method": self._factory.app_spec.get_abi_method(params.method),
                 "args": self._factory._get_create_abi_args_with_default_values(params.method, params.args),
                 "on_complete": OnApplicationComplete.DeleteApplication,
             }
@@ -589,7 +589,7 @@ def create(
                 lambda: self._algorand.send.app_create_method_call(
                     self._factory.params.create(params, compilation_params), send_params
                 ),
-                self._factory._app_spec.get_arc56_method(params.method),
+                self._factory._app_spec.get_abi_method(params.method),
             )
         )
 
@@ -1106,7 +1106,7 @@ def _get_create_abi_args_with_default_values(
         Builds a list of ABI argument values for creation calls, applying default
         argument values when not provided.
         """
-        method = self._app_spec.get_arc56_method(method_name_or_signature)
+        method = self._app_spec.get_abi_method(method_name_or_signature)
 
         results: list[Any] = []
 

src/algokit_utils/transactions/transaction_sender.py

@@ -368,7 +368,8 @@ def payment(self, params: PaymentParams, send_params: SendParams | None = None)
         return self._send(
             lambda c: c.add_payment,
             pre_log=lambda params, transaction: (
-                f"Sending {params.amount} from {params.sender} to {params.receiver} via transaction {transaction.tx_id}"
+                f"Sending {params.amount} from {params.sender} to {params.receiver} "
+                f"via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -481,7 +482,7 @@ def asset_config(
         return self._send(
             lambda c: c.add_asset_config,
             pre_log=lambda params, transaction: (
-                f"Configuring asset with ID {params.asset_id} via transaction {transaction.tx_id}"
+                f"Configuring asset with ID {params.asset_id} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -530,7 +531,7 @@ def asset_freeze(
         return self._send(
             lambda c: c.add_asset_freeze,
             pre_log=lambda params, transaction: (
-                f"Freezing asset with ID {params.asset_id} via transaction {transaction.tx_id}"
+                f"Freezing asset with ID {params.asset_id} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -575,7 +576,7 @@ def asset_destroy(
         return self._send(
             lambda c: c.add_asset_destroy,
             pre_log=lambda params, transaction: (
-                f"Destroying asset with ID {params.asset_id} via transaction {transaction.tx_id}"
+                f"Destroying asset with ID {params.asset_id} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -628,7 +629,7 @@ def asset_transfer(
             lambda c: c.add_asset_transfer,
             pre_log=lambda params, transaction: (
                 f"Transferring {params.amount} units of asset with ID {params.asset_id} from "
-                f"{params.sender} to {params.receiver} via transaction {transaction.tx_id}"
+                f"{params.sender} to {params.receiver} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -673,7 +674,7 @@ def asset_opt_in(
         return self._send(
             lambda c: c.add_asset_opt_in,
             pre_log=lambda params, transaction: (
-                f"Opting in {params.sender} to asset with ID {params.asset_id} via transaction {transaction.tx_id}"
+                f"Opting in {params.sender} to asset with ID {params.asset_id} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -751,7 +752,7 @@ def asset_opt_out(
             lambda c: c.add_asset_opt_out,
             pre_log=lambda params, transaction: (
                 f"Opting {params.sender} out of asset with ID {params.asset_id} to creator "
-                f"{creator} via transaction {transaction.tx_id}"
+                f"{creator} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -1200,7 +1201,7 @@ def online_key_registration(
         return self._send(
             lambda c: c.add_online_key_registration,
             pre_log=lambda params, transaction: (
-                f"Registering online key for {params.sender} via transaction {transaction.tx_id}"
+                f"Registering online key for {params.sender} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)
 
@@ -1234,6 +1235,6 @@ def offline_key_registration(
         return self._send(
             lambda c: c.add_offline_key_registration,
             pre_log=lambda params, transaction: (
-                f"Registering offline key for {params.sender} via transaction {transaction.tx_id}"
+                f"Registering offline key for {params.sender} via transaction {transaction.tx_id()}"
             ),
         )(params, send_params)

tests/applications/test_app_client.py

@@ -408,7 +408,7 @@ def test_construct_transaction_with_abi_encoding_including_transaction(
 
     assert result.confirmation
     assert len(result.transactions) == 2
-    response = AppManager.get_abi_return(result.confirmation, test_app_client.app_spec.get_arc56_method("call_abi_txn"))
+    response = AppManager.get_abi_return(result.confirmation, test_app_client.app_spec.get_abi_method("call_abi_txn"))
     expected_return = f"Sent {amount.micro_algo}. test"
     assert result.abi_return == expected_return
     assert response
@@ -500,7 +500,7 @@ def test_construct_transaction_with_abi_encoding_including_foreign_references_no
 
     # Assuming the method returns a string matching the format below
     expected_return = AppManager.get_abi_return(
-        result.confirmations[0], test_app_client.app_spec.get_arc56_method("call_abi_foreign_refs")
+        result.confirmations[0], test_app_client.app_spec.get_abi_method("call_abi_foreign_refs")
     )
     assert result.abi_return
     assert str(result.abi_return).startswith("App: 345, Asset: 567, Account: ")