Skip to content

Commit a243e16

Browse files
committed
chore: address PR feedback
1 parent 129f6bc commit a243e16

File tree

6 files changed

+17
-21
lines changed

6 files changed

+17
-21
lines changed

.github/workflows/pr.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,18 @@ jobs:
3636
with:
3737
node-version: 20.x
3838

39-
- uses: pnpm/action-setup@v4 # remove version when root migrates to pnpm
39+
- uses: pnpm/action-setup@v4
4040
with:
41-
version: 10
41+
package_json_file: docs/package.json
4242

4343
- name: Install dependencies
4444
run: npm ci
4545

4646
- name: Install docs dependencies
47-
run: cd docs && pnpm install --frozen-lockfile
47+
run: pnpm install --frozen-lockfile --dir docs
4848

4949
- name: Verify documentation builds
50-
run: npm run docs:build
50+
run: pnpm --dir docs build
5151

5252
verify-examples:
5353
runs-on: ubuntu-latest

.github/workflows/release.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,18 @@ jobs:
4545
with:
4646
node-version: 22.x
4747

48-
- uses: pnpm/action-setup@v4 # remove version when root migrates to pnpm
48+
- uses: pnpm/action-setup@v4
4949
with:
50-
version: 10
50+
package_json_file: docs/package.json
5151

5252
- name: Install dependencies
5353
run: npm ci
5454

5555
- name: Install docs dependencies
56-
run: cd docs && pnpm install --frozen-lockfile
56+
run: pnpm install --frozen-lockfile --dir docs
5757

5858
- name: Verify documentation builds
59-
run: npm run docs:build
59+
run: pnpm --dir docs build
6060

6161
build:
6262
name: Build
@@ -142,18 +142,18 @@ jobs:
142142
node-version: 22.x
143143
cache: 'npm'
144144

145-
- uses: pnpm/action-setup@v4 # remove version when root migrates to pnpm
145+
- uses: pnpm/action-setup@v4
146146
with:
147-
version: 10
147+
package_json_file: docs/package.json
148148

149149
- name: Install dependencies
150150
run: npm ci
151151

152152
- name: Install docs dependencies
153-
run: cd docs && pnpm install --frozen-lockfile
153+
run: pnpm install --frozen-lockfile --dir docs
154154

155155
- name: Build documentation
156-
run: npm run docs:build
156+
run: pnpm --dir docs build
157157

158158
- name: Publish docs to GitHub Pages
159159
id: deployment

docs/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"typedoc-plugin-markdown": "^4.9.0"
2323
},
2424
"devDependencies": {
25-
"@types/node": "^22",
2625
"tsx": "^4.21.0"
2726
}
2827
}

docs/scripts/generate-examples-mdx.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ for (const [categorySlug, examples] of Object.entries(allExamplesByCategory)) {
134134
let bulletBuffer: string[] = []
135135
const flushBullets = () => {
136136
if (bulletBuffer.length > 0) {
137-
descHtml += '<ul>' + bulletBuffer.map((b) => `<li>${escapeForMdx(b)}</li>`).join('') + '</ul>'
137+
descHtml += `<ul>${bulletBuffer.map((b) => `<li>${escapeForMdx(b)}</li>`).join('')}</ul>`
138138
bulletBuffer = []
139139
}
140140
}
@@ -191,7 +191,7 @@ npm run example ${examples[0].categoryDir}/01-*.ts
191191

192192
// Top-level examples index — custom card grid matching original index.astro
193193
const categoryCards = Object.entries(CATEGORIES)
194-
.map(([dirName, meta]) => {
194+
.map(([_dirName, meta]) => {
195195
const count = allExamplesByCategory[meta.slug]?.length ?? 0
196196
return `<a href="${meta.slug}/" class="card">
197197
<h3>${meta.label}</h3>

docs/tsconfig.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"extends": "astro/tsconfigs/strict",
3-
"compilerOptions": {
4-
"types": ["node"]
5-
},
63
"include": [".astro/types.d.ts", "**/*"],
74
"exclude": ["dist"]
85
}

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@
107107
"format": "prettier --write . && npm run format --workspaces --if-present",
108108
"commit-lint": "commitlint --edit -o",
109109
"semantic-release": "semantic-release",
110-
"docs:dev": "cd docs && pnpm run dev",
111-
"docs:build": "cd docs && pnpm run build",
112-
"docs:preview": "cd docs && pnpm run preview",
110+
"docs:dev": "pnpm --dir docs run dev",
111+
"docs:build": "pnpm --dir docs run build",
112+
"docs:preview": "pnpm --dir docs run preview",
113113
"generate:code-docs": "npm run docs:build",
114114
"pre-commit": "run-s check-types lint:fix audit format test && npm run pre-commit --workspaces --if-present",
115115
"generate:clients": "run-p generate:client-*",

0 commit comments

Comments
 (0)