fix tests

Author: codelion

tests/test_island_isolation.py

@@ -99,14 +99,14 @@ def test_island_isolation_during_evolution(self):
         # Track which islands were sampled
         sampled_islands = []
 
-        def mock_sample(num_inspirations=None):
-            # Record which island was sampled
-            sampled_islands.append(self.database.current_island)
+        def mock_sample_from_island(island_id, num_inspirations=None):
+            # Record which island was sampled (using the island_id parameter)
+            sampled_islands.append(island_id)
             # Return mock parent and inspirations
             mock_program = Program(id="mock", code="", metrics={})
             return mock_program, []
 
-        with patch.object(self.database, "sample", side_effect=mock_sample):
+        with patch.object(self.database, "sample_from_island", side_effect=mock_sample_from_island):
             with patch.object(controller, "executor"):
                 # Submit iterations for different islands
                 controller._submit_iteration(1, island_id=0)

tests/test_utils.py

@@ -55,12 +55,12 @@ def start_test_server(model: str = TEST_MODEL, port: Optional[int] = None) -> Tu
 
     print(f"Starting optillm server on port {port}...")
 
-    # Start server
+    # Start server (don't capture output to avoid pipe buffer deadlock)
     proc = subprocess.Popen([
         "optillm",
         "--model", model,
         "--port", str(port)
-    ], env=env, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
+    ], env=env)
 
     # Wait for server to start
     for i in range(30):
@@ -75,18 +75,9 @@ def start_test_server(model: str = TEST_MODEL, port: Optional[int] = None) -> Tu
             pass
         time.sleep(1)
 
-    # Server didn't start in time - collect error info
-    try:
-        stdout, stderr = proc.communicate(timeout=2)
-        error_msg = f"optillm server failed to start on port {port}"
-        if stdout:
-            error_msg += f"\nSTDOUT: {stdout[:500]}"
-        if stderr:
-            error_msg += f"\nSTDERR: {stderr[:500]}"
-    except subprocess.TimeoutExpired:
-        proc.kill()
-        stdout, stderr = proc.communicate()
-        error_msg = f"optillm server failed to start on port {port} (timeout)"
+    # Server didn't start in time - clean up
+    error_msg = f"optillm server failed to start on port {port}"
+    print(f"❌ {error_msg} - check that optillm is installed and model is available")
 
     # Clean up
     try: