From 31186f655e796d8af33ca47cbaf2ddf8fe79277d Mon Sep 17 00:00:00 2001 From: zzunho9 Date: Sun, 10 Dec 2023 15:52:54 +0900 Subject: [PATCH] Refactor: Replace some variables with constants --- .../security/config/JwtAuthenticationFilter.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/alibou/security/config/JwtAuthenticationFilter.java b/src/main/java/com/alibou/security/config/JwtAuthenticationFilter.java index d6e55d1..beb0792 100644 --- a/src/main/java/com/alibou/security/config/JwtAuthenticationFilter.java +++ b/src/main/java/com/alibou/security/config/JwtAuthenticationFilter.java @@ -26,6 +26,10 @@ @RequiredArgsConstructor public class JwtAuthenticationFilter extends OncePerRequestFilter { + private static final String SIGN_IN_URL = "/api/v1/auth"; + private static final String AUTH_HEADER_NAME = "Authorization"; + private static final String AUTH_HEADER_PREFIX = "Bearer "; + private final JwtService jwtService; private final UserDetailsService userDetailsService; private final TokenRepository tokenRepository; @@ -36,18 +40,18 @@ protected void doFilterInternal( @NonNull HttpServletResponse response, @NonNull FilterChain filterChain ) throws ServletException, IOException { - if (request.getServletPath().contains("/api/v1/auth")) { + if (request.getServletPath().contains(SIGN_IN_URL)) { filterChain.doFilter(request, response); return; } - final String authHeader = request.getHeader("Authorization"); + final String authHeader = request.getHeader(AUTH_HEADER_NAME); final String jwt; final String userEmail; - if (authHeader == null ||!authHeader.startsWith("Bearer ")) { + if (authHeader == null ||!authHeader.startsWith(AUTH_HEADER_PREFIX)) { filterChain.doFilter(request, response); return; } - jwt = authHeader.substring(7); + jwt = authHeader.substring(AUTH_HEADER_PREFIX.length()); userEmail = jwtService.extractUsername(jwt); if (userEmail != null && SecurityContextHolder.getContext().getAuthentication() == null) { UserDetails userDetails = this.userDetailsService.loadUserByUsername(userEmail);