Skip to content

Commit 1fc617f

Browse files
authored
fix(interactive): Support more types in Insight Runtime (#4512)
Committed-by: bingqing.lbq from Dev container <!-- Thanks for your contribution! please review https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before opening an issue. --> ## What do these changes do? <!-- Please give a short brief about these changes. --> Support u32, u64, f32 in `Primitives` in Runtime. Also have implemented arith & cmp related operations for `Primitives`. ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> #4494
1 parent 9393d08 commit 1fc617f

File tree

19 files changed

+1186
-201
lines changed

19 files changed

+1186
-201
lines changed

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/cypher/result/CypherRecordParser.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,14 @@ protected AnyValue parseValue(Common.Value value, @Nullable RelDataType dataType
311311
return value.getBoolean() ? BooleanValue.TRUE : BooleanValue.FALSE;
312312
case I32:
313313
return Values.intValue(value.getI32());
314+
case U32:
315+
return Values.intValue(value.getU32());
314316
case I64:
315317
return Values.longValue(value.getI64());
318+
case U64:
319+
return Values.longValue(value.getU64());
320+
case F32:
321+
return Values.floatValue(value.getF32());
316322
case F64:
317323
return Values.doubleValue(value.getF64());
318324
case STR:

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/gremlin/result/ParserUtils.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,14 @@ private static Object parseCommonValue(Common.Value value) {
8484
return value.getBoolean();
8585
case I32:
8686
return value.getI32();
87+
case U32:
88+
return value.getU32();
8789
case I64:
8890
return value.getI64();
91+
case U64:
92+
return value.getU64();
93+
case F32:
94+
return value.getF32();
8995
case F64:
9096
return value.getF64();
9197
case STR:

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/gremlin/resultx/GremlinRecordParser.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,14 @@ private List<Element> parseGraphPath(IrResult.GraphPath path, @Nullable RelDataT
271271
return value.getBoolean();
272272
case I32:
273273
return value.getI32();
274+
case U32:
275+
return value.getU32();
274276
case I64:
275277
return value.getI64();
278+
case U64:
279+
return value.getU64();
280+
case F32:
281+
return value.getF32();
276282
case F64:
277283
return value.getF64();
278284
case STR:

interactive_engine/executor/assembly/groot/Cargo.toml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ column_filter_push_down = []
3030
# TODO(siyuan): re-enable debug assertions by addressing the reports for misaligned pointer dereferences https://github.com/rust-lang/rust/pull/98112/
3131
debug-assertions = false
3232

33+
# may not be necessary for release builds. For debug builds, overflow checks are enabled by default.
34+
# [profile.release]
35+
# overflow-checks = true
36+
3337
[profile.release-with-debug-info]
3438
inherits = "release"
3539
debug = true
40+
# overflow-checks = true

interactive_engine/executor/common/dyn_type/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,6 @@ lazy_static = "1.3.0"
1010
pegasus_common = { path = "../../engine/pegasus/common" }
1111
rustversion = "1.0"
1212
chrono = "0.4"
13+
14+
# [profile.release]
15+
# overflow-checks = true

0 commit comments

Comments
 (0)