Skip to content

Commit 7ec6d6c

Browse files
chore: migrate to correct logger interface (#4605)
Resolves the annoying deprecation warnings of the `logger` library: ```python DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead ``` Signed-off-by: Emmanuel Ferdman <[email protected]>
1 parent 312a79b commit 7ec6d6c

File tree

11 files changed

+18
-18
lines changed

11 files changed

+18
-18
lines changed

coordinator/gscoordinator/flex/core/alert/alert_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@ def _try_to_recover_from_disk(self):
6262
with open(self._receiver_path, "rb") as f:
6363
self._receivers = pickle.load(f)
6464
except Exception as e:
65-
logger.warn("Failed to recover alert receiver: %s", str(e))
65+
logger.warning("Failed to recover alert receiver: %s", str(e))
6666

6767
def _pickle_receiver_impl(self):
6868
try:
6969
with open(self._receiver_path, "wb") as f:
7070
pickle.dump(self._receivers, f)
7171
except Exception as e:
72-
logger.warn("Failed to dump receiver: %s", str(e))
72+
logger.warning("Failed to dump receiver: %s", str(e))
7373

7474
def list_alert_rules(self) -> List[GetAlertRuleResponse]:
7575
rlt = []

coordinator/gscoordinator/flex/core/alert/alert_receiver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,5 @@ def send(self, message: AlertMessage):
118118
raise RuntimeError(str(rlt))
119119

120120
except Exception as e:
121-
logger.warn("Failed to send dingtalk: %s", str(e))
121+
logger.warning("Failed to send dingtalk: %s", str(e))
122122
self._error_msg = str(e)

coordinator/gscoordinator/flex/core/alert/builtin_rules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def run_alert(self):
8080
# alert
8181
self.alert(alert_message)
8282
except Exception as e:
83-
logger.warn("Failed to get disk usage: %s", str(e))
83+
logger.warning("Failed to get disk usage: %s", str(e))
8484

8585

8686
class GremlinServiceAvailableAlert(AlertRule):

coordinator/gscoordinator/flex/core/alert/message_collector.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def _pickle_messages_impl(self):
6060
try:
6161
self.dump_to_disk()
6262
except Exception as e:
63-
logger.warn(
63+
logger.warning(
6464
"Failed to dump alert message on date %s: %s",
6565
str(self._date),
6666
str(e),
@@ -74,7 +74,7 @@ def _try_to_recover_from_disk(self):
7474
with open(self._pickle_path, "rb") as f:
7575
self._messages = pickle.load(f) # noqa: B301
7676
except Exception as e:
77-
logger.warn(
77+
logger.warning(
7878
"Failed to recover alert message from path %s: %s",
7979
self._pickle_path,
8080
str(e),
@@ -151,7 +151,7 @@ def _disk_cleanup_impl(self):
151151
os.remove(file_path)
152152
logger.info("Clean alert file: %s", str(file_path))
153153
except Exception as e:
154-
logger.warn("Failed to clean the alert file: %s", str(e))
154+
logger.warning("Failed to clean the alert file: %s", str(e))
155155

156156
def is_message_belongs_to_certain_day(self, message, date):
157157
"""

coordinator/gscoordinator/flex/core/client_wrapper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def _initialize_client(self, config: Config):
7979
from gscoordinator.flex.core.insight import init_groot_client
8080
initializer = init_groot_client
8181
if initializer is None:
82-
logger.warn(f"Client initializer of {SOLUTION} not found.")
82+
logger.warning(f"Client initializer of {SOLUTION} not found.")
8383
return None
8484
return initializer(config)
8585

coordinator/gscoordinator/flex/core/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def str_to_bool(s):
107107
try:
108108
GROOT_PASSWORD = base64.b64decode(GROOT_PASSWORD).decode('utf-8')
109109
except Exception as e:
110-
logger.warn("Invalid base64-encoded string found, use original value: %s", str(e))
110+
logger.warning("Invalid base64-encoded string found, use original value: %s", str(e))
111111
GROOT_FRONTEND_POD_SUFFIX = os.environ.get("GROOT_FRONTEND_POD_SUFFIX", "graphscope-store-frontend")
112112
GROOT_STORE_POD_SUFFIX = os.environ.get("GROOT_STORE_POD_SUFFIX", "graphscope-store-store")
113113
GROOT_COORDINATOR_POD_SUFFIX = os.environ.get("GROOT_COORDINATOR_POD_SUFFIX", "graphscope-store-coordinator")

coordinator/gscoordinator/flex/core/datasource.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ def try_to_recover_from_disk(self):
4545
with open(self._pickle_path, "rb") as f:
4646
self._datasource_mapping = pickle.load(f)
4747
except Exception as e:
48-
logger.warn("Failed to recover data source mapping: %s", str(e))
48+
logger.warning("Failed to recover data source mapping: %s", str(e))
4949

5050
def dump_to_disk(self):
5151
try:
5252
with open(self._pickle_path, "wb") as f:
5353
pickle.dump(self._datasource_mapping, f)
5454
except Exception as e:
55-
logger.warn("Failed to dump data source mapping: %s", str(e))
55+
logger.warning("Failed to dump data source mapping: %s", str(e))
5656

5757
def get_edge_full_label(
5858
self,

coordinator/gscoordinator/flex/core/deployment.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ def _fetch_resource_usage_impl(self):
291291
{"host": name, "timestamp": t, "usage": round(memory)}
292292
)
293293
except Exception as e:
294-
logger.warn("Failed to fetch resource usage %s", str(e))
294+
logger.warning("Failed to fetch resource usage %s", str(e))
295295

296296
def _fetch_status_impl(self):
297297
try:
@@ -358,7 +358,7 @@ def _fetch_status_impl(self):
358358
sorted_status[key] = status[key]
359359
self._status["pods"] = sorted_status
360360
except Exception as e:
361-
logger.warn("Failed to fetch deployment status %s", str(e))
361+
logger.warning("Failed to fetch deployment status %s", str(e))
362362

363363
def initialize_resource_usage(self):
364364
try:
@@ -379,7 +379,7 @@ def initialize_resource_usage(self):
379379
"memory_usage": queue.Queue(maxsize=720 * pod_num),
380380
}
381381
except Exception as e:
382-
logger.warn("Failed to fetch resource usage %s", str(e))
382+
logger.warning("Failed to fetch resource usage %s", str(e))
383383
return {"cpu_usage": [], "memory_usage": []}
384384

385385
def get_resource_usage(self) -> dict:

coordinator/gscoordinator/flex/core/insight/graph.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def _fetch_endpoints_impl(self):
109109
cypher_endpoint = test_cypher_endpoint(pod.status.pod_ip, GROOT_CYPHER_PORT)
110110

111111
except Exception as e:
112-
logger.warn(f"Failed to fetch frontend endpoints: {str(e)}")
112+
logger.warning(f"Failed to fetch frontend endpoints: {str(e)}")
113113
else:
114114
if (
115115
gremlin_endpoint != self._endpoints["gremlin_endpoint"]

coordinator/gscoordinator/flex/core/insight/groot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def _try_to_recover_from_disk(self):
8989
self._graph, JobStatus.from_dict(status)
9090
)
9191
except Exception as e:
92-
logger.warn("Failed to recover job status: %s", str(e))
92+
logger.warning("Failed to recover job status: %s", str(e))
9393

9494
def _pickle_job_status_impl(self):
9595
try:
@@ -100,7 +100,7 @@ def _pickle_job_status_impl(self):
100100
with open(self._job_status_pickle_path, "wb") as f:
101101
pickle.dump(status, f)
102102
except Exception as e:
103-
logger.warn("Pickle job status failed: %s", str(e))
103+
logger.warning("Pickle job status failed: %s", str(e))
104104

105105
def _restart_pod(self, pod_name, pod_ip, port):
106106
logger.info(f"Restart groot store pod {pod_name}, ip {pod_ip}")

0 commit comments

Comments
 (0)