Skip to content

Commit 8235b29

Browse files
authored
ci: Fixes release failure of groot image (#3337)
- Always clean the Groot image after building - Simplify the release image manifest creation and pushing from the version ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> Fixes
1 parent aac5637 commit 8235b29

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -139,14 +139,15 @@ jobs:
139139
sudo docker rmi -f ${{ env.GSS_IMAGE }}:${tag} || true
140140
141141
- name: Clean Release Image
142-
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope' }}
142+
if: always()
143143
run: |
144144
# aarch64
145145
arch=$(uname -m)
146146
sudo docker rmi -f graphscope-store:${SHORT_SHA} || true
147147
sudo docker rmi -f ${{ env.GSS_IMAGE }}:${{ steps.tag.outputs.TAG }}-${arch} || true
148148
149149
push-gss-image-manifest:
150+
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope' }}
150151
runs-on: ubuntu-20.04
151152

152153
needs: [build-gss-image-x86-64, build-gss-image-aarch64]
@@ -163,22 +164,13 @@ jobs:
163164
run: |
164165
echo "${docker_password}" | sudo docker login --username="${docker_username}" ${{ env.DOCKER_URL }} --password-stdin
165166
166-
time=$(date "+%Y%m%d")
167-
version=$(cat ${GITHUB_WORKSPACE}/VERSION)
168167
# create
169-
170-
sudo docker manifest create \
171-
${{ env.GSS_IMAGE }}:${version}a${time} \
172-
${{ env.GSS_IMAGE }}:${version}a${time}-x86_64 \
173-
${{ env.GSS_IMAGE }}:${version}a${time}-aarch64
174-
175168
sudo docker manifest create \
176169
${{ env.GSS_IMAGE }}:${{ steps.tag.outputs.TAG }} \
177170
${{ env.GSS_IMAGE }}:${{ steps.tag.outputs.TAG }}-x86_64 \
178171
${{ env.GSS_IMAGE }}:${{ steps.tag.outputs.TAG }}-aarch64
179172
180173
# push
181-
sudo docker manifest push ${{ env.GSS_IMAGE }}:${version}a${time}
182174
sudo docker manifest push ${{ env.GSS_IMAGE }}:${{ steps.tag.outputs.TAG }}
183175
184176
release-helm-charts:

0 commit comments

Comments
 (0)