Skip to content

Commit ad1174f

Browse files
authored
fix(interactive): Fix Schema Fetch Bugs when Switching Graph (#4572)
<!-- Thanks for your contribution! please review https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before opening an issue. --> ## What do these changes do? as titled. <!-- Please give a short brief about these changes. --> ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> Fixes
1 parent c8d7dd0 commit ad1174f

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/config/PlannerConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class PlannerConfig {
1313
"graph.planner.rules",
1414
"FilterIntoJoinRule,FilterMatchRule,ExtendIntersectRule,ExpandGetVFusionRule");
1515
public static final Config<Integer> GRAPH_PLANNER_CBO_GLOGUE_SIZE =
16-
Config.intConfig("graph.planner.cbo.glogue.size", 3);
16+
Config.intConfig("graph.planner.cbo.glogue.size", 2);
1717
public static final Config<Integer> JOIN_MIN_PATTERN_SIZE =
1818
Config.intConfig("graph.planner.join.min.pattern.size", 5);
1919
public static final Config<Integer> JOIN_COST_FACTOR_1 =

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/ir/meta/fetcher/DynamicIrMetaFetcher.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ private synchronized void syncStats() {
138138
if (stats != null && stats.getVertexCount() != 0) {
139139
this.currentState =
140140
new IrMetaStats(
141+
this.currentState.getGraphId(),
141142
this.currentState.getSnapshotId(),
142143
this.currentState.getSchema(),
143144
this.currentState.getStoredProcedures(),

interactive_engine/compiler/src/test/java/com/alibaba/graphscope/common/config/YamlConfigTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void pegasus_config_test() throws Exception {
5454
YamlConfigs configs =
5555
new YamlConfigs("config/gs_interactive_pegasus.yaml", FileLoadType.RESOURCES);
5656
Assert.assertEquals(
57-
"PlannerConfig{isOn=true, opt=RBO, rules=[FilterMatchRule], glogueSize=3}",
57+
"PlannerConfig{isOn=true, opt=RBO, rules=[FilterMatchRule], glogueSize=2}",
5858
(new PlannerConfig(configs)).toString());
5959
Assert.assertEquals(
6060
"localhost:8001, localhost:8005", PegasusConfig.PEGASUS_HOSTS.get(configs));

interactive_engine/compiler/src/test/java/com/alibaba/graphscope/common/ir/planner/neo4j/LSQBTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void lsqb1_test() {
100100
+ " alias=[forum], opt=[VERTEX]): rowcount = 90492.0\n"
101101
+ " GraphPhysicalExpand(tableConfig=[{isAll=false, tables=[HASMEMBER]}],"
102102
+ " alias=[forum], startAlias=[person], opt=[IN], physicalOpt=[VERTEX]):"
103-
+ " rowcount = 1605249.4147843944\n"
103+
+ " rowcount = 1605249.4147843942\n"
104104
+ " GraphPhysicalExpand(tableConfig=[{isAll=false, tables=[ISPARTOF]}],"
105105
+ " alias=[country], startAlias=[city], opt=[OUT], physicalOpt=[VERTEX]):"
106106
+ " rowcount = 9851.375770020533\n"
@@ -279,10 +279,10 @@ public void lsqb5_test() {
279279
"GraphLogicalAggregate(keys=[{variables=[], aliases=[]}],"
280280
+ " values=[[{operands=[message], aggFunction=COUNT, alias='$f0',"
281281
+ " distinct=false}]]): rowcount = 1.0\n"
282-
+ " LogicalFilter(condition=[<>(tag1, tag2)]): rowcount = 899705.0620204923\n"
282+
+ " LogicalFilter(condition=[<>(tag1, tag2)]): rowcount = 899705.0620204924\n"
283283
+ " GraphPhysicalExpand(tableConfig=[[EdgeLabel(HASTAG, COMMENT, TAG)]],"
284284
+ " alias=[tag2], startAlias=[comment], opt=[OUT], physicalOpt=[VERTEX]):"
285-
+ " rowcount = 1799410.1240409845\n"
285+
+ " rowcount = 1799410.1240409848\n"
286286
+ " GraphPhysicalExpand(tableConfig=[[EdgeLabel(HASTAG, COMMENT, TAG)]],"
287287
+ " alias=[tag1], startAlias=[message], opt=[OUT], physicalOpt=[VERTEX]):"
288288
+ " rowcount = 1368478.8223372442\n"

0 commit comments

Comments
 (0)