fix(interactive): Check nullptr for SesionLocalContext destruction (#4599)

zhanglei1949 · web-flow · commit f8b5d69867eb · 2025-04-16T15:47:52.000+08:00
- Check nullptr for `SesionLocalContext` destruction - Use ubuntu-22.04 since [ubuntu-20.04 is deprecated](actions/runner-images#11101) - Use neo4j 5.21.0, it is the oldest version of neo4j which could be successfully installed on ubuntu22, python 3.10
diff --git a/.github/workflows/build-graphscope-dev-images.yml b/.github/workflows/build-graphscope-dev-images.yml
@@ -44,7 +44,7 @@ env:
 jobs:
   build-graphscope-dev-wheel-image-amd64:
     if: (github.event_name == 'workflow_dispatch' && github.event.inputs.build_graphscope_dev_wheel == 'true') || (github.event_name == 'pull_request')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
       with:
@@ -76,7 +76,7 @@ jobs:
 
   build-graphscope-dev-image-amd64:
     if: (github.event_name == 'workflow_dispatch' && github.event.inputs.build_graphscope_dev == 'true') || (github.event_name == 'pull_request')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
       with:
@@ -108,7 +108,7 @@ jobs:
 
   build-vineyard-dev-image-amd64:
     if: (github.event_name == 'workflow_dispatch' && github.event.inputs.build_vineyard_dev == 'true') || (github.event_name == 'pull_request')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
       with:
@@ -141,7 +141,7 @@ jobs:
   build-vineyard-runtime-image-amd64:
     # only trigger this step in 'workflow_dispatch' event, since the 'vineyard-dev' image isn't actually pushed in 'pull_request'
     if: ${{ github.event_name == 'workflow_dispatch' }} && ${{ github.event.inputs.build_vineyard_dev == 'true' }} || (github.event_name == 'pull_request')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-vineyard-dev-image-amd64]
     steps:
     - uses: actions/checkout@v4
diff --git a/.github/workflows/build-graphscope-images-linux.yml b/.github/workflows/build-graphscope-images-linux.yml
@@ -31,7 +31,7 @@ env:
 
 jobs:
   build-image-x86-64:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
     - uses: actions/checkout@v4
@@ -340,7 +340,7 @@ jobs:
 
 
   manifest-push-image:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     # if: (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope')
     if: false
     needs: [build-image-x86-64, build-image-aarch64]
diff --git a/.github/workflows/build-graphscope-manylinux-images.yml b/.github/workflows/build-graphscope-manylinux-images.yml
@@ -21,7 +21,7 @@ env:
 
 jobs:
   build-manylinux-image-amd64:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
       with:
diff --git a/.github/workflows/build-graphscope-wheels-linux.yml b/.github/workflows/build-graphscope-wheels-linux.yml
@@ -95,7 +95,7 @@ jobs:
 
   build-wheels:
     if: (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope') || (github.event_name == 'workflow_dispatch')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
     - uses: actions/checkout@v4
@@ -175,7 +175,7 @@ jobs:
 
   build-image:
     if: (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-wheels]
 
     steps:
@@ -242,7 +242,7 @@ jobs:
 
   ubuntu-python-test:
     if: ${{ (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'workflow_dispatch') }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-wheels]
     strategy:
       fail-fast: false
@@ -298,7 +298,7 @@ jobs:
 
   centos-test:
     if: ${{ (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'workflow_dispatch') }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-wheels]
     container:
       image: centos:8
diff --git a/.github/workflows/build-graphscope-wheels-macos.yml b/.github/workflows/build-graphscope-wheels-macos.yml
@@ -158,7 +158,7 @@ jobs:
   # Action gh-action-pypi-publish not support non-linux os.
   publish-wheels:
     if: (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-wheels, build-client-wheels]
     strategy:
       matrix:
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -8,7 +8,7 @@ on:
       - "v*"
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - name: Checkout Code
       uses: actions/checkout@v4
diff --git a/.github/workflows/interactive.yml b/.github/workflows/interactive.yml
@@ -25,7 +25,7 @@ concurrency:
 
 jobs:
   build-interactive:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     container:
       image: registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-dev:v0.24.2-amd64
@@ -68,7 +68,7 @@ jobs:
 
 
   test-hqps-engine:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: build-interactive
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     container:
@@ -421,7 +421,7 @@ jobs:
 
   # test the different combination of cmake options: -DBUILD_TEST=ON/OFF, -DBUILD_ODPS_FRAGMENT_LOADER=ON/OFF
   test-cmake-options:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     container:
       image: registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-dev:v0.24.2-amd64
     strategy:
@@ -441,7 +441,7 @@ jobs:
         sudo make -j4
 
   test-AOCC-compilation:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     container:
       image: registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-dev:v0.24.2-amd64
     steps:
@@ -469,7 +469,7 @@ jobs:
         sudo make -j4
 
   test-flex:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: build-interactive
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     container:
diff --git a/.github/workflows/k8s-ci.yml b/.github/workflows/k8s-ci.yml
@@ -44,7 +44,7 @@ env:
 jobs:
   # JOB to run change detection
   changes:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     # Set job outputs to values from filter step
     outputs:
       gae-python: ${{ steps.filter.outputs.gae-python }}
diff --git a/.github/workflows/local-ci.yml b/.github/workflows/local-ci.yml
@@ -44,7 +44,7 @@ env:
 jobs:
   # JOB to run change detection
   changes:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     # Set job outputs to values from filter step
     outputs:
       gae-python: ${{ steps.filter.outputs.gae-python }}
@@ -266,7 +266,7 @@ jobs:
         retention-days: 5
 
   mini-test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     needs: [build-wheels]
     steps:
@@ -328,7 +328,7 @@ jobs:
           path: ~/.local/log/graphscope
 
   python-unittest:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     needs: [build-wheels, changes]
     defaults:
@@ -398,7 +398,7 @@ jobs:
         verbose: true
 
   networkx-basic-test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-wheels, changes]
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     defaults:
@@ -490,7 +490,7 @@ jobs:
                           $(dirname $(python3 -c "import graphscope; print(graphscope.__file__)"))/nx/tests/convert
 
   networkx-algo-and-generator-test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: [build-wheels, changes]
     if: ${{ github.repository == 'alibaba/GraphScope' }}
     strategy:
diff --git a/.github/workflows/networkx-forward-algo-nightly.yml b/.github/workflows/networkx-forward-algo-nightly.yml
@@ -12,7 +12,7 @@ on:
 jobs:
   forward-algo-test:
     if: ${{ github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope' }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     defaults:
       run:
         shell: bash --noprofile --norc -eo pipefail {0}
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -58,7 +58,7 @@ jobs:
         make install INSTALL_PREFIX=/opt/graphscope
 
     - name: Run Python Test
-      if: matrix.os == 'ubuntu-20.04'
+      if: matrix.os == 'ubuntu-22.04'
       env:
         FULL_TEST_SUITE: ON
         GS_TEST_DIR: ${{ github.workspace }}/gstest
@@ -71,7 +71,7 @@ jobs:
 
     - name: Upload Coverage
       uses: codecov/codecov-action@v4
-      if: matrix.os == 'ubuntu-20.04'
+      if: matrix.os == 'ubuntu-22.04'
       continue-on-error: true
       with:
         files: ./python/coverage.xml
diff --git a/.github/workflows/pegasus.yml b/.github/workflows/pegasus.yml
@@ -21,7 +21,7 @@ env:
 
 jobs:
   pegasus-build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
 
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   PR-Check:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     permissions:
       pull-requests: write
 
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -24,7 +24,7 @@ env:
 jobs:
   build-gsctl-wheel-package:
     if: (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
     - uses: actions/checkout@v4
@@ -218,7 +218,7 @@ jobs:
 
   build-gss-image-amd64:
     if: (github.ref == 'refs/heads/main' && github.repository == 'alibaba/GraphScope') || (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
 
@@ -282,7 +282,7 @@ jobs:
   push-gss-image-manifest:
     # if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope' }}
     if: false
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     needs: [build-gss-image-amd64, build-gss-image-arm64]
 
@@ -314,7 +314,7 @@ jobs:
 
   release-helm-charts:
     if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'alibaba/GraphScope' }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
 
diff --git a/flex/engines/graph_db/database/graph_db.cc b/flex/engines/graph_db/database/graph_db.cc
@@ -42,7 +42,11 @@ struct SessionLocalContext {
                        : thread_local_allocator_prefix(work_dir, thread_id))),
         logger(std::move(in_logger)),
         session(db, allocator, *logger, work_dir, thread_id) {}
-  ~SessionLocalContext() { logger->close(); }
+  ~SessionLocalContext() {
+    if (logger) {
+      logger->close();
+    }
+  }
   Allocator allocator;
   char _padding0[128 - sizeof(Allocator) % 128];
   std::unique_ptr<IWalWriter> logger;
diff --git a/k8s/dockerfiles/coordinator.Dockerfile b/k8s/dockerfiles/coordinator.Dockerfile
@@ -65,7 +65,7 @@ COPY ./interactive_engine/assembly/src/bin/graphscope/giectl /opt/graphscope/bin
 COPY ./k8s/utils/kube_ssh /usr/local/bin/kube_ssh
 RUN sudo chmod a+wrx /tmp
 
-#to make sure neo4j==5.10.0 can be installed
+#to make sure neo4j==5.21.0 can be installed
 RUN pip3 install pip==20.3.4
 
 USER graphscope
diff --git a/k8s/dockerfiles/learning.Dockerfile b/k8s/dockerfiles/learning.Dockerfile
@@ -40,7 +40,7 @@ RUN sudo apt-get update -y && \
 
 RUN sudo chmod a+wrx /tmp
 
-#to make sure neo4j==5.10.0 can be installed
+#to make sure neo4j==5.21.0 can be installed
 RUN pip3 install pip==20.3.4 
 
 COPY --from=builder /home/graphscope/install /opt/graphscope/
diff --git a/python/requirements.txt b/python/requirements.txt
@@ -5,7 +5,7 @@ grpcio-tools>=1.49
 kubernetes>=24.2.0
 msgpack>=1.0.5
 mypy-protobuf>=3.4.0
-neo4j==5.10.0
+neo4j==5.21.0
 nest_asyncio
 networkx==2.8.0;python_version>="3.8"
 networkx==2.6.0;python_version<"3.8"
