refactor(sdks): add api version to base url

Author: ninan-nn

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/config/ConnectionConfig.kt

@@ -50,6 +50,7 @@ class ConnectionConfig private constructor(
         private const val ENV_DOMAIN = "OPEN_SANDBOX_DOMAIN"
 
         private const val DEFAULT_USER_AGENT = "OpenSandbox-Kotlin-SDK/1.0.1"
+        private const val API_VERSION = "v1"
 
         @JvmStatic
         fun builder(): Builder = Builder()
@@ -69,7 +70,7 @@ class ConnectionConfig private constructor(
         if (currentDomain.startsWith("http://") || currentDomain.startsWith("https://")) {
             return currentDomain
         }
-        return "$protocol://$currentDomain"
+        return "$protocol://$currentDomain/$API_VERSION"
     }
 
     /**

sdks/sandbox/kotlin/sandbox/src/test/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/SandboxesAdapterTest.kt

@@ -94,7 +94,7 @@ class SandboxesAdapterTest {
         // Verify request
         val request = mockWebServer.takeRequest()
         assertEquals("POST", request.method)
-        assertEquals("/sandboxes", request.path)
+        assertEquals("/v1/sandboxes", request.path)
         val requestBody = request.body.readUtf8()
         assertTrue(requestBody.isNotBlank(), "request body should not be blank")
 
@@ -140,7 +140,7 @@ class SandboxesAdapterTest {
         assertEquals("ubuntu:latest", result.image.image)
 
         val request = mockWebServer.takeRequest()
-        assertEquals("/sandboxes/$sandboxId", request.path)
+        assertEquals("/v1/sandboxes/$sandboxId", request.path)
     }
 
     @Test

sdks/sandbox/python/src/opensandbox/adapters/converter/execution_converter.py

@@ -50,7 +50,6 @@ def to_api_run_command_request(command: str, opts: RunCommandOpts) -> ApiRunComm
         if opts.working_directory:
             cwd = opts.working_directory
 
-        # Convert background. Domain uses bool (default False). When false, omit it from the API request.
         background = UNSET
         if opts.background:
             background = opts.background

sdks/sandbox/python/src/opensandbox/config/connection.py

@@ -82,6 +82,7 @@ class ConnectionConfig(BaseModel):
     _ENV_API_KEY = "OPEN_SANDBOX_API_KEY"
     _ENV_DOMAIN = "OPEN_SANDBOX_DOMAIN"
     _DEFAULT_DOMAIN = "localhost:8080"
+    _API_VERSION = "v1"
 
     def model_post_init(self, __context: object) -> None:
         # If the user explicitly provided `transport`, the SDK must not close it.
@@ -128,10 +129,10 @@ def get_domain(self) -> str:
 
     def get_base_url(self) -> str:
         """Get the full base URL for API requests."""
-        current_domain = self.get_domain()
+        domain = self.get_domain()
         # Allow domain to override protocol if it explicitly starts with a scheme
-        if current_domain.startswith("http://") or current_domain.startswith(
+        if domain.startswith("http://") or domain.startswith(
             "https://"
         ):
-            return current_domain
-        return f"{self.protocol}://{current_domain}"
+            return f"{domain}/{self._API_VERSION}"
+        return f"{self.protocol}://{domain}/{self._API_VERSION}"

sdks/sandbox/python/src/opensandbox/config/connection_sync.py

@@ -68,6 +68,7 @@ class ConnectionConfigSync(BaseModel):
     _ENV_API_KEY = "OPEN_SANDBOX_API_KEY"
     _ENV_DOMAIN = "OPEN_SANDBOX_DOMAIN"
     _DEFAULT_DOMAIN = "localhost:8080"
+    _API_VERSION = "v1"
 
     def model_post_init(self, __context: object) -> None:
         self._owns_transport = "transport" not in self.model_fields_set
@@ -105,5 +106,5 @@ def get_domain(self) -> str:
     def get_base_url(self) -> str:
         domain = self.get_domain()
         if domain.startswith("http://") or domain.startswith("https://"):
-            return domain
-        return f"{self.protocol}://{domain}"
+            return f"{domain}/{self._API_VERSION}"
+        return f"{self.protocol}://{domain}/{self._API_VERSION}"

sdks/sandbox/python/tests/test_connection_config.py

@@ -29,12 +29,12 @@ def test_protocol_validation() -> None:
 
 def test_get_base_url_with_domain_and_protocol() -> None:
     cfg = ConnectionConfig(domain="example.com:1234", protocol="https")
-    assert cfg.get_base_url() == "https://example.com:1234"
+    assert cfg.get_base_url() == "https://example.com:1234/v1"
 
 
 def test_get_base_url_domain_can_include_scheme() -> None:
     cfg = ConnectionConfig(domain="https://example.com:9999", protocol="http")
-    assert cfg.get_base_url() == "https://example.com:9999"
+    assert cfg.get_base_url() == "https://example.com:9999/v1"
 
 
 @pytest.mark.asyncio

sdks/sandbox/python/tests/test_converters_and_error_handling.py

@@ -102,7 +102,8 @@ def test_execution_converter_to_api_run_command_request() -> None:
     )
     d2 = api2.to_dict()
     assert d2["cwd"] == "/tmp"
-    assert d2.get("background", UNSET) is not UNSET
+    # background defaults to False in domain opts; when False we omit it from the API request.
+    assert d2.get("background", UNSET) is UNSET
 
 
 def test_filesystem_and_metrics_converters() -> None:

sdks/sandbox/python/tests/test_sandbox_service_adapter_lifecycle.py

@@ -197,8 +197,15 @@ async def test_renew_sandbox_expiration_sends_timezone_aware(monkeypatch: pytest
     captured = {}
 
     async def _fake_asyncio_detailed(*, client, sandbox_id, body):
+        from opensandbox.api.lifecycle.models.renew_sandbox_expiration_response import (
+            RenewSandboxExpirationResponse,
+        )
+
         captured["expires_at"] = body.expires_at
-        return _Resp(status_code=204, parsed=None)
+        return _Resp(
+            status_code=200,
+            parsed=RenewSandboxExpirationResponse(expires_at=body.expires_at),
+        )
 
     monkeypatch.setattr(
         "opensandbox.api.lifecycle.api.sandboxes.post_sandboxes_sandbox_id_renew_expiration.asyncio_detailed",