add 'Fix all failing unit tests' task to prd.json

Author: DQinYuan

prd.json

@@ -555,6 +555,17 @@
       "priority": 33,
       "passes": true,
       "notes": "COMPLETED (2026-02-23):\n\n- Updated README-source.adoc to reflect hand-written recursive descent parser (replaced ANTLR4 references)\n- Updated README-EN-source.adoc with same changes\n- Updated CLAUDE.md with comprehensive new parser architecture documentation\n- Added detailed section 5 describing the new parser architecture, package structure, token types, AST nodes, visitor pattern, and parsing flow\n- Noted that aparser package still exists for backward compatibility\n\nThe documentation now accurately reflects the new hand-written parser while acknowledging the legacy aparser package."
+    },
+    {
+      "id": "US-034",
+      "title": "Fix all failing unit tests",
+      "description": "As a developer, I need all 644 unit tests to pass so that the new hand-written parser is fully production-ready. Currently 52 tests fail (25 failures + 27 errors) across multiple categories.",
+      "acceptanceCriteria": [
+        "All 644 tests pass with mvn test"
+      ],
+      "priority": 34,
+      "passes": false,
+      "notes": "Current state (2026-02-23): 644 tests total, 592 pass, 25 failures + 27 errors = 52 failing.\n\nFailure categories:\n1. Parser SYNTAX_ERRORs: BIT_AND, GT in generics, COMMA spread, DOT chain, CATCH_ALL wildcard import, FUNCTION as identifier\n2. InstructionGenerator: IfNode and TryCatchNode visitor methods broken\n3. ScriptChecker/OperatorLimit: operator count logic off\n4. Error position reporting: line/column numbers incorrect\n5. Macro support: macro definition/invocation returning null\n6. Function registry: getOutFunctions returning built-ins\n7. Spread operator: list spread not expanding\n8. Number/string literals: edge case parsing\n9. Variable detection: qualified paths (a.b.c) not tracked\n10. Import aliases and static imports\n11. Operator alias/extension functions\n12. Short-circuit evaluation options\n13. Reflection: class fields, default interface methods\n14. Timeout detection\n15. Suite test failures"
     }
   ]
 }

src/main/java/com/alibaba/qlexpress4/Express4Runner.java

@@ -685,10 +685,10 @@ private Future<QCompileCache> getParseFuture(String script) {
     private QCompileCache parseDefinition(String script) {
         ProgramNode programNode = parseToSyntaxTree(script);
         ImportManager importManager = inheritDefaultImport();
-
+        
         // Process import statements from the program
         importManager = processImports(programNode, importManager);
-
+        
         try {
             if (initOptions.isTraceExpression()) {
                 // Compile with trace points
@@ -710,7 +710,7 @@ private QCompileCache parseDefinition(String script) {
             throw new RuntimeException("Compilation failed", e);
         }
     }
-
+    
     /**
      * Process import statements from a ProgramNode and add them to the ImportManager.
      *
@@ -722,13 +722,13 @@ private ImportManager processImports(ProgramNode programNode, ImportManager impo
         // Create a new ImportManager with all the existing imports
         // Note: ImportManager is mutable, so we need to be careful
         // We'll add imports to the existing manager
-
+        
         for (StatementNode statement : programNode.getStatements()) {
             if (statement instanceof com.alibaba.qlexpress4.parser.ast.ImportNode) {
                 com.alibaba.qlexpress4.parser.ast.ImportNode importNode =
                     (com.alibaba.qlexpress4.parser.ast.ImportNode)statement;
                 String importPath = importNode.getImportPath();
-
+                
                 if (importNode.isWildcard()) {
                     // Wildcard import: import com.example.*
                     importManager.addImport(ImportManager.importCls(importPath + ".*"));
@@ -739,10 +739,10 @@ private ImportManager processImports(ProgramNode programNode, ImportManager impo
                 }
             }
         }
-
+        
         return importManager;
     }
-
+    
     private ImportManager inheritDefaultImport() {
         return new ImportManager(initOptions.getClassSupplier(), initOptions.getDefaultImport());
     }

src/main/java/com/alibaba/qlexpress4/aparser/compiletimefunction/CodeGenerator.java

@@ -21,17 +21,16 @@
  */
 @Deprecated
 public interface CodeGenerator {
-
+    
     void addInstruction(QLInstruction qlInstruction);
-
+    
     void addInstructionsByTree(Object tree);
-
+    
     QLSyntaxException reportParseErr(String errCode, String errReason);
-
-    QLambdaDefinition generateLambdaDefinition(Object expressionContext,
-        List<QLambdaDefinitionInner.Param> params);
-
+    
+    QLambdaDefinition generateLambdaDefinition(Object expressionContext, List<QLambdaDefinitionInner.Param> params);
+    
     ErrorReporter getErrorReporter();
-
+    
     ErrorReporter newReporterWithToken(Object token);
 }

src/main/java/com/alibaba/qlexpress4/aparser/compiletimefunction/CompileTimeFunction.java

@@ -21,7 +21,7 @@
  */
 @Deprecated
 public interface CompileTimeFunction {
-
+    
     /**
      * Create instructions for function at compile time.
      *
@@ -31,7 +31,7 @@ public interface CompileTimeFunction {
      * @param codeGenerator tool for code generation (currently not supported)
      * @throws UnsupportedOperationException always - feature not yet migrated
      */
-    void createFunctionInstruction(String functionName, Object arguments,
-        OperatorFactory operatorFactory, Object codeGenerator);
-
+    void createFunctionInstruction(String functionName, Object arguments, OperatorFactory operatorFactory,
+        Object codeGenerator);
+    
 }

src/main/java/com/alibaba/qlexpress4/common/BuiltInTypesSet.java

@@ -1,23 +1,23 @@
 package com.alibaba.qlexpress4.common;
 
 public class BuiltInTypesSet {
-
+    
     public static final String BYTE = "byte";
-
+    
     public static final String SHORT = "short";
-
+    
     public static final String INT = "int";
-
+    
     public static final String LONG = "long";
-
+    
     public static final String FLOAT = "float";
-
+    
     public static final String DOUBLE = "double";
-
+    
     public static final String BOOLEAN = "boolean";
-
+    
     public static final String CHAR = "char";
-
+    
     public static Class<?> getCls(String lexeme) {
         switch (lexeme) {
             case BYTE:

src/main/java/com/alibaba/qlexpress4/common/GeneratorScope.java

@@ -7,25 +7,25 @@
  * Author: DQinYuan
  */
 public class GeneratorScope {
-
+    
     private final GeneratorScope parent;
-
+    
     private final String name;
-
+    
     private final Map<String, MacroDefine> macroDefineMap;
-
+    
     public GeneratorScope(GeneratorScope parent, String name, Map<String, MacroDefine> macroDefineMap) {
         this.parent = parent;
         this.name = name;
         this.macroDefineMap = macroDefineMap;
     }
-
+    
     public GeneratorScope(String name, GeneratorScope parent) {
         this.parent = parent;
         this.name = name;
         this.macroDefineMap = new HashMap<>();
     }
-
+    
     /**
      * @param name macro name
      * @param macroDefine macro definition
@@ -34,16 +34,16 @@ public GeneratorScope(String name, GeneratorScope parent) {
     public boolean defineMacroIfAbsent(String name, MacroDefine macroDefine) {
         return macroDefineMap.putIfAbsent(name, macroDefine) == null;
     }
-
+    
     public void defineMacro(String name, MacroDefine macroDefine) {
         macroDefineMap.put(name, macroDefine);
     }
-
+    
     public MacroDefine getMacroInstructions(String macroName) {
         MacroDefine qlInstructions = macroDefineMap.get(macroName);
         return qlInstructions != null ? qlInstructions : parent != null ? parent.getMacroInstructions(macroName) : null;
     }
-
+    
     public String getName() {
         return name;
     }

src/main/java/com/alibaba/qlexpress4/common/ImportManager.java

@@ -11,27 +11,27 @@
  * Author: DQinYuan
  */
 public class ImportManager {
-
+    
     private final ClassSupplier classSupplier;
-
+    
     private final List<QLImport> importedPacks;
-
+    
     private final Map<String, Class<?>> importedClses;
-
+    
     public ImportManager(ClassSupplier classSupplier, List<QLImport> imports) {
         this.classSupplier = classSupplier;
         this.importedPacks = new ArrayList<>();
         this.importedClses = new HashMap<>();
         imports.forEach(this::addImport);
     }
-
+    
     public ImportManager(ClassSupplier classSupplier, List<QLImport> importedPacks,
         Map<String, Class<?>> importedClses) {
         this.classSupplier = classSupplier;
         this.importedPacks = importedPacks;
         this.importedClses = importedClses;
     }
-
+    
     public boolean addImport(QLImport anImport) {
         switch (anImport.getScope()) {
             case PACK:
@@ -53,11 +53,11 @@ public boolean addImport(QLImport anImport) {
                 return false;
         }
     }
-
+    
     public Class<?> loadQualified(String qualifiedCls) {
         return classSupplier.loadCls(qualifiedCls);
     }
-
+    
     public LoadPartQualifiedResult loadPartQualified(List<String> fieldIds) {
         Class<?> qualifiedCls = null;
         List<String> qualifiedPath = null;
@@ -151,7 +151,7 @@ public LoadPartQualifiedResult loadPartQualified(List<String> fieldIds) {
                     break;
             }
         }
-
+        
         switch (state) {
             case continueState:
                 return new LoadPartQualifiedResult(null, 0);
@@ -169,29 +169,29 @@ public LoadPartQualifiedResult loadPartQualified(List<String> fieldIds) {
                 return new LoadPartQualifiedResult(null, 0);
         }
     }
-
+    
     public static class LoadPartQualifiedResult {
         private final Class<?> cls;
-
+        
         /**
          * first no class path field index
          */
         private final int restIndex;
-
+        
         public LoadPartQualifiedResult(Class<?> cls, int restIndex) {
             this.cls = cls;
             this.restIndex = restIndex;
         }
-
+        
         public Class<?> getCls() {
             return cls;
         }
-
+        
         public int getRestIndex() {
             return restIndex;
         }
     }
-
+    
     public enum ImportScope {
         // import java.lang.*;
         PACK,
@@ -202,19 +202,19 @@ public enum ImportScope {
         // for Code Obfuscation Use Cases
         ALIAS
     }
-
+    
     public static QLImport importInnerCls(String clsPath) {
         return new QLImport(ImportScope.InnerCls, clsPath);
     }
-
+    
     public static QLImport importPack(String packPath) {
         return new QLImport(ImportScope.PACK, packPath);
     }
-
+    
     public static QLImport importCls(String clsPath) {
         return new QLImport(ImportScope.CLS, clsPath);
     }
-
+    
     public static QLImport importClsAlias(Class<?> cls, String alias) {
         if (cls == null) {
             throw new IllegalArgumentException("Class cannot be null");
@@ -227,40 +227,40 @@ public static QLImport importClsAlias(Class<?> cls, String alias) {
         }
         return new QLImport(cls, alias);
     }
-
+    
     public static class QLImport {
         private final ImportScope scope;
-
+        
         private String target;
-
+        
         private Class<?> cls;
-
+        
         private String alias;
-
+        
         public QLImport(ImportScope scope, String target) {
             this.scope = scope;
             this.target = target;
             this.cls = null;
         }
-
+        
         public QLImport(Class<?> cls, String alias) {
             this.scope = ImportScope.ALIAS;
             this.cls = cls;
             this.alias = alias;
         }
-
+        
         public ImportScope getScope() {
             return scope;
         }
-
+        
         public String getTarget() {
             return target;
         }
-
+        
         public Class<?> getCls() {
             return cls;
         }
-
+        
         public String getAlias() {
             return alias;
         }

src/main/java/com/alibaba/qlexpress4/common/MacroDefine.java

@@ -8,20 +8,20 @@
  * Author: DQinYuan
  */
 public class MacroDefine {
-
+    
     private final List<QLInstruction> instructions;
-
+    
     private final boolean lastStmtExpress;
-
+    
     public MacroDefine(List<QLInstruction> instructions, boolean lastStmtExpress) {
         this.instructions = instructions;
         this.lastStmtExpress = lastStmtExpress;
     }
-
+    
     public List<QLInstruction> getMacroInstructions() {
         return instructions;
     }
-
+    
     public boolean isLastStmtExpress() {
         return lastStmtExpress;
     }