Skip to content

Commit 676ace8

Browse files
authored
feat: use /tmp as default for ROCK_SERVICE_STATUS_DIR (#522)
- Change default value from /data/service_status to /tmp - Add test to verify the default value
1 parent de4baf9 commit 676ace8

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

rock/env_vars.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"ROCK_LOGGING_PATH": lambda: os.getenv("ROCK_LOGGING_PATH"),
6767
"ROCK_LOGGING_FILE_NAME": lambda: os.getenv("ROCK_LOGGING_FILE_NAME", "rocklet.log"),
6868
"ROCK_LOGGING_LEVEL": lambda: os.getenv("ROCK_LOGGING_LEVEL", "INFO"),
69-
"ROCK_SERVICE_STATUS_DIR": lambda: os.getenv("ROCK_SERVICE_STATUS_DIR", "/data/service_status"),
69+
"ROCK_SERVICE_STATUS_DIR": lambda: os.getenv("ROCK_SERVICE_STATUS_DIR", "/tmp"),
7070
"ROCK_SCHEDULER_STATUS_DIR": lambda: os.getenv("ROCK_SCHEDULER_STATUS_DIR", "/data/scheduler_status"),
7171
"ROCK_CONFIG": lambda: os.getenv("ROCK_CONFIG"),
7272
"ROCK_CONFIG_DIR_NAME": lambda: os.getenv("ROCK_CONFIG_DIR_NAME", "rock-conf"),

tests/unit/test_envs.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import os
2+
13
from rock import env_vars
24

35

@@ -10,3 +12,15 @@ def test_default_envs():
1012
def test_envs_project_root():
1113
project_root = env_vars.ROCK_PROJECT_ROOT
1214
assert project_root is not None
15+
16+
17+
def test_service_status_dir_default():
18+
"""ROCK_SERVICE_STATUS_DIR 默认值应为 /tmp"""
19+
# 清除可能已设置的环境变量
20+
original = os.environ.pop("ROCK_SERVICE_STATUS_DIR", None)
21+
try:
22+
status_dir = env_vars.ROCK_SERVICE_STATUS_DIR
23+
assert status_dir == "/tmp", f"Expected /tmp, got {status_dir}"
24+
finally:
25+
if original is not None:
26+
os.environ["ROCK_SERVICE_STATUS_DIR"] = original

0 commit comments

Comments
 (0)