test: cleanup unit test, use domain method name instead of implementation

Author: oldratlee

library/src/test/java/com/alibaba/dcm/DnsCacheManipulatorTest.java

@@ -95,7 +95,7 @@ public void test_setDnsCache_getAllDnsCache() {
                 host, new String[]{IP1}, Long.MAX_VALUE);
         DnsCacheEntry actual = allDnsCacheEntries.get(0);
 
-        assertEqualsIgnoreHostCase(expected, actual);
+        assertEqualsDnsCacheEntry(expected, actual);
 
         DnsCacheEntry another = DnsCacheManipulator.getDnsCache(host);
         DnsCacheEntry another2 = DnsCacheManipulator.getDnsCache(host);
@@ -132,7 +132,7 @@ public void test_setNotExistedDomain_RemoveThenReLookupAndNotExisted() throws Ex
 
         final List<DnsCacheEntry> negativeCache = DnsCacheManipulator.listDnsNegativeCache();
         assertEquals(1, negativeCache.size());
-        assertEqualsIgnoreCase(DOMAIN_NOT_EXISTED, negativeCache.get(0).getHost());
+        assertEqualsHostName(DOMAIN_NOT_EXISTED, negativeCache.get(0).getHost());
     }
 
     @Test
@@ -149,7 +149,7 @@ public void test_setNotExistedDomain_canExpire_thenReLookupAndNotExisted() throw
 
         final List<DnsCacheEntry> negativeCache = DnsCacheManipulator.listDnsNegativeCache();
         assertEquals(1, negativeCache.size());
-        assertEqualsIgnoreCase(DOMAIN_NOT_EXISTED, negativeCache.get(0).getHost());
+        assertEqualsHostName(DOMAIN_NOT_EXISTED, negativeCache.get(0).getHost());
     }
 
     ////////////////////////////////////////////////////////////////////
@@ -295,14 +295,14 @@ public void test_multi_ips_in_config_file() {
                 new String[]{IP1, IP2}, Long.MAX_VALUE);
 
         final DnsCacheEntry actual = DnsCacheManipulator.getDnsCache(host);
-        assertEqualsIgnoreHostCase(expected, actual);
+        assertEqualsDnsCacheEntry(expected, actual);
 
         final String hostLoose = "www.hello-multi-ips-loose.com";
         DnsCacheEntry expectedLoose = new DnsCacheEntry(hostLoose,
                 new String[]{IP1, IP2, IP3, IP4}, Long.MAX_VALUE);
 
         DnsCacheEntry actualLoose = DnsCacheManipulator.getDnsCache(hostLoose);
-        assertEqualsIgnoreHostCase(expectedLoose, actualLoose);
+        assertEqualsDnsCacheEntry(expectedLoose, actualLoose);
     }
 
     @Test

library/src/test/java/com/alibaba/dcm/Util.java

@@ -61,8 +61,8 @@ static void assertOnlyNegativeCache(long start, long end) {
         assertBetween(first.getExpiration().getTime(), start, end);
     }
 
-    static void assertEqualsIgnoreHostCase(DnsCacheEntry expected, DnsCacheEntry actual) {
-        assertEqualsIgnoreCase(expected.getHost(), actual.getHost());
+    static void assertEqualsDnsCacheEntry(DnsCacheEntry expected, DnsCacheEntry actual) {
+        assertEqualsHostName(expected.getHost(), actual.getHost());
         assertArrayEquals(expected.getIps(), actual.getIps());
 
         final long expectedExpiration = expected.getExpiration().getTime();
@@ -80,8 +80,13 @@ static void assertEqualsIgnoreHostCase(DnsCacheEntry expected, DnsCacheEntry act
         }
     }
 
-    static void assertEqualsIgnoreCase(String expected, String actual) {
-        assertEquals(expected.toLowerCase(), actual.toLowerCase());
+    static void assertEqualsHostName(String expected, String actual) {
+        if (isJdkAtMost8()) {
+            // java 8-, host name is unified to lower case by InetAddress
+            assertEquals(expected.toLowerCase(), actual.toLowerCase());
+        } else {
+            assertEquals(expected, actual);
+        }
     }
 
     static void assertBetween(long actual, long start, long end) {