Skip to content

Commit 640ef12

Browse files
committed
refactor: remove apache.commons.io runtime dependency of DcmTool
1 parent 8ba4cf0 commit 640ef12

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

library/src/test/java/com/alibaba/demo/SocketDemo.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,22 @@
33
import org.apache.commons.io.IOUtils;
44

55
import java.net.Socket;
6-
import java.nio.charset.Charset;
7-
import java.nio.charset.StandardCharsets;
6+
7+
import static java.nio.charset.StandardCharsets.UTF_8;
88

99
/**
1010
* @author Jerry Lee (oldratlee at gmail dot com)
1111
*/
1212
public class SocketDemo {
13-
private static final Charset encoding = StandardCharsets.UTF_8;
1413

1514
public static void main(String[] args) throws Exception {
1615
Socket client = new Socket("www.bing.com", 80);
1716

1817
client.setSoTimeout(30 * 1000);
1918

20-
IOUtils.write("Hello world!", client.getOutputStream(), encoding);
19+
IOUtils.write("Hello world!", client.getOutputStream(), UTF_8);
2120

22-
final String input = IOUtils.toString(client.getInputStream(),encoding);
21+
final String input = IOUtils.toString(client.getInputStream(), UTF_8);
2322
System.out.println(input);
2423
System.out.println("bye!");
2524

tool/pom.xml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,17 +65,18 @@
6565
<groupId>commons-cli</groupId>
6666
<artifactId>commons-cli</artifactId>
6767
</dependency>
68-
<dependency>
69-
<groupId>commons-io</groupId>
70-
<artifactId>commons-io</artifactId>
71-
</dependency>
7268

7369
<!-- Testing libs -->
7470
<dependency>
7571
<groupId>org.apache.commons</groupId>
7672
<artifactId>commons-lang3</artifactId>
7773
<scope>test</scope>
7874
</dependency>
75+
<dependency>
76+
<groupId>commons-io</groupId>
77+
<artifactId>commons-io</artifactId>
78+
<scope>test</scope>
79+
</dependency>
7980
<!-- https://www.baeldung.com/java-comparing-versions -->
8081
<dependency>
8182
<groupId>org.apache.maven</groupId>

tool/src/main/java/com/alibaba/dcm/tool/DcmTool.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
import com.sun.tools.attach.*;
55
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
66
import org.apache.commons.cli.*;
7-
import org.apache.commons.io.FileUtils;
87

98
import javax.annotation.Nonnull;
10-
import java.io.File;
119
import java.io.IOException;
1210
import java.lang.management.ManagementFactory;
11+
import java.nio.file.Files;
12+
import java.nio.file.Paths;
1313
import java.util.List;
1414
import java.util.Scanner;
1515

@@ -109,7 +109,7 @@ private static void doDcmActionViaAgent(@Nonnull String action, @Nonnull String[
109109
private static boolean printDcmResult(@Nonnull String tmpFile) throws IOException {
110110
boolean actionSuccess = false;
111111

112-
final List<String> lines = FileUtils.readLines(new File(tmpFile), UTF_8);
112+
final List<String> lines = Files.readAllLines(Paths.get(tmpFile), UTF_8);
113113

114114
final int lastIdx = lines.size() - 1;
115115
final String lastLine = lines.get(lastIdx);

0 commit comments

Comments
 (0)