Skip to content

Support building with glog 0.7.1 and/or ng-log 0.8.2 #180

@cho-m

Description

@cho-m

Is your feature request related to a problem? Please describe.
libgrape-lite currently does not build with the final glog release (0.7.1) or current ng-log release (0.8.2)

Describe the solution you'd like
Easiest option for now is to update CMake scripts to use glog-config.cmake and fall back to module. This will at least work until ng-log 0.9.x

Describe alternatives you've considered
With original glog no longer maintained (https://github.com/google/glog?tab=readme-ov-file#google-logging-library), may need to consider one of following in the future but they will require more changes:

  1. Adding direct support for ng-log without compatibility layer which will be removed in 0.9.x
  2. Switching to another logging library (Google's replacement option is abseil logging)

Additional context
Opening this issue for Homebrew as we are trying to update glog and right now libgrape-lite is one of the projects that doesn't build with newer glog or ng-log.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions