Add start time for invocations

Change-Id: Ib457bdf92d0dbe92237f632473b7a3f3ab3233b9
Co-developed-by: Cursor <[email protected]>

Author: Cirilla-zmh

instrumentation-loongsuite/loongsuite-instrumentation-dashscope/examples/basic_example.py

@@ -13,9 +13,9 @@
 import os
 
 from dashscope import Generation, TextEmbedding
-from opentelemetry.instrumentation.dashscope import DashScopeInstrumentor
 
 from opentelemetry import trace
+from opentelemetry.instrumentation.dashscope import DashScopeInstrumentor
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import (
     ConsoleSpanExporter,

instrumentation-loongsuite/loongsuite-instrumentation-dashscope/tests/conftest.py

@@ -12,12 +12,11 @@
 if "DASHSCOPE_API_KEY" not in os.environ:
     os.environ["DASHSCOPE_API_KEY"] = "test_dashscope_api_key"
 
-from opentelemetry.instrumentation.dashscope import DashScopeInstrumentor
-
 from opentelemetry.instrumentation._semconv import (
     OTEL_SEMCONV_STABILITY_OPT_IN,
     _OpenTelemetrySemanticConventionStability,
 )
+from opentelemetry.instrumentation.dashscope import DashScopeInstrumentor
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import SimpleSpanProcessor
 from opentelemetry.sdk.trace.export.in_memory_span_exporter import (

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_extended_memory/memory_types.py

@@ -57,3 +57,4 @@ class MemoryInvocation:
     # Server information
     server_address: str | None = None
     server_port: int | None = None
+    monotonic_start_s: float | None = None

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_extended_memory/memory_utils.py

@@ -37,6 +37,10 @@
 from opentelemetry.util.genai._extended_memory.memory_types import (
     MemoryInvocation,
 )
+from opentelemetry.util.genai._extended_semconv.gen_ai_extended_attributes import (
+    GEN_AI_SPAN_KIND,
+    GenAiSpanKindValues,
+)
 from opentelemetry.util.genai._extended_semconv.gen_ai_memory_attributes import (
     GEN_AI_MEMORY_AGENT_ID,
     GEN_AI_MEMORY_APP_ID,
@@ -193,6 +197,8 @@ def _apply_memory_finish_attributes(
     else:
         span.update_name("memory_operation")
 
+    span.set_attribute(GEN_AI_SPAN_KIND, GenAiSpanKindValues.MEMORY.value)
+
     # Build all attributes
     attributes: dict[str, Any] = {}
     attributes.update(_get_memory_common_attributes(invocation))

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_extended_semconv/gen_ai_extended_attributes.py

@@ -134,6 +134,9 @@ class GenAiSpanKindValues(Enum):
     RERANKER = "RERANKER"
     """Document reranking operation."""
 
+    MEMORY = "MEMORY"
+    """Memory operation."""
+
 
 class GenAiExtendedOperationNameValues(Enum):
     RETRIEVE_DOCUMENTS = "retrieve_documents"

util/opentelemetry-util-genai/src/opentelemetry/util/genai/extended_handler.py

@@ -63,6 +63,7 @@
 
 from __future__ import annotations
 
+import timeit
 from contextlib import contextmanager
 from typing import Iterator, Optional
 
@@ -150,6 +151,9 @@ def start_create_agent(
             name=span_name,
             kind=SpanKind.CLIENT,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)
@@ -224,6 +228,9 @@ def start_embedding(
             name=f"{GenAI.GenAiOperationNameValues.EMBEDDINGS.value} {invocation.request_model}",
             kind=SpanKind.CLIENT,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)
@@ -298,6 +305,9 @@ def start_execute_tool(
             name=f"{GenAI.GenAiOperationNameValues.EXECUTE_TOOL.value} {invocation.tool_name}",
             kind=SpanKind.INTERNAL,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)
@@ -379,6 +389,9 @@ def start_invoke_agent(
             name=span_name,
             kind=SpanKind.INTERNAL,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)
@@ -458,6 +471,9 @@ def start_retrieve(
             name="retrieve_documents",
             kind=SpanKind.INTERNAL,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)
@@ -530,6 +546,9 @@ def start_rerank(self, invocation: RerankInvocation) -> RerankInvocation:
             name="rerank_documents",
             kind=SpanKind.INTERNAL,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)
@@ -603,6 +622,9 @@ def start_memory(self, invocation: MemoryInvocation) -> MemoryInvocation:
             name=span_name,
             kind=SpanKind.CLIENT,
         )
+        # Record a monotonic start timestamp (seconds) for duration
+        # calculation using timeit.default_timer.
+        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)

util/opentelemetry-util-genai/src/opentelemetry/util/genai/extended_metrics.py

@@ -28,6 +28,9 @@
 from typing import Optional, Union
 
 from opentelemetry.trace import Span
+from opentelemetry.util.genai._extended_memory.memory_types import (
+    MemoryInvocation,
+)
 from opentelemetry.util.genai.extended_types import (
     CreateAgentInvocation,
     EmbeddingInvocation,
@@ -68,6 +71,7 @@ def record_extended(
             CreateAgentInvocation,
             RetrieveInvocation,
             RerankInvocation,
+            MemoryInvocation,
         ],
         *,
         error_type: Optional[str] = None,

util/opentelemetry-util-genai/src/opentelemetry/util/genai/extended_types.py

@@ -82,6 +82,7 @@ class EmbeddingInvocation:
     encoding_formats: List[str] | None = None
     server_address: str | None = None
     server_port: int | None = None
+    monotonic_start_s: float | None = None
 
 
 @dataclass
@@ -103,6 +104,7 @@ class ExecuteToolInvocation:
     tool_type: str | None = None  # function, extension, datastore
     tool_call_arguments: Any = None
     tool_call_result: Any = None
+    monotonic_start_s: float | None = None
 
 
 @dataclass
@@ -125,6 +127,7 @@ class CreateAgentInvocation:
     # Server information
     server_address: str | None = None
     server_port: int | None = None
+    monotonic_start_s: float | None = None
 
 
 @dataclass
@@ -176,6 +179,7 @@ class InvokeAgentInvocation:
     # Server information
     server_address: str | None = None
     server_port: int | None = None
+    monotonic_start_s: float | None = None
 
 
 @dataclass
@@ -196,6 +200,7 @@ class RetrieveInvocation:
     )
     server_address: str | None = None
     server_port: int | None = None
+    monotonic_start_s: float | None = None
 
 
 @dataclass
@@ -229,3 +234,4 @@ class RerankInvocation:
     output_documents: Any = (
         None  # gen_ai.rerank.output_documents (optional, sensitive)
     )
+    monotonic_start_s: float | None = None