Skip to content

Commit 2487d17

Browse files
committed
fix
1 parent 5625533 commit 2487d17

File tree

3 files changed

+29
-12
lines changed

3 files changed

+29
-12
lines changed

src/paimon/common/global_index/bitmap_global_index_result_test.cpp

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,18 @@ TEST_F(BitmapGlobalIndexResultTest, TestFromRanges) {
188188
}
189189

190190
TEST_F(BitmapGlobalIndexResultTest, TestAddOffset) {
191-
auto result = BitmapGlobalIndexResult::FromRanges({Range(0, 5)});
192-
ASSERT_OK_AND_ASSIGN(auto result_with_offset, result->AddOffset(0));
193-
ASSERT_EQ(result_with_offset->ToString(), "{0,1,2,3,4,5}");
191+
{
192+
auto result = BitmapGlobalIndexResult::FromRanges({Range(0, 5)});
193+
ASSERT_OK_AND_ASSIGN(auto result_with_offset, result->AddOffset(0));
194+
ASSERT_EQ(result_with_offset->ToString(), "{0,1,2,3,4,5}");
194195

195-
ASSERT_OK_AND_ASSIGN(result_with_offset, result->AddOffset(10));
196-
ASSERT_EQ(result_with_offset->ToString(), "{10,11,12,13,14,15}");
196+
ASSERT_OK_AND_ASSIGN(result_with_offset, result->AddOffset(10));
197+
ASSERT_EQ(result_with_offset->ToString(), "{10,11,12,13,14,15}");
198+
}
199+
{
200+
auto result = BitmapGlobalIndexResult::FromRanges({});
201+
ASSERT_OK_AND_ASSIGN(auto result_with_offset, result->AddOffset(10));
202+
ASSERT_EQ(result_with_offset->ToString(), "{}");
203+
}
197204
}
198205
} // namespace paimon::test

src/paimon/common/global_index/bitmap_topk_global_index_result_test.cpp

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,21 @@ TEST_F(BitmapTopKGlobalIndexResultTest, TestInvalidOr) {
237237
}
238238

239239
TEST_F(BitmapTopKGlobalIndexResultTest, TestAddOffset) {
240-
std::vector<int64_t> ids = {1, 2, 3};
241-
std::vector<float> scores = {1.1f, 1.2f, 1.3f};
242-
auto index_result = std::make_shared<BitmapTopKGlobalIndexResult>(RoaringBitmap64::From(ids),
243-
std::move(scores));
244-
ASSERT_OK_AND_ASSIGN(auto result_with_offset, index_result->AddOffset(10));
245-
ASSERT_EQ(result_with_offset->ToString(), "row ids: {11,12,13}, scores: {1.1,1.2,1.3}");
240+
{
241+
std::vector<int64_t> ids = {1, 2, 3};
242+
std::vector<float> scores = {1.1f, 1.2f, 1.3f};
243+
auto index_result = std::make_shared<BitmapTopKGlobalIndexResult>(
244+
RoaringBitmap64::From(ids), std::move(scores));
245+
ASSERT_OK_AND_ASSIGN(auto result_with_offset, index_result->AddOffset(10));
246+
ASSERT_EQ(result_with_offset->ToString(), "row ids: {11,12,13}, scores: {1.1,1.2,1.3}");
247+
}
248+
{
249+
std::vector<int64_t> ids = {};
250+
std::vector<float> scores = {};
251+
auto index_result = std::make_shared<BitmapTopKGlobalIndexResult>(
252+
RoaringBitmap64::From(ids), std::move(scores));
253+
ASSERT_OK_AND_ASSIGN(auto result_with_offset, index_result->AddOffset(10));
254+
ASSERT_EQ(result_with_offset->ToString(), "row ids: {}, scores: {}");
255+
}
246256
}
247257
} // namespace paimon::test

src/paimon/common/utils/roaring_bitmap64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ RoaringBitmap64::RoaringBitmap64(const RoaringBitmap32& other) noexcept {
126126
}
127127

128128
RoaringBitmap64& RoaringBitmap64::operator=(const RoaringBitmap32& other) noexcept {
129-
auto bitmap32 = (static_cast<roaring::Roaring*>(other.roaring_bitmap_));
129+
auto bitmap32 = static_cast<roaring::Roaring*>(other.roaring_bitmap_);
130130
if (!roaring_bitmap_) {
131131
roaring_bitmap_ = new roaring::Roaring64Map(*bitmap32);
132132
} else {

0 commit comments

Comments
 (0)