Skip to content

Commit 4478729

Browse files
lxy-9602SGZW
authored andcommitted
Merge branch 'main' into fix_ut
2 parents ed0707e + b484005 commit 4478729

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/paimon/core/global_index/global_index_scan_impl.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ class GlobalIndexScanImpl : public GlobalIndexScan {
4747
return snapshot_;
4848
}
4949

50-
private:
51-
Status Scan();
52-
5350
Result<std::optional<std::shared_ptr<GlobalIndexResult>>> ParallelScan(
5451
const std::vector<Range>& ranges, const std::shared_ptr<Predicate>& predicate,
5552
const std::shared_ptr<Executor>& executor);
5653

54+
private:
55+
Status Scan();
56+
5757
private:
5858
bool initialized_ = false;
5959
std::shared_ptr<MemoryPool> pool_;

src/paimon/format/orc/complex_predicate_test.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
*/
1616

1717
#include <cstdint>
18-
#include <iostream>
1918
#include <map>
2019
#include <memory>
2120
#include <optional>
22-
#include <ostream>
2321
#include <string>
2422
#include <utility>
2523
#include <vector>
@@ -51,7 +49,6 @@
5149
#include "paimon/status.h"
5250
#include "paimon/testing/utils/read_result_collector.h"
5351
#include "paimon/testing/utils/testharness.h"
54-
#include "paimon/testing/utils/timezone_guard.h"
5552
#include "paimon/utils/roaring_bitmap32.h"
5653

5754
namespace paimon {
@@ -133,7 +130,7 @@ TEST_F(ComplexPredicateTest, TestSimple) {
133130
arrow_vendored::date::current_zone()->name() == "PRC") {
134131
// refer: https://github.com/eggert/tz/blob/main/asia#L653
135132
// When using the Asia/Shanghai timezone, timestamps prior to 1901 have an additional offset
136-
// of 5 minutes and 45 seconds
133+
// of 5 minutes and 43 seconds
137134
expected_array = std::dynamic_pointer_cast<arrow::StructArray>(
138135
arrow::ipc::internal::json::ArrayFromJSON(arrow::struct_({fields}), R"([
139136
[10, 1, 1234, "2033-05-18 03:33:20.0", "123456789987654321.45678"],

src/paimon/format/orc/orc_file_batch_reader_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ TEST_P(OrcFileBatchReaderTest, TestComplexType) {
504504
arrow_vendored::date::current_zone()->name() == "PRC") {
505505
// refer: https://github.com/eggert/tz/blob/main/asia#L653
506506
// When using the Asia/Shanghai timezone, timestamps prior to 1901 have an additional offset
507-
// of 5 minutes and 45 seconds
507+
// of 5 minutes and 43 seconds
508508
array_status = arrow::ipc::internal::json::ChunkedArrayFromJSON(arrow_data_type, {R"([
509509
[10, 1, 1234, "2033-05-18 03:33:20.0", "123456789987654321.45678", "add"],
510510
[10, 1, 19909, "2033-05-18 03:33:20.000001001", "12.30000", "cat"],

0 commit comments

Comments
 (0)