Skip to content

Commit 4520797

Browse files
committed
fix: add release ci workflow and remove global no-access-control
1 parent 322adf2 commit 4520797

File tree

4 files changed

+67
-2
lines changed

4 files changed

+67
-2
lines changed
Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# Copyright 2025-present Alibaba Inc.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
name: Build Release
16+
17+
on:
18+
push:
19+
branches:
20+
- '**'
21+
tags:
22+
- '**'
23+
pull_request:
24+
25+
concurrency:
26+
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
27+
cancel-in-progress: true
28+
29+
permissions:
30+
contents: read
31+
32+
jobs:
33+
clang-release:
34+
runs-on: ubuntu-24.04
35+
timeout-minutes: 120
36+
strategy:
37+
fail-fast: false
38+
steps:
39+
- name: Checkout paimon-cpp
40+
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
41+
with:
42+
lfs: true
43+
- name: Build Paimon
44+
shell: bash
45+
env:
46+
CC: clang
47+
CXX: clang++
48+
run: ci/scripts/build_paimon.sh $(pwd) false false Release
49+
gcc-release:
50+
runs-on: ubuntu-24.04
51+
timeout-minutes: 120
52+
strategy:
53+
fail-fast: false
54+
steps:
55+
- name: Checkout paimon-cpp
56+
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
57+
with:
58+
lfs: true
59+
- name: Build Paimon
60+
shell: bash
61+
env:
62+
CC: gcc-14
63+
CXX: g++-14
64+
run: ci/scripts/build_paimon.sh $(pwd) false false Release

CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,6 @@ if(PAIMON_BUILD_TESTS)
319319
-L
320320
unittest
321321
--output-on-failure)
322-
add_compile_options(-fno-access-control)
323322
add_dependencies(unittest paimon-tests)
324323

325324
include_directories(SYSTEM ${GTEST_INCLUDE_DIR})

ci/scripts/build_paimon.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,15 @@ set -eux
1919
source_dir=${1}
2020
enable_sanitizer=${2:-false}
2121
check_clang_tidy=${3:-false}
22+
build_type=${4:-Debug}
2223
build_dir=${1}/build
2324

2425
mkdir ${build_dir}
2526
pushd ${build_dir}
2627

2728
CMAKE_ARGS=(
2829
"-G Ninja"
29-
"-DCMAKE_BUILD_TYPE=Debug"
30+
"-DCMAKE_BUILD_TYPE=${build_type}"
3031
"-DPAIMON_BUILD_TESTS=ON"
3132
"-DPAIMON_ENABLE_LANCE=ON"
3233
"-DPAIMON_ENABLE_JINDO=ON"

cmake_modules/BuildUtils.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ function(add_test_case REL_TEST_NAME)
256256
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
257257
target_compile_options(${TEST_NAME} PRIVATE -Wno-global-constructors)
258258
endif()
259+
target_compile_options(${TEST_NAME} PRIVATE -fno-access-control)
259260

260261
add_test(${TEST_NAME}
261262
${BUILD_SUPPORT_DIR}/run-test.sh

0 commit comments

Comments
 (0)