fix

Author: lucasfang

src/paimon/format/orc/orc_format_defs.h

@@ -49,7 +49,7 @@ static inline const char ORC_READ_ENABLE_METRICS[] = "orc.read.enable-metrics";
 
 static constexpr uint64_t MIN_ROW_GROUP_COUNT_IN_ONE_NATURAL_READ = 1;
 static inline const char ENABLE_PREFETCH_READ_SIZE_THRESHOLD[] =
-    "aliorc.read.enable-prefetch-read-size-threshold";
+    "orc.read.enable-prefetch-read-size-threshold";
 // Prefetching will not be enabled if the total amount of data queried is below this threshold, as
 // prefetching for very small data sets is not beneficial.
 static constexpr uint64_t DEFAULT_ENABLE_PREFETCH_READ_SIZE_THRESHOLD = 10ull * 1024 * 1024;

src/paimon/format/orc/orc_reader_wrapper.h

@@ -36,7 +36,7 @@
 
 namespace paimon::orc {
 
-// The FileReaderWrapper is a decorator class designed to support GetNextRowToRead.
+// The OrcReaderWrapper is a decorator class designed to support GetNextRowToRead.
 class OrcReaderWrapper {
  public:
     ~OrcReaderWrapper() {
@@ -54,7 +54,7 @@ class OrcReaderWrapper {
             ReadRangeGenerator::Create(reader.get(), natural_read_size, options));
         auto reader_wrapper = std::unique_ptr<OrcReaderWrapper>(
             new OrcReaderWrapper(std::move(reader), std::move(range_generator), file_name,
-                                 batch_size, std::move(arrow_pool), orc_pool));
+                                 batch_size, arrow_pool, orc_pool));
         return reader_wrapper;
     }
 
@@ -76,7 +76,7 @@ class OrcReaderWrapper {
     }
 
     Status SetReadRanges(const std::vector<std::pair<uint64_t, uint64_t>>& read_ranges) {
-        // this is just a hint, apache orc not support this.
+        // Intentionally a no-op: SetReadRanges is a best-effort hint only.
         return Status::OK();
     }
 
@@ -101,7 +101,7 @@ class OrcReaderWrapper {
           range_generator_(std::move(range_generator)),
           file_name_(file_name),
           batch_size_(batch_size),
-          arrow_pool_(std::move(arrow_pool)),
+          arrow_pool_(arrow_pool),
           orc_pool_(orc_pool) {}
 
     std::unique_ptr<::orc::Reader> reader_;

src/paimon/format/orc/read_range_generator.cpp

@@ -142,7 +142,6 @@ double ReadRangeGenerator::BytesPerGroup(const std::vector<uint64_t>& column_ids
     if (reader_->getNumberOfRows() == 0) {
         return 1;
     }
-    std::unordered_set<uint64_t> target_columns(column_ids.begin(), column_ids.end());
     uint64_t max_column_id = std::numeric_limits<uint64_t>::max();
     uint64_t max_length = 0;
     for (const auto& column_id : column_ids) {