Skip to content

Commit 99c9b2a

Browse files
authored
chore: correct minor typos and fix compilation warnings (#17)
1 parent 967ae4f commit 99c9b2a

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

src/paimon/common/global_index/complete_index_score_batch_reader_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ TEST_F(CompleteIndexScoreBatchReaderTest, TestWithBitmap) {
110110
["Alice", 10, null, 0],
111111
["Bob", 11, null, 1],
112112
["Cathy", 12, null, 2],
113-
["Davlid", 13, null, 4]
113+
["David", 13, null, 4]
114114
])")
115115
.ValueOrDie();
116116

@@ -125,7 +125,7 @@ TEST_F(CompleteIndexScoreBatchReaderTest, TestWithBitmap) {
125125
auto array_status =
126126
arrow::ipc::internal::json::ChunkedArrayFromJSON(arrow::struct_(fields), {R"([
127127
["Alice", 10, 1.23, 0],
128-
["Davlid", 13, -19.12, 4]
128+
["David", 13, -19.12, 4]
129129
])"},
130130
&expected_array);
131131
ASSERT_TRUE(array_status.ok());

src/paimon/common/global_index/global_index_result.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Result<PAIMON_UNIQUE_PTR<Bytes>> GlobalIndexResult::Serialize(
9797
} else {
9898
return Status::Invalid(
9999
"invalid GlobalIndexResult, must be BitmapGlobalIndexResult or "
100-
"BitmapTopkGlobalIndexResult");
100+
"BitmapTopKGlobalIndexResult");
101101
}
102102
return MemorySegmentUtils::CopyToBytes(out.Segments(), 0, out.CurrentSize(), pool.get());
103103
}
@@ -108,8 +108,7 @@ Result<std::shared_ptr<GlobalIndexResult>> GlobalIndexResult::Deserialize(
108108
DataInputStream in(input_stream);
109109
PAIMON_ASSIGN_OR_RAISE(int32_t version, in.ReadValue<int32_t>());
110110
if (version != VERSION) {
111-
return Status::Invalid(
112-
fmt::format(fmt::format("invalid version {} for GlobalIndexResult", version)));
111+
return Status::Invalid(fmt::format("invalid version {} for GlobalIndexResult", version));
113112
}
114113
PAIMON_ASSIGN_OR_RAISE(int32_t bitmap_bytes_len, in.ReadValue<int32_t>());
115114
auto bitmap_bytes = Bytes::AllocateBytes(bitmap_bytes_len, pool.get());

src/paimon/common/global_index/global_index_result_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,6 @@ TEST_F(GlobalIndexResultTest, TestInvalidSerialize) {
131131
auto result = std::make_shared<FakeGlobalIndexResult>(std::vector<int64_t>({1, 3, 5, 100}));
132132
ASSERT_NOK_WITH_MSG(GlobalIndexResult::Serialize(result, pool),
133133
"invalid GlobalIndexResult, must be BitmapGlobalIndexResult or "
134-
"BitmapTopkGlobalIndexResult");
134+
"BitmapTopKGlobalIndexResult");
135135
}
136136
} // namespace paimon::test

src/paimon/core/table/source/append_only_table_read.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Result<std::unique_ptr<BatchReader>> AppendOnlyTableRead::CreateReader(
5252
return read->CreateReader(split);
5353
}
5454
}
55-
return Status::Invalid("create reader failed, not read match with data split.");
55+
return Status::Invalid("create reader failed, not read match with split.");
5656
}
5757

5858
} // namespace paimon

src/paimon/core/table/source/data_split_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ bool DataSplitImpl::TEST_Equal(const DataSplitImpl& other) const {
106106

107107
int64_t DataSplitImpl::PartialMergedRowCount() const {
108108
if (!raw_convertible_) {
109-
return 0l;
109+
return 0;
110110
}
111111
int64_t sum = 0;
112112
for (size_t i = 0; i < data_files_.size(); i++) {

0 commit comments

Comments
 (0)