fix: resolve multi thread mkdir error

Author: zjw1111

src/paimon/common/fs/file_system_test.cpp

@@ -979,16 +979,21 @@ TEST_P(FileSystemTest, TestMkdirsFailsWithExistingParentFile) {
 }
 
 TEST_P(FileSystemTest, TestMkdir) {
-    std::string path = PathUtil::JoinPath(test_root_, "/tmp.txt/tmpB");
-    ASSERT_OK(fs_->Mkdirs(path));
+    {
+        std::string path = PathUtil::JoinPath(test_root_, "/tmp.txt/tmpB");
+        ASSERT_OK(fs_->Mkdirs(path));
+    }
+    {
+        std::string path = PathUtil::JoinPath(test_root_, "/tmpA/tmpB/");
+        ASSERT_OK(fs_->Mkdirs(path));
+    }
+    {
+        std::string path = "/";
+        ASSERT_OK(fs_->Mkdirs(path));
+    }
 }
 
 TEST_P(FileSystemTest, TestMkdir2) {
-    std::string path = PathUtil::JoinPath(test_root_, "/tmpA/tmpB/");
-    ASSERT_OK(fs_->Mkdirs(path));
-}
-
-TEST_P(FileSystemTest, TestMkdir3) {
     {
         std::string dir_path = test_root_ + "/file_dir/";
         ASSERT_OK_AND_ASSIGN(bool is_exist, fs_->Exists(dir_path));
@@ -1012,6 +1017,7 @@ TEST_P(FileSystemTest, TestMkdir3) {
     }
 }
 
+// test for create multi dir such as "partition1/bucket1" and "partition1/bucket2"
 TEST_P(FileSystemTest, TestMkdirMultiThread) {
     uint32_t runs_count = 10;
     uint32_t thread_count = 10;
@@ -1036,6 +1042,30 @@ TEST_P(FileSystemTest, TestMkdirMultiThread) {
     }
 }
 
+// test for create multi dir such as "partition1" and "partition1"
+TEST_P(FileSystemTest, TestMkdirMultiThread2) {
+    uint32_t runs_count = 10;
+    uint32_t thread_count = 10;
+    auto executor = CreateDefaultExecutor(thread_count);
+
+    for (uint32_t i = 0; i < runs_count; i++) {
+        std::string uuid;
+        ASSERT_TRUE(UUID::Generate(&uuid));
+        std::vector<std::future<void>> futures;
+        for (uint32_t thread_idx = 0; thread_idx < thread_count; thread_idx++) {
+            futures.push_back(Via(executor.get(), [this, &uuid]() -> void {
+                std::string dir_path = PathUtil::JoinPath(test_root_, uuid);
+                // ASSERT_OK_AND_ASSIGN(bool is_exist, fs_->Exists(dir_path));
+                // ASSERT_FALSE(is_exist);
+                ASSERT_OK(fs_->Mkdirs(dir_path));
+                ASSERT_OK_AND_ASSIGN(bool is_exist, fs_->Exists(dir_path));
+                ASSERT_TRUE(is_exist);
+            }));
+        }
+        Wait(futures);
+    }
+}
+
 TEST_P(FileSystemTest, TestInvalidMkdir) {
     {
         // test mkdir with one exist dir

src/paimon/fs/local/local_file.cpp

@@ -163,9 +163,6 @@ Status LocalFile::Mkdir() const {
             dir.resize(len - 1);
         }
     }
-    if (access(dir.c_str(), F_OK) == 0) {
-        return Status::Exist(fmt::format("directory '{}' already exist", dir));
-    }
     size_t pos = dir.rfind('/');
     if (pos == std::string::npos) {
         if (mkdir(dir.c_str(), 0755) < 0) {
@@ -180,9 +177,11 @@ Status LocalFile::Mkdir() const {
         PAIMON_RETURN_NOT_OK(MkNestDir(parent_dir));
     }
     if (mkdir(dir.c_str(), 0755) < 0) {
-        int32_t cur_errno = errno;
-        return Status::IOError(
-            fmt::format("create directory '{}' failed, ec: {}", dir, std::strerror(cur_errno)));
+        if (errno != EEXIST) {
+            int32_t cur_errno = errno;
+            return Status::IOError(
+                fmt::format("create directory '{}' failed, ec: {}", dir, std::strerror(cur_errno)));
+        }
     }
     return Status::OK();
 }